How can I update these XML values if they have been updated, when parsing XML in C#?

Jordan Johnson
Jordan Johnson used Ask the Experts™
on
I am parsing XML to update if changes are made. A check is done to see if the order already exists, and if so, doesn't add the invoice rows. However, how can I go about modifying the values if they are updated? Since these are nodes within nodes and whatnot, I have also added the XML example here, with the included invoiceRows.

XML

<?xml version="1.0" encoding="UTF-8"?>

-<InvoiceOrder xmlns:xsd="http://www.w3.org/2001/XMLSchema" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance">

<OrderId xmlns="http://24sevenOffice.com/webservices">88844165</OrderId>

<CustomerId xmlns="http://24sevenOffice.com/webservices">7</CustomerId>

<CustomerName xmlns="http://24sevenOffice.com/webservices">Test Company</CustomerName>


-<Addresses xmlns="http://24sevenOffice.com/webservices">


-<Invoice>

<Street>Chestnut Avenue</Street>

<State>Hampshire</State>

<PostalCode>SO53 ABC</PostalCode>

<Name>Test House</Name>

<City>Eastleigh</City>

<Country>UK</Country>

</Invoice>


-<Delivery>

<Street> 56 Test Street</Street>

<PostalCode>BL4 8BE</PostalCode>

<Name>Mrs Hughes</Name>

<City>bolton</City>

<Country>UK</Country>

</Delivery>

</Addresses>

<OrderStatus xmlns="http://24sevenOffice.com/webservices">Invoiced</OrderStatus>

<DateOrdered xmlns="http://24sevenOffice.com/webservices">2015-11-02</DateOrdered>

<PaymentTime>30</PaymentTime>

<IncludeVAT xmlns="http://24sevenOffice.com/webservices">True</IncludeVAT>


-<Currency xmlns="http://24sevenOffice.com/webservices">

<Symbol>LOCAL</Symbol>

</Currency>

<TypeOfSaleId xmlns="http://24sevenOffice.com/webservices">-100</TypeOfSaleId>


-<InvoiceRows xmlns="http://24sevenOffice.com/webservices">


-<InvoiceRow>

<ProductId>H1023</ProductId>

<RowId>1</RowId>

<Price>708.93</Price>

<Name>CADENCE RAD</Name>

<DiscountRate>0.0000</DiscountRate>

<Quantity>1</Quantity>

<Cost>0.0000</Cost>

<InPrice>0.0000</InPrice>

</InvoiceRow>


-<InvoiceRow>

<ProductId>H1206</ProductId>

<RowId>2</RowId>

<Price>188.81</Price>

<Name>DAISY 6 TOWEL WARMER</Name>

<DiscountRate>0.0000</DiscountRate>

<Quantity>1</Quantity>

<Cost>0.0000</Cost>

<InPrice>0.0000</InPrice>

</InvoiceRow>

</InvoiceRows>

</InvoiceOrder>

Open in new window


C# Code

bool orderidfound = false; //checks whether order already exists

                                                    for (int k = 0; k < po.Length; k++)
                                                    {
                                                        if (po[k].OrderId == Convert.ToInt32(fileref.importList["OrderId"].InnerText)) //if order number is equal
                                                        {
                                                            orderidfound = true;
                                                        }
                                               
                                                    }

                                                    if (orderidfound == false) //ensures duplicate invoice rows are not added
                                                    {

                                                        newInvoice.InvoiceRows = order.Elements(ns + "InvoiceRows")
                                                        .Elements(ns + "InvoiceRow")
                                                        .Select(e => new Invoices.InvoiceRow
                                                        {

                                                            ProductId = e.Element(ns + "ProductId") == null ? 0 : (int)e.Element(ns + "ProductId"),
                                                            RowId = e.Element(ns + "RowId") == null ? 0 : (int)e.Element(ns + "RowId"),
                                                            Price = e.Element(ns + "Price") == null ? decimal.Zero : (decimal)e.Element(ns + "Price"),
                                                            Name = e.Element(ns + "Name") == null ? string.Empty : (string)e.Element(ns + "Name"),
                                                            DiscountRate = e.Element(ns + "DiscountRate") == null ? decimal.Zero : (decimal)e.Element(ns + "DiscountRate"),
                                                            Quantity = e.Element(ns + "Quantity") == null ? decimal.Zero : (decimal)e.Element(ns + "Quantity"),
                                                            Cost = e.Element(ns + "Cost") == null ? decimal.Zero : (decimal)e.Element(ns + "Cost"),
                                                            InPrice = e.Element(ns + "InPrice") == null ? decimal.Zero : (decimal)e.Element(ns + "InPrice"),
                                                            ChangeState = invState,
                                                        })
                                                        .ToArray();
                                                    }

Open in new window

Comment
Watch Question

Do more with

Expert Office
EXPERT OFFICE® is a registered trademark of EXPERTS EXCHANGE®
Software Architect
Commented:
Based on my understanding, there are multiple approaches possible,
1. One of the better one could have been to make order object serializable so that directly from XML you can serialize the order object so no need to manually parse the XML file. Also we could have done data binding to the XML as data source.
2. Second could be to just delete/reset/remove the current order object (from the collection if you are maintaining) and recreate a new one irrespective of whether the XML file is modified or newly created. Something like
if( orderidfound==true){
orderobj = new Order();
//Add the order to your collection
}
//After this the code follows the same path as is the case when order is not found

Open in new window

3. Third is to write an else condition to your code if(orderid==false) and in that instead of creating new invoice/invoice rows, based on elements found from XML, using some key like invoice ID, retrieve the corresponding invoice object from the invoice collection present in the already existing order object. And once that invoice row object is retrieved, update this object with the values from the XML file.
Fernando SotoRetired
Distinguished Expert 2017

Commented:
It looks like you are transforming a collection into a XML document and that you are using Linq to XML to do it. If you can show what this is defined as you can Linq in a loop to create the nodes and then attach to the main document.

Author

Commented:
Thanks, this helped me to resolve this. I ended up going the serialization route, as this simplified things greatly!

Do more with

Expert Office
Submit tech questions to Ask the Experts™ at any time to receive solutions, advice, and new ideas from leading industry professionals.

Start 7-Day Free Trial