SQL Server 2014 Cursor in stored procedure never seems to move past the first record. I.e it does not loop

Adimitro
Adimitro used Ask the Experts™
on
Examine the following piece of code:
        set @RM = 'some value'
        set @BASEQTY = 1
        DECLARE UOMSCHED CURSOR SCROLL FOR
      SELECT UOFM,EQUOMQTY FROM tablename WHERE column = @RM
      OPEN UOMSCHED
      FETCH first FROM UOMSCHED INTO @UOFM,@EQUOMQTY
        WHILE  @@FETCH_STATUS = 0
        BEGIN
                  set @cursor_Rows = @@Cursor_rows
                  SET @RMQTYCONVERTED = @BASEQTY /@EQUOMQTY
                  INSERT INTO RM_QTYS (RM_ID,[rmUOM],[QTYrequired])
                  VALUES (@RM,@UOFM,@RMQTYCONVERTED)
            END
      FETCH next FROM UOMSCHED INTO @UOFM,@EQUOMQTY
      CLOSE UOMSCHED;
      DEALLOCATE UOMSCHED;

In this example the SQL Query returns 5 rows. The @@cursor_rows variable also shows that the cursor has 5 rows.
However the variables @UOFM and @RMQTYCONVERTED always store the values of the first record. In other words the cursor does not seem to move to the next record. The purpose of this loop is to determine the quantity of something in 5 different units of measure. The units of measure and the conversion factors are stored in 'tablename'. All 5 calculated results are then inserted into another table 'RM_QTYS'. If there is a way to perform this without a cursor I am happy as well.
Comment
Watch Question

Do more with

Expert Office
EXPERT OFFICE® is a registered trademark of EXPERTS EXCHANGE®
Top Expert 2013
Commented:
The FETCH NEXT command should be inside the WHILE scope, i.e before the END:
 WHILE  @@FETCH_STATUS = 0
        BEGIN
                  set @cursor_Rows = @@Cursor_rows
                  SET @RMQTYCONVERTED = @BASEQTY /@EQUOMQTY
                  INSERT INTO RM_QTYS (RM_ID,[rmUOM],[QTYrequired])
                  VALUES (@RM,@UOFM,@RMQTYCONVERTED)
                 FETCH next FROM UOMSCHED INTO @UOFM,@EQUOMQTY
       END

Open in new window

Jose TorresCertified Database Administrator

Commented:
chaau's answer is correct

Do more with

Expert Office
Submit tech questions to Ask the Experts™ at any time to receive solutions, advice, and new ideas from leading industry professionals.

Start 7-Day Free Trial