Need to display current day,previous day,last twodays data in my code using java

Please find the attachement to see complete method ....
history.txt

Hi ZZYNX,

I have made changes as per your suggerstion.
Please verify my code.
if possible trim the code i mean i have written 100 lines of code to achieve this.

package com.srini;

import java.text.DateFormat;
import java.text.ParseException;
import java.text.SimpleDateFormat;
import java.util.ArrayList;
import java.util.Calendar;
import java.util.Date;
import java.util.LinkedHashMap;
import java.util.List;
import java.util.Map;
import java.util.Set;
import java.util.TreeMap;

public class MapExamples4 {

	public static void main(String[] args) throws ParseException {
		Map<String, String> map = new TreeMap<>();
		map.put("2016-01-14 13:30:00", "253.000");
		map.put("2016-01-14 12:30:00", "53.000");
		map.put("2016-01-15 10:30:00", "353.000");
		map.put("2016-01-15 01:30:00", "563.000");
		map.put("2016-01-16 02:30:00", "693.000");
		map.put("2016-01-16 03:30:00", "283.000");
		map.put("2016-01-15 09:30:00", "273.000");
		Set<String> dateval = map.keySet();
		System.out.println(dateval);
		List<Date> list = new ArrayList<>();
		for (String strDate : dateval) {
			list.add(convertStringToDate(strDate));
		}

		//int days = 2;//To Get Last two days data.
		int days = 1; //To Get current date values
		Map<String, String> filteredMap = new LinkedHashMap<String, String>();
		if (days == 2) {
			filteredMap = getPreviousDateMap(map, list, filteredMap);
		} else if (days == 1) {
			filteredMap = getCurrentDateMap(map, list, filteredMap);
		}

	}

	private static Map<String, String> getCurrentDateMap(Map<String, String> map, List<Date> list,
			Map<String, String> filteredMap) throws ParseException {
		Date d2 = getPreviousDay(1);
		System.out.println("d2 value is" + d2);
		List<Date> afterDateList = new ArrayList<Date>();
		for (Date dateList : list) {
			if (d2.before(dateList)) {
				afterDateList.add(dateList);
			}
		}
		System.out.println("current date is " + afterDateList);
		getFilteredMap(map,filteredMap,afterDateList);
		return filteredMap;
	}

	private static Map<String, String> getPreviousDateMap(
			Map<String, String> map, List<Date> list,
			Map<String, String> filteredMap) throws ParseException {
		Date d1 = getPreviousDay(2);
		System.out.println("d1 value is" + d1);
		List<Date> currentDateList = new ArrayList<Date>();
		for (Date dateList : list) {
			if (d1.before(dateList)) {
				currentDateList.add(dateList);
			}
		}
		System.out.println("before date is " + currentDateList);
		getFilteredMap(map, filteredMap, currentDateList);
		return filteredMap;
	}

	private static void getFilteredMap(Map<String, String> map,
			Map<String, String> filteredMap, List<Date> currentDateList)
			throws ParseException {
		for (Date date : currentDateList) {
			filteredMap.put(convertDateToString(date),
					map.get(convertDateToString(date)));
		}
		System.out.println("FILTERED MAP IS" + filteredMap);
	}

	public static Date convertStringToDate(String strDate)
			throws ParseException {
		DateFormat df2 = new SimpleDateFormat("yyyy-MM-dd HH:mm:ss");
		return df2.parse(strDate);
	}

	public static String convertDateToString(Date strDate)
			throws ParseException {
		DateFormat df2 = new SimpleDateFormat("yyyy-MM-dd HH:mm:ss");
		return df2.format(strDate);
	}

	public static Date getPreviousDay(int days) {
		Calendar cal = Calendar.getInstance(); // now
		cal.add(Calendar.DATE, -days); // Minus one day
		return cal.getTime();
	}

}

Thanks,

Select all Open in new window

if possible trim the code

I would first like you to make it work correctly. Once that is the case, then it is the right time to trim.

I don't know exactly what you're trying to do, but the lines

System.out.println("current date is " + afterDateList);

Select all Open in new window

and

System.out.println("before date is " + currentDateList);

Select all Open in new window

are definitely wrong since afterDateList and currentDateList are ... well Lists of Date's, not one Date.

To avoid calling the method convertDateToString() twice, you can better write

        for (Date date : currentDateList) {
            filteredMap.put(convertDateToString(date),
                map.get(convertDateToString(date)));
        }

Select all Open in new window

as

        for (Date date : currentDateList) {
            String dateAsString = convertDateToString(date);
            filteredMap.put(dateAsString, map.get(dateAsString));
        }

Select all Open in new window

Also, it looks strange to me that you call the result of getPreviousDay(1) "d2"

Date d2 = getPreviousDay(1);

Select all Open in new window

while some lines further you call the result of getPreviousDay(2) "d1"

Date d1 = getPreviousDay(2);

Select all Open in new window

Give your variables clear names; names that indicate what is in it.

Other observation:

Calendar cal = Calendar.getInstance(); // now

Select all Open in new window

This is really now, including hours, minutes, seconds, milliseconds.
Are you sure this is what you want?
Or do you want to start your day limits at midnight?
If you want the latter, you should change the method getPreviousDay() as follows:

    public static Date getPreviousDay(int days) {
        Calendar cal = Calendar.getInstance(); // now
        cal.set(Calendar.HOUR_OF_DAY, 0);
        cal.set(Calendar.MINUTE, 0);
        cal.set(Calendar.SECOND, 0);
        cal.set(Calendar.MILLISECOND, 0); // today @ midnight
        cal.add(Calendar.DATE, -days); // Minus one day
        return cal.getTime();
    }

Select all Open in new window

System.out.println("current date is " + afterDateList);

the above line will print array of list
i can change it as afterDateList.toString();


Date d2 = getPreviousDay(1);
Date d1 = getPreviousDay(2);
i am not sure how to use after method so what i did is for both i have user before method

i may get input 1 or 2
if it is 1 i want to display current date
if it is 2  then i want to display current and previous dates.

int days = 1; //To Get current date values
getCurrentDateMap()
i am getting the o/p as below:
current date is [Mon Jan 18 02:30:00 IST 2016, Mon Jan 18 03:30:00 IST 2016]
FILTERED MAP IS{2016-01-18 02:30:00=693.000, 2016-01-18 03:30:00=283.000}

int days = 2;//To Get Last two days data.
getPreviousDateMap()
i am getting the o/p as below:
before date is [Sun Jan 17 01:30:00 IST 2016, Sun Jan 17 09:30:00 IST 2016, Sun Jan 17 10:30:00 IST 2016, Mon Jan 18 02:30:00 IST 2016, Mon Jan 18 03:30:00 IST 2016]
FILTERED MAP IS{2016-01-17 01:30:00=563.000, 2016-01-17 09:30:00=273.000, 2016-01-17 10:30:00=353.000, 2016-01-18 02:30:00=693.000, 2016-01-18 03:30:00=283.000}

in map i took static date values due to that result got confused.

do you want to start your day limits at midnight?
not required as of now.

Please find the attached code.
MapExample.txt

the above line will print array of list

I know. But I find it very strange to read a sentence like this:
"current date is [Mon Jan 18 10:30:00 CET 2016, Tue Jan 19 02:30:00 CET 2016, Tue Jan 19 03:30:00 CET 2016]"
So the current date is three dates at the same time?

OK. Since your code works as you expect, I think we're done here.
Or do you still expect something from me?

if possible trim the code

I think your code is just fine as it is now.

Thanx 4 axxepting