confirmation on batch script

psexec @clients.txt "doit.bat"

Select allOpen in new window

doit.bat

set resultfile=\\server\share\firefoxrslt.csv
"c:\updates\firefox.exe" -ms 
if errorlevel 0 then (
  echo %computername%,success>>%resultfile%
) else (
  echo %computername%,failed>>%resultfile%
)

Select allOpen in new window

I just tried but it gave me an error,

PsExec could not start doit.bat on computer1

if I did doit.bat itself then will start the installation on the computer trying to launch it

and yet even though it gave me an error I didn't get any results...

psexec @clients.txt -c -f "doit.bat"

Select allOpen in new window

if you do this in a cmd window:

"c:\updates\firefox.exe" -ms
echo %errorlevel%

Select allOpen in new window

...one of the the IF lines should be true.

we got passed the install now, although the result is still not showing up...

Can it see firefox.exe? Move it to a share...

set resultfile=\\server\share\firefoxrslt.csv
"\\server\share\updates\firefox.exe" -ms 
if errorlevel 0 then (
  echo %computername%,success>>%resultfile%
) else (
  echo %computername%,failed>>%resultfile%
)

Select allOpen in new window

I didn't think firefox.exe returned negative errorlevel's, so won't this always be true?

if errorlevel 0 then (

~bp

firefox returns 0 for success and other than that is a failed unless if is directly from a psexec command will give something like 1xxx

so I just recreated something else again and this actually writes a file but the content is not quiet there yet

commander

for /f %%a in (clients.txt) do doit.cmd %%a

Select allOpen in new window

doit

"c:\updates\firefox.exe" -ms 
if %ERRORLEVEL% EQU 0 echo.%%a,success>>result.csv
if %ERRORLEVEL% NEQ 0 echo.%%a,failed>>result.csv

Select allOpen in new window

although the result it gives me is

and it doesn't collect the actual computer name from the variable...
%a      success
%a      success

Try this, the %%a gets passed to doit.bat as the first command line parm, so is referenced in doit.bat as %1.

"c:\updates\firefox.exe" -ms 
if %ERRORLEVEL% EQU 0 (
  echo.%1,success>>result.csv
) else (
  echo.%1,failed>>result.csv
)

Select allOpen in new window

~bp

Let me suggest an alternative solution that is far more expansive and easier... while not free, it's very inexpensive and no long term commitment (though I think HIGHLY worth the price).

Try Ninite - www.ninite.com - the Pro version can be scripted and also deploy to machines it finds in AD all at once.

never found the right answer...