asked on
HI,
I have the following code in my spring mvc controller i want to refactor it .
Please help me write it in a better way.
Things that i want to avoid :
1) I have manually put \" at many places in both the strings contentCss and htmlBody
2) Handling of exception. Is it possible to move it out of controller?
I am extending my controller with a basecontroller where i am handling other exceptions like :
But this approach will not work here...
Any other possible suggestions for refactoring and making it better ?
Thanks
I have the following code in my spring mvc controller i want to refactor it .
private String getBase64EncodedIframeSrc(String body) {
String contentCss = "<link href=\"https://cdn.ckeditor.com/4.5.6/full/contents.css\" rel=\"stylesheet\" type=\"text/css\"/>";
String htmlBody = "<body><div id=\"textArea\" class=\"cke_editable cke_editable_themed cke_contents_ltr cke_show_borders\">" + body + "</div><body>";
String iframeSrc = contentCss + htmlBody;
String base64encodedString= null;
try {
base64encodedString = Base64.getEncoder().encodeToString(iframeSrc.getBytes("utf-8"));
} catch (UnsupportedEncodingException e) {
logger.error("Exception while encoding iframe source in base64",e.getMessage());
}
return base64encodedString;
}
Please help me write it in a better way.
Things that i want to avoid :
1) I have manually put \" at many places in both the strings contentCss and htmlBody
2) Handling of exception. Is it possible to move it out of controller?
I am extending my controller with a basecontroller where i am handling other exceptions like :
@ExceptionHandler(EmptyResultDataAccessException.class)
public ResponseEntity<String> handleServerException(EmptyResultDataAccessException e) {
String message = "Page not found";
logger.error(message, e);
return new ResponseEntity<String>(message, HttpStatus.NOT_FOUND);
}
But this approach will not work here...
Any other possible suggestions for refactoring and making it better ?
Thanks
Learn from the best
Network and collaborate with thousands of CTOs, CISOs, and IT Pros rooting for you and your success.
Andrew Hancock - VMware vExpert
See if this solution works for you by signing up for a 7 day free trial.
Unlock 3 Answers and 4 Comments.
Try for 7 days”The time we save is the biggest benefit of E-E to our team. What could take multiple guys 2 hours or more each to find is accessed in around 15 minutes on Experts Exchange.
Our community of experts have been thoroughly vetted for their expertise and industry experience.
The Distinguished Expert awards are presented to the top veteran and rookie experts to earn the most points in the top 50 topics.