Solved

powershell help

Posted on 2016-07-15
7
106 Views
Last Modified: 2016-07-17
Hi,
I have the following script and it works. I am new to powershell. Could you please modify it so that I can add more than one trustee using input file or comma separated values. I tried to add more than one trustee - for example -trustee domain\user1, domain\user2 but it doesn't accept more than one value.

EXAMPLE   
.\Get-Set-ADAccountasLocalAdministrator.ps1.ps1 -Computer 'Server01,Server02' -Trustee Contoso\HRManagers

.EXAMPLE   
.\Set-ADAccountasLocalAdministrator.ps1 -InputFile C:\ListofComputers.txt -Trustee User01

param(
    [Parameter(ParameterSetName='InputFile')]
    [string]
        $InputFile,
    [Parameter(ParameterSetName='Computer')]
    [string]
        $Computer,
    [string]
        $Trustee
)
<#
.SYNOPSIS
    Function that resolves SAMAccount and can exit script if resolution fails
#>
function Resolve-SamAccount {
param(
    [string]
        $SamAccount,
    [boolean]
        $Exit
)
    process {
        try
        {
            $ADResolve = ([adsisearcher]"(samaccountname=$Trustee)").findone().properties['samaccountname']
        }
        catch
        {
            $ADResolve = $null
        }

        if (!$ADResolve) {
            Write-Warning "User `'$SamAccount`' not found in AD, please input correct SAM Account"
            if ($Exit) {
                exit
            }
        }
        $ADResolve
    }
}

if (!$Trustee) {
    $Trustee = Read-Host "Please input trustee"
}

if ($Trustee -notmatch '\\') {
    $ADResolved = (Resolve-SamAccount -SamAccount $Trustee -Exit:$true)
    $Trustee = 'WinNT://',"$env:userdomain",'/',$ADResolved -join ''
} else {
    $ADResolved = ($Trustee -split '\\')[1]
    $DomainResolved = ($Trustee -split '\\')[0]
    $Trustee = 'WinNT://',$DomainResolved,'/',$ADResolved -join ''
}

if (!$InputFile) {
	if (!$Computer) {
		$Computer = Read-Host "Please input computer name"
	}
	[string[]]$Computer = $Computer.Split(',')
	$Computer | ForEach-Object {
		$_
		Write-Host "Adding `'$ADResolved`' to Administrators group on `'$_`'"
		try {
			([ADSI]"WinNT://$_/Administrators,group").add($Trustee)
			Write-Host -ForegroundColor Green "Successfully completed command for `'$ADResolved`' on `'$_`'"
		} catch {
			Write-Warning "$_"
		}	
	}
}
else {
	if (!(Test-Path -Path $InputFile)) {
		Write-Warning "Input file not found, please enter correct path"
		exit
	}
	Get-Content -Path $InputFile | ForEach-Object {
		Write-Host "Adding `'$ADResolved`' to Administrators group on `'$_`'"
		try {
			([ADSI]"WinNT://$_/Administrators,group").add($Trustee)
			Write-Host -ForegroundColor Green "Successfully completed command"
		} catch {
			Write-Warning "$_"
		}        
	}
}

Open in new window

0
Comment
Question by:creative555
[X]
Welcome to Experts Exchange

Add your voice to the tech community where 5M+ people just like you are talking about what matters.

  • Help others & share knowledge
  • Earn cash & points
  • Learn & ask questions
  • 3
  • 2
7 Comments
 
LVL 85

Accepted Solution

by:
oBdA earned 250 total points
ID: 41715886
You can just call the script in a ForEach loop; inside the loop, the variable with the value currently being processed will be "$_".
So you'll read a file with the trustee names, pipe that to ForEach-Object ("%" is an alias for this), and wherever you want the name from the trustee file appear, you use $_
Get-Content C:\Temp\Trustees.txt | % {.\Set-ADAccountasLocalAdministrator.ps1 -Computer 'Server01,Server02' -Trustee $_}

Open in new window

0
 
LVL 70

Expert Comment

by:Qlemo
ID: 41715900
That has been my first thought, too, but its getting very unefficient for a list of machines. Also, the code is a little cumbersome.
0
 
LVL 70

Assisted Solution

by:Qlemo
Qlemo earned 250 total points
ID: 41715941
This is what I would use (untested!).
function Set-ADAccountAsLocalAdministrator(
  [string]   $InputFile,
  [string[]] $Computer,
  [string[]] $Trustee
)
{
  <#
  .SYNOPSIS
    Assigns user or groups to the local Administrators group

  .EXAMPLE   
    Set-ADAccountasLocalAdministrator -Computer Server01,Server02 -Trustee Contoso\HRManagers,Contoso\ITAdministrators

  .EXAMPLE
    Set-ADAccountasLocalAdministrator -InputFile C:\ListofComputers.txt -Trustee User01
  #>

  <#
  .SYNOPSIS
    Function that resolves SAMAccount and can exit script if resolution fails
  #>

  function Resolve-SamAccount ([string]  $SamAccount)
  {
    try   { ([adsisearcher]"(samaccountname=$Trustee)").findone().properties['samaccountname'] }
    catch { Write-Warning "User `'$SamAccount`' not found in AD, please input correct SAM Account" }
  }



  if ($InputFile)
  {
    if (!(Test-Path -Path $InputFile)) {
      Write-Warning "Input file not found, please enter correct path"
      exit
    }
    $Computer = Get-Content $InputFile
  }

  if (!$Computer) { $Computer = Read-Host "Please input computer name" }
  if (!$Trustee)  { $Trustee  = Read-Host "Please input trustee"       }



  $ADObjs = @()
  foreach ($obj in $Trustee)
  {
    if ($obj -notmatch '\\') {
      $ADResolved  = Resolve-SamAccount -SamAccount $obj
      $DomResolved = $env:UserDomain
    } else {
      $DomResolved, $ADResolved = $obj -split '\\'   
    }
    if ($ADResolved)
    {
      $ADObs += New-Object PsObject -Property @{
        Obj = [ADSI] ("WinNT://$DomResolved/$ADResolved") 
        Res = $ADResolved
      }  
    }
  }

  foreach ($pc in $Computer)
  {
    $localgrp = [ADSI]"WinNT://$pc/Administrators,group"
    foreach ($adobj in $ADObjs)
    {
      Write-Host "Adding '$($adobj.Res)' to Administrators group on '$pc'"
      try   { $localgrp.Add($adobj.Obj) }
      catch { Write-Warning "failed" }
    }
  }
}

Open in new window

You need to dot-source the script once for the current PS session, then run it with your parameters, like (the name of the script doesn't matter anymore, but I'll use the full name):
. c:\Scripts\Set-ADAccountAsLocalAdministrator.ps1
Set-ADAccountAsLocalAdministrator -Computer pc1, pc2 -Trustee dom\usr1, dom\grp1

Open in new window

0
Is Your AD Toolbox Looking More Like a Toybox?

Managing Active Directory can get complicated.  Often, the native tools for managing AD are just not up to the task.  The largest Active Directory installations in the world have relied on one tool to manage their day-to-day administration tasks: Hyena. Start your trial today.

 

Author Comment

by:creative555
ID: 41716263
Hello,
thank you so much!
This works great now with foreach loop! Also, I tried the revised script but it is missing parentheses somewhere. Could you pls paste it again.


 I am getting an error for the remote computers....WARNING: The following exception occurred while retrieving member "add": "The network path was not found

I wonder if we can use remote-powershelling here and invoke-command somehow.

powershell remoting is enabled and all computers are 2012. I was listening to youtube video and they say it is the best to use it for remote computers.

https://www.youtube.com/watch?v=WUgbMKOhShg

if I do this:
invoke-command pc01,pc02,pc02 {get-eventlog -logname } etc I don't get error about network path....but for this current script I do.....

Can we use invoke command with this script? what would be the command?
0
 

Author Comment

by:creative555
ID: 41716270
oh hey,

actually i tried this below but still get network not found error. I am having issue with pinging those computers. it is  timing out. not sure if smth is blocking ping requests but script is working!!


invoke-command {Get-Content C:\CFscript2\Trustee.txt | % {.\Set-ADAccountasLocalAdministrator.ps1 -Computer 'tworker01,worker02.testtarget.local' -Trustee $_}}

thank you so much!
0
 

Author Closing Comment

by:creative555
ID: 41716272
both solutions are great!! I could pick only one best answer. thank you so much!
0

Featured Post

Is Your AD Toolbox Looking More Like a Toybox?

Managing Active Directory can get complicated.  Often, the native tools for managing AD are just not up to the task.  The largest Active Directory installations in the world have relied on one tool to manage their day-to-day administration tasks: Hyena. Start your trial today.

Question has a verified solution.

If you are experiencing a similar issue, please ask a related question

A brief introduction to what I consider to be the best editor for PowerShell.
A project that enables an administrator to perform actions within a user session context not just at the time of login but any time later on day(s) or week(s) later.
Learn the basics of while and for loops in Python.  while loops are used for testing while, or until, a condition is met: The structure of a while loop is as follows:     while <condition>:         do something         repeate: The break statement m…
The viewer will learn how to create a basic form using some HTML5 and PHP for later processing. Set up your basic HTML file. Open your form tag and set the method and action attributes.: (CODE) Set up your first few inputs one for the name and …

630 members asked questions and received personalized solutions in the past 7 days.

Join the community of 500,000 technology professionals and ask your questions.

Join & Ask a Question