bigDiff challenge

You have a copy-paste error in line 12.

Fixing the copy paste error alone won't fix it.

I know that; I'm trying to get him closer to the solution, without giving it to him.

let me check

I know that; I'm trying to get him closer to the solution, without giving it to him.

then you should have said that there are several areas that need attention. Doing it without that hint is not the right way.

If you want to answer this question in your way, go for it. I'm going to answer my way.

I did that already.

public int bigDiff(int[] nums) {
  int large=0;
  int small=0;
  for(int n:nums){
    
  large=  Math.max(large, n);
    //large=n;
  }
  
  for(int n:nums){
    
   small= Math.min(small, n);
   // small=n;
  }
  return (large-small);
}

Select allOpen in new window

i see that issue and fixed it.
Failing below tests

Expected      Run            
bigDiff([10, 3, 5, 6]) → 7      10      X      
bigDiff([7, 2, 10, 9]) → 8      10      X      
bigDiff([2, 10, 7, 2]) → 8      10      X      
bigDiff([2, 10]) → 8      10      X      
bigDiff([10, 2]) → 8      10      X      
bigDiff([10, 0]) → 10      10      OK      
bigDiff([2, 3]) → 1      3      X      
bigDiff([2, 2]) → 0      2      X      
bigDiff([2]) → 0      2      X      
bigDiff([5, 1, 6, 1, 9, 9]) → 8      9      X      
bigDiff([7, 6, 8, 5]) → 3      8      X      
bigDiff([7, 7, 6, 8, 5, 5, 6]) → 3      8      X      
other tests
X      

public int bigDiff(int[] nums) {
  int large=0;
  int small=0;
  int largest=0;
  int smallest=0;
  int result=0;
  int len=nums.length;
  for(int i=0;i<len-1;i++){
    
  large=  Math.max(nums[i], nums[i+1]);
    //large=n;
   // if(large>largest){
      //result=l
    }
  
  
for(int i=0;i<len-1;i++){
    
   small= Math.min(nums[i], nums[i+1]);
   // small=n;
  }
  return (large-small);
}

Select allOpen in new window

with old for loop i passed few more tests but still failing some

Expected      Run            
bigDiff([10, 3, 5, 6]) → 7      1      X      
bigDiff([7, 2, 10, 9]) → 8      1      X      
bigDiff([2, 10, 7, 2]) → 8      5      X      
bigDiff([2, 10]) → 8      8      OK      
bigDiff([10, 2]) → 8      8      OK      
bigDiff([10, 0]) → 10      10      OK      
bigDiff([2, 3]) → 1      1      OK      
bigDiff([2, 2]) → 0      0      OK      
bigDiff([2]) → 0      0      OK      
bigDiff([5, 1, 6, 1, 9, 9]) → 8      0      X      
bigDiff([7, 6, 8, 5]) → 3      3      OK      
bigDiff([7, 7, 6, 8, 5, 5, 6]) → 3      1      X      
other tests
X      

please advise

i think it does compare last one which is wrong i guess instead it should keep value some where and compare each time to upate

small = large

You seem to have posted eight Challenge questions in 40 minutes.
It doesn't seem like you are giving these questions any thought at all.
Why don't you try one at a time and see if you can actually learn something??

That's great . . . but when someone can't even handle the loops effectively yet, it's like missing out a whole chunk of basic CS jumping straight to these meta methods.

Arrays.sort(nums);
return nums[nums.length - 1] - nums[0];

Select allOpen in new window

this is awesome approach. just sort find min and max and find difference

public int bigDiff(int[] nums) {
  
int max=nums[0];
int min=nums[0];
for(int i=0;i<nums.length;i++){
if(max<=nums[i]){
  max=nums[i];
}

if(min>=nums[i]){
  min=nums[i];
}
}
return max-min;
}

Select allOpen in new window

Above also all passing tests