bigDiff challenge

Hi,

I am working on below challenge

http://codingbat.com/prob/p196640
I wrote my code as below


 
public int bigDiff(int[] nums) {
  int large=0;
  int small=0;
  for(int n:nums){
    
  large=  Math.max(large, n);
    //large=n;
  }
  
  for(int n:nums){
    
   small= Math.min(large, n);
   // small=n;
  }
  return (large-small);
}

Open in new window


I am failing few tests
Expected      Run            
bigDiff([10, 3, 5, 6]) → 7      4      X      
bigDiff([7, 2, 10, 9]) → 8      1      X      
bigDiff([2, 10, 7, 2]) → 8      8      OK      
bigDiff([2, 10]) → 8      0      X      
bigDiff([10, 2]) → 8      8      OK      
bigDiff([10, 0]) → 10      10      OK      
bigDiff([2, 3]) → 1      0      X      
bigDiff([2, 2]) → 0      0      OK      
bigDiff([2]) → 0      0      OK      
bigDiff([5, 1, 6, 1, 9, 9]) → 8      0      X      
bigDiff([7, 6, 8, 5]) → 3      3      OK      
bigDiff([7, 7, 6, 8, 5, 5, 6]) → 3      2      X      
other tests
X      

How to improve my design, approach, code? please advise
LVL 7
gudii9Asked:
Who is Participating?
 
awking00Connect With a Mentor Commented:
CodingBat doesn't always point you in the best direction. Rather than dealing with the min and max methods for class, you could just use the sort method for arrays.
int[] nums = {2,7,9,1};
Arrays.sort(nums);
return nums[nums.length - 1] - nums[0];
0
 
CPColinSenior Java ArchitectCommented:
You have a copy-paste error in line 12.
0
 
krakatoaCommented:
Fixing the copy paste error alone won't fix it.
0
Cloud Class® Course: Microsoft Exchange Server

The MCTS: Microsoft Exchange Server 2010 certification validates your skills in supporting the maintenance and administration of the Exchange servers in an enterprise environment. Learn everything you need to know with this course.

 
CPColinSenior Java ArchitectCommented:
I know that; I'm trying to get him closer to the solution, without giving it to him.
0
 
gudii9Author Commented:
let me check
0
 
krakatoaCommented:
I know that; I'm trying to get him closer to the solution, without giving it to him.

then you should have said that there are several areas that need attention. Doing it without that hint is not the right way.
0
 
CPColinSenior Java ArchitectCommented:
If you want to answer this question in your way, go for it. I'm going to answer my way.
0
 
krakatoaCommented:
I did that already.
0
 
gudii9Author Commented:
public int bigDiff(int[] nums) {
  int large=0;
  int small=0;
  for(int n:nums){
    
  large=  Math.max(large, n);
    //large=n;
  }
  
  for(int n:nums){
    
   small= Math.min(small, n);
   // small=n;
  }
  return (large-small);
}

Open in new window


i see that issue and fixed it.
Failing below tests
Expected      Run            
bigDiff([10, 3, 5, 6]) → 7      10      X      
bigDiff([7, 2, 10, 9]) → 8      10      X      
bigDiff([2, 10, 7, 2]) → 8      10      X      
bigDiff([2, 10]) → 8      10      X      
bigDiff([10, 2]) → 8      10      X      
bigDiff([10, 0]) → 10      10      OK      
bigDiff([2, 3]) → 1      3      X      
bigDiff([2, 2]) → 0      2      X      
bigDiff([2]) → 0      2      X      
bigDiff([5, 1, 6, 1, 9, 9]) → 8      9      X      
bigDiff([7, 6, 8, 5]) → 3      8      X      
bigDiff([7, 7, 6, 8, 5, 5, 6]) → 3      8      X      
other tests
X      
0
 
gudii9Author Commented:
public int bigDiff(int[] nums) {
  int large=0;
  int small=0;
  int largest=0;
  int smallest=0;
  int result=0;
  int len=nums.length;
  for(int i=0;i<len-1;i++){
    
  large=  Math.max(nums[i], nums[i+1]);
    //large=n;
   // if(large>largest){
      //result=l
    }
  
  
for(int i=0;i<len-1;i++){
    
   small= Math.min(nums[i], nums[i+1]);
   // small=n;
  }
  return (large-small);
}

Open in new window


with old for loop i passed few more tests but still failing some

Expected      Run            
bigDiff([10, 3, 5, 6]) → 7      1      X      
bigDiff([7, 2, 10, 9]) → 8      1      X      
bigDiff([2, 10, 7, 2]) → 8      5      X      
bigDiff([2, 10]) → 8      8      OK      
bigDiff([10, 2]) → 8      8      OK      
bigDiff([10, 0]) → 10      10      OK      
bigDiff([2, 3]) → 1      1      OK      
bigDiff([2, 2]) → 0      0      OK      
bigDiff([2]) → 0      0      OK      
bigDiff([5, 1, 6, 1, 9, 9]) → 8      0      X      
bigDiff([7, 6, 8, 5]) → 3      3      OK      
bigDiff([7, 7, 6, 8, 5, 5, 6]) → 3      1      X      
other tests
X      

please advise
0
 
CPColinConnect With a Mentor Senior Java ArchitectCommented:
Try printing the values of large and small at the end of each iteration of the loops and see how they change as your code processes one of the tests. You should be able to pick out what's going wrong pretty quickly.
0
 
gudii9Author Commented:
i think it does compare last one which is wrong i guess instead it should keep value some where and compare each time to upate
0
 
krakatoaCommented:
small = large
0
 
d-glitchCommented:
You seem to have posted eight Challenge questions in 40 minutes.
It doesn't seem like you are giving these questions any thought at all.
Why don't you try one at a time and see if you can actually learn something??
0
 
krakatoaCommented:
That's great . . . but when someone can't even handle the loops effectively yet, it's like missing out a whole chunk of basic CS jumping straight to these meta methods.
1
 
gudii9Author Commented:
Arrays.sort(nums);
return nums[nums.length - 1] - nums[0];

Open in new window

this is awesome approach. just sort find min and max and find difference
0
 
gudii9Author Commented:
public int bigDiff(int[] nums) {
  
int max=nums[0];
int min=nums[0];
for(int i=0;i<nums.length;i++){
if(max<=nums[i]){
  max=nums[i];
}

if(min>=nums[i]){
  min=nums[i];
}
}
return max-min;
}

Open in new window


Above also all passing tests
0
Question has a verified solution.

Are you are experiencing a similar issue? Get a personalized answer when you ask a related question.

Have a better answer? Share it in a comment.

All Courses

From novice to tech pro — start learning today.