Solved

How to perform an update query from a UDF that receives parameters from multiple tables?

Posted on 2016-08-01
11
89 Views
Last Modified: 2016-08-02
Hi Experts,

I have a table called Employeestbl

I would like to perform an update to a field of this table to all records that a UDF called EmployeesMissingDocs returns '1'.

Now my main issue is that this UDF expects values as parameters from different tables.

See example below

FUNCTION [dbo].[EmployeesMissingDocs] (
@EmployeeID int,
@Title varchar(50) = null,
@LicenseNumSignedYN bit = null,
@LicenseExpires DATETIME= null,
@BclsExpires DATETIME= null 
) RETURNS VARCHAR(2000)

Open in new window


Where EmployeeID and Title come from Employeestbl, License info come from a second table and Bcls from a third one..

How can I perform this in a single update statement?
0
Comment
Question by:bfuchs
  • 5
  • 3
  • 2
  • +1
11 Comments
 
LVL 48

Expert Comment

by:PortletPaul
Comment Utility
Use a CTE, contruct a query that uses the neede tables and returns the wanted rows. Then update the tsble using that CTE.
0
 
LVL 40

Assisted Solution

by:Sharath
Sharath earned 250 total points
Comment Utility
You can try CROSS APPLY. Replace <join condition> with your actual JOIN condition between tables.

SELECT *
  FROM Employeestbl e
  JOIN License l ON <join condition>
  JOIN third_table a ON <join condition>
 CROSS APPLY (SELECT dbo.EmployeesMissingDocs(e.EmployeeID, e.Title, l.LicenseNumSignedYN, l.LicenseExpires, a.BclsExpires) AS ReturnValue) t1

Open in new window

 UPDATE e
    SET your_column = t1.ReturnValue
   FROM Employeestbl e
  JOIN License l ON <join condition>
  JOIN third_table a ON <join condition>
 CROSS APPLY (SELECT dbo.EmployeesMissingDocs(e.EmployeeID, e.Title, l.LicenseNumSignedYN, l.LicenseExpires, a.BclsExpires) AS ReturnValue) t1

Open in new window

0
 
LVL 45

Expert Comment

by:Kdo
Comment Utility
The UDF really doesn't care where the parameters come from.  It's up to the calling operation to pass the correct parameter(s).

Can you clarify what you're trying to do?
0
 
LVL 3

Author Comment

by:bfuchs
Comment Utility
Hi Experts,

First thanks for replying..

Perhaps you can help me apply your suggestions given the details below:

A- the table/field I'm looking to update is EmployeesJcahoInfo.EmployeeID

(So in other words the SQL statement should be something like "Update EmployeesJcahoInfo.EmployeeID set MyField = False where EmployeesMissingDocs (Param1,Param2,Param3..) = '1')

B- the query joins needed for the UDF parameters are as follows

           
dbo.CoreMandatory RIGHT OUTER JOIN
                         dbo.Employeestbl ON dbo.CoreMandatory.EmployeeID = dbo.Employeestbl.ID LEFT OUTER JOIN
                         dbo.Facilitiestbl LEFT OUTER JOIN
                         dbo.FacilitiesDocumentsRequirements ON dbo.Facilitiestbl.ID = dbo.FacilitiesDocumentsRequirements.FacilityID RIGHT OUTER JOIN
                         dbo.TovInfo ON dbo.Facilitiestbl.Tov_ID1 = dbo.TovInfo.TovCode ON dbo.Employeestbl.ID = dbo.TovInfo.EmployeeID 

Open in new window


C- the list of parameters is quite long (I just listed in OQ the first few), I guess you dont need them, will figure this out already once I have an example.

D- let me know if you need more info.

Thanks,
Ben
0
 
LVL 3

Author Comment

by:bfuchs
Comment Utility
@KDO,
The UDF really doesn't care where the parameters come from.
Well if they would all come from one table (let say EmployeesJcahoInfo), I would have no problem executing it like this
Update EmployeesJcahoInfo.EmployeeID set MyField = False where EmployeesMissingDocs (EmployeesJcahoInfo.Field1,EmployeesJcahoInfo.Field2,EmployeesJcahoInfo.Field3..) = '1')

Open in new window

The whole issue is how to get those parameters supplied, and if I try to do this on a joined sql results then it becomes non updatable.

Thanks,
Ben
0
Highfive + Dolby Voice = No More Audio Complaints!

Poor audio quality is one of the top reasons people don’t use video conferencing. Get the crispest, clearest audio powered by Dolby Voice in every meeting. Highfive and Dolby Voice deliver the best video conferencing and audio experience for every meeting and every room.

 
LVL 45

Accepted Solution

by:
Kdo earned 250 total points
Comment Utility
Hi Ben,

It may be best to write the update statement without relying on the UDF.  It may not code to be the shortest, but it will likely be the fastest and least complicated.

SQL Server allows you to join tables in an UPDATE statement like this:

UPDATE
    mytable
SET
    col1 = value1,
    col2 = value2 ...
FROM
    TableA A
    JOIN
    TableB B
      ON A.colx = B.colxy
  WHERE
    condition(s)

Based on what I've seen in this thread you should be able to fit your requirements (parameters) into this structure.


Kent
0
 
LVL 3

Author Comment

by:bfuchs
Comment Utility
@Kdo,
write the update statement without relying on the UDF......WHERE
    condition(s)
Not sure what you mean by that, as the where condition is the point I need to use the UDF for?
SQL Server allows you to join tables in an UPDATE statement
Are you saying I can have all those outer joins shown above (ID: 41738208) embedded in this update statement?
Thanks,
Ben
0
 
LVL 40

Expert Comment

by:Sharath
Comment Utility
Did you look into my post?
0
 
LVL 45

Expert Comment

by:Kdo
Comment Utility
>> Are you saying I can have all those outer joins shown above (ID: 41738208) embedded in this update statement?

Sure.  All modern database engines support SQL that allows you to join values in a sub-query, though vendors generally don't agree on the correct form so the statements don't always work across platforms without some changes.

Sharath posted an example earlier, too.

Kent
0
 
LVL 3

Author Comment

by:bfuchs
Comment Utility
@Sharath, @Kdo,

Testing it, will let you know..

Thanks,
Ben
0
 
LVL 3

Author Closing Comment

by:bfuchs
Comment Utility
Worked, thank you guys!
0

Featured Post

What Is Threat Intelligence?

Threat intelligence is often discussed, but rarely understood. Starting with a precise definition, along with clear business goals, is essential.

Join & Write a Comment

Suggested Solutions

JSON is being used more and more, besides XML, and you surely wanted to parse the data out into SQL instead of doing it in some Javascript. The below function in SQL Server can do the job for you, returning a quick table with the parsed data.
Ever needed a SQL 2008 Database replicated/mirrored/log shipped on another server but you can't take the downtime inflicted by initial snapshot or disconnect while T-logs are restored or mirror applied? You can use SQL Server Initialize from Backup…
Via a live example, show how to set up a backup for SQL Server using a Maintenance Plan and how to schedule the job into SQL Server Agent.
Using examples as well as descriptions, and references to Books Online, show the documentation available for datatypes, explain the available data types and show how data can be passed into and out of variables.

772 members asked questions and received personalized solutions in the past 7 days.

Join the community of 500,000 technology professionals and ask your questions.

Join & Ask a Question

Need Help in Real-Time?

Connect with top rated Experts

9 Experts available now in Live!

Get 1:1 Help Now