Solved

modThree challenge

Posted on 2016-08-07
4
98 Views
Last Modified: 2016-08-08
I am working on below challenge

http://codingbat.com/prob/p159979

Psedo code description of approach :
1. Loop throguh given array
2. check if array adjacent three elements are even or odd
3. if yes return true
4. if no return false

I wrote my code as below

public boolean modThree(int[] nums) {
  boolean result=false;
  
  for(int i=0;i<nums.length-2;i++){
    if(nums[i]%2==0&&nums[i+1]%2==0&&nums[i+2]%2==0){
      result=true;
      return result;
    }
    
    else if(nums[i+1]%2==0&&nums[i+2]%2==0&&nums[i+3]%2==0){
      result=true;
      return result;
    }
    
     else if(nums[i]%2==1&&nums[i+1]%2==1&&nums[i+2]%2==1){
      result=true;
      return result;
    }
    
    else if(nums[i+1]%2==1&&nums[i+2]%2==1&&nums[i+3]%2==1){
      result=true;
      return result;
    }
    
    
    else{
      result=false;
    }
    //return result;
  }
  return result;
}

Open in new window




I am failing couple of  tests
Expected      Run            
modThree([2, 1, 3, 5]) → true      true      OK      
modThree([2, 1, 2, 5]) → false      false      OK      
modThree([2, 4, 2, 5]) → true      true      OK      
modThree([1, 2, 1, 2, 1]) → false      false      OK      
modThree([9, 9, 9]) → true      true      OK      
modThree([1, 2, 1]) → false      false      OK      
modThree([1, 2]) → false      false      OK      
modThree([1]) → false      false      OK      
modThree([]) → false      false      OK      
modThree([9, 7, 2, 9]) → false      false      OK      
modThree([9, 7, 2, 9, 2, 2]) → false      Exception:java.lang.ArrayIndexOutOfBoundsException: 6 (line number:10)      X      
modThree([9, 7, 2, 9, 2, 2, 6]) → true      true      OK
How to improve my design, approach, code? please advise
0
Comment
Question by:gudii9
4 Comments
 
LVL 27

Expert Comment

by:d-glitch
ID: 41746612
There is one else in your pseudo code, but four in you code.
What does that mean?
0
 
LVL 4

Accepted Solution

by:
Hammadh Abdul Rahman earned 250 total points
ID: 41746640
Just remove lines 10-13 and 20-23. Also, the else block is unnecessary.

As the message says, ArrayIndexOutOfBoundsException is occurring at line 10. The same error is possible at line 20 also.

This is because of the reference to nums[i+3]. modThree([9, 7, 2, 9, 2, 2]) would give a array of length 6. Since i<nums.length-2 is the loop condition, max 'i' value would be 3. So nums[3+3] would give error because highest index is 5.
0
 
LVL 32

Assisted Solution

by:awking00
awking00 earned 250 total points
ID: 41747460
Again, I might suggest starting at index = 2 and searching backwards (e.g. if i is even and i-1 and i-2 are even or i is odd and i-1 and i-2 are odd) to avoid any invalid index. Note, you would need to check for a minimum array length of 3.
0
 
LVL 7

Author Comment

by:gudii9
ID: 41747599
public boolean modThree(int[] nums) {
  boolean result=false;
  
  for(int i=0;i<nums.length-2;i++){
    if(nums[i]%2==0&&nums[i+1]%2==0&&nums[i+2]%2==0){
      result=true;
      return result;
    }
    
  
     else if(nums[i]%2==1&&nums[i+1]%2==1&&nums[i+2]%2==1){
      result=true;
      return result;
    }
    //return result;
  }
  return result;
}

Open in new window

above passed all tests
0

Featured Post

Free Tool: Postgres Monitoring System

A PHP and Perl based system to collect and display usage statistics from PostgreSQL databases.

One of a set of tools we are providing to everyone as a way of saying thank you for being a part of the community.

Question has a verified solution.

If you are experiencing a similar issue, please ask a related question

In this post we will learn how to connect and configure Android Device (Smartphone etc.) with Android Studio. After that we will run a simple Hello World Program.
Today, the web development industry is booming, and many people consider it to be their vocation. The question you may be asking yourself is – how do I become a web developer?
This tutorial explains how to use the VisualVM tool for the Java platform application. This video goes into detail on the Threads, Sampler, and Profiler tabs.
In this fourth video of the Xpdf series, we discuss and demonstrate the PDFinfo utility, which retrieves the contents of a PDF's Info Dictionary, as well as some other information, including the page count. We show how to isolate the page count in a…

830 members asked questions and received personalized solutions in the past 7 days.

Join the community of 500,000 technology professionals and ask your questions.

Join & Ask a Question