Solved

sql server update query

Posted on 2016-08-09
23
33 Views
Last Modified: 2016-08-09
With Guy and stefans help I have a query that returns ConcatWordText I would like to amend it so that StrShort field in the tblwords(w)
is updated with that result.

use Dictionary
go

WITH    Filtered
          AS ( SELECT   W.Word, w.WordPosition, w.clientcode, w.ClientCodeWordPosition, w.StrShort
                    
               FROM     tblwords w
                        LEFT JOIN tblwordtags wt ON W.clientcodeWordPosition = wt.clientcodeWordPosition
               WHERE    wt.word IS NULL and w.ClientCodeWordPosition like '95052350%'
			   
             )
    SELECT  o.ClientCodeWordPosition, o.clientcode, o.StrShort,
            RTRIM(( SELECT  I.Word + ' '
                    FROM    Filtered I
                    WHERE   I.clientcode = O.clientcode
				 order by i.WordPosition
                  FOR
                    XML PATH('')
                  )) AS ConcatWordText, o.WordPosition
    FROM    Filtered O
   order by o.WordPosition

Open in new window

0
Comment
Question by:PeterBaileyUk
  • 14
  • 7
  • 2
23 Comments
 
LVL 46

Accepted Solution

by:
Vitor Montalvão earned 250 total points
ID: 41748594
I'm not into your database model but I guess you want something like:
use Dictionary
go

WITH Filtered
AS ( SELECT W.Word, w.WordPosition, w.clientcode, w.ClientCodeWordPosition, w.StrShort
    FROM tblwords w
		LEFT JOIN tblwordtags wt ON W.clientcodeWordPosition = wt.clientcodeWordPosition
    WHERE wt.word IS NULL and w.ClientCodeWordPosition like '95052350%')

UPDATE tblwords
SET StrShort = RTRIM(SELECT I.Word + ' '
			FROM Filtered I
			WHERE I.clientcode = tblwords.clientcode
			ORDER BY i.WordPosition
			FOR XML PATH(''))

Open in new window

NOTE: Before running this code in a Production environment please run it in a test database to validate the results are the expected ones.
0
 
LVL 142

Expert Comment

by:Guy Hengel [angelIII / a3]
ID: 41748595
0
 

Author Comment

by:PeterBaileyUk
ID: 41748600
yes it didnt seem right to put it in the same question as the query was returning the rows.
0
 

Author Comment

by:PeterBaileyUk
ID: 41748617
its complaining in the last select by the rtrim all names are red, i suspect its bracketing in there

use Dictionary
go

WITH    Filtered
          AS ( SELECT   W.Word, w.WordPosition, w.clientcode, w.ClientCodeWordPosition, w.StrShort
                    
               FROM     tblwords w
                        LEFT JOIN tblwordtags wt ON W.clientcodeWordPosition = wt.clientcodeWordPosition
               WHERE    wt.word IS NULL and w.ClientCodeWordPosition like '95052350%'
			   
             )

			 update TblWords


   SET StrShort = RTRIM (SELECT  I.Word + ' '
                    FROM    Filtered I
                    WHERE   I.clientcode = O.clientcode
				 order by i.WordPosition
                  FOR
                    XML PATH('')
                  )) AS ConcatWordText, o.WordPosition
    FROM    Filtered O
   order by o.WordPosition);

Open in new window

0
 

Author Comment

by:PeterBaileyUk
ID: 41748628
i amended slightly to clarify the output
ee.JPG
0
 
LVL 46

Expert Comment

by:Vitor Montalvão
ID: 41748631
Did you try the update command?
0
 

Author Comment

by:PeterBaileyUk
ID: 41748633
yes it fails on syntax but cannot see why as mentioned ID: 41748617
0
 

Author Comment

by:PeterBaileyUk
ID: 41748636
the select from and where and some brackets are underlined:

SET StrShort = RTRIM (SELECT  I.Word + ' '
                    FROM    Filtered I
                    WHERE   I.clientcode = O.clientcode
                         order by i.WordPosition
                  FOR
                    XML PATH('')
                  )) AS ConcatWordText, o.WordPosition
    FROM    Filtered O
   order by o.WordPosition);
0
 

Author Comment

by:PeterBaileyUk
ID: 41748637
like this
ee.JPG
0
 
LVL 46

Expert Comment

by:Vitor Montalvão
ID: 41748645
That's not my code. You added the last 3 lines. They aren't intended to be there.
0
 

Author Comment

by:PeterBaileyUk
ID: 41748655
aha ok I misunderstood.
0
Zoho SalesIQ

Hassle-free live chat software re-imagined for business growth. 2 users, always free.

 

Author Comment

by:PeterBaileyUk
ID: 41748660
here is the correct snapshot of the screen
ee.JPG
0
 
LVL 46

Expert Comment

by:Vitor Montalvão
ID: 41748664
Did you run it?
Don't forget to test in a non-production environment.
0
 

Author Comment

by:PeterBaileyUk
ID: 41748673
it wont run it says:
Msg 156, Level 15, State 1, Line 11
Incorrect syntax near the keyword 'SELECT'.
Msg 102, Level 15, State 1, Line 15
Incorrect syntax near ')'.
0
 
LVL 46

Expert Comment

by:Vitor Montalvão
ID: 41748687
Ok. I didn't have opportunity to test it.
Can you add SELECT keyword before the RTRIM?
0
 

Author Comment

by:PeterBaileyUk
ID: 41748692
Ive changed to this but its now :
UPDATE tblwords
SET StrShort = SELECT (RTRIM I.Word + ' '

Msg 156, Level 15, State 1, Line 11
Incorrect syntax near the keyword 'SELECT'.
Msg 102, Level 15, State 1, Line 11
Incorrect syntax near 'I'.
0
 

Author Comment

by:PeterBaileyUk
ID: 41748694
and tried this:

UPDATE tblwords
SET StrShort = SELECT (RTRIM (I.Word + ' ')
                  FROM Filtered I
                  WHERE I.clientcode = tblwords.clientcode
                  ORDER BY i.WordPosition
                  FOR XML PATH(''))
0
 
LVL 46

Expert Comment

by:Vitor Montalvão
ID: 41748698
Don't add parenthesis:
UPDATE tblwords
 SET StrShort = SELECT RTRIM I.Word + '
...
0
 
LVL 142

Assisted Solution

by:Guy Hengel [angelIII / a3]
Guy Hengel [angelIII / a3] earned 250 total points
ID: 41748718
there need to be brackets, actually
either it's

set field = RTRIM((SELECT ...))
or
set field = ( SELECT RTRIM( ...) ... )
0
 

Author Comment

by:PeterBaileyUk
ID: 41748735
its looking better, nothing underlined now, it says;

Msg 1033, Level 15, State 1, Line 14
The ORDER BY clause is invalid in views, inline functions, derived tables, subqueries, and common table expressions, unless TOP, OFFSET or FOR XML is also specified.

I suspect its the last error now
use Dictionary
go

WITH Filtered
AS ( SELECT W.Word, w.WordPosition, w.clientcode, w.ClientCodeWordPosition, w.StrShort
    FROM tblwords w
		LEFT JOIN tblwordtags wt ON W.clientcodeWordPosition = wt.clientcodeWordPosition
    WHERE wt.word IS NULL and w.ClientCodeWordPosition like '95052350%')

UPDATE tblwords
SET StrShort = RTRIM((SELECT I.Word + ' '
			FROM Filtered I
			WHERE I.clientcode = tblwords.clientcode
			ORDER BY i.WordPosition))
			FOR XML PATH('')

Open in new window

0
 

Author Comment

by:PeterBaileyUk
ID: 41748746
I did this and i believe, but i will check again that its worked ok.

UPDATE tblwords
SET StrShort = RTRIM((SELECT I.Word + ' '
			FROM Filtered I
			WHERE I.clientcode = tblwords.clientcode
			ORDER BY i.WordPosition

			FOR XML PATH('')))

Open in new window

0
 

Author Closing Comment

by:PeterBaileyUk
ID: 41748762
Thank you to you both.
0
 
LVL 46

Expert Comment

by:Vitor Montalvão
ID: 41748837
Oh, missed a pair of parenthesis.
Glad that you sorted it out.
Cheers
0

Featured Post

Control application downtime with dependency maps

Visualize the interdependencies between application components better with Applications Manager's automated application discovery and dependency mapping feature. Resolve performance issues faster by quickly isolating problematic components.

Question has a verified solution.

If you are experiencing a similar issue, please ask a related question

Having an SQL database can be a big investment for a small company. Hardware, setup and of course, the price of software all add up to a big bill that some companies may not be able to absorb.  Luckily, there is a free version SQL Express, but does …
Everyone has problem when going to load data into Data warehouse (EDW). They all need to confirm that data quality is good but they don't no how to proceed. Microsoft has provided new task within SSIS 2008 called "Data Profiler Task". It solve th…
Using examples as well as descriptions, and references to Books Online, show the documentation available for datatypes, explain the available data types and show how data can be passed into and out of variables.
Viewers will learn how to use the SELECT statement in SQL to return specific rows and columns, with various degrees of sorting and limits in place.

920 members asked questions and received personalized solutions in the past 7 days.

Join the community of 500,000 technology professionals and ask your questions.

Join & Ask a Question

Need Help in Real-Time?

Connect with top rated Experts

20 Experts available now in Live!

Get 1:1 Help Now