• Status: Solved
  • Priority: Medium
  • Security: Public
  • Views: 41
  • Last Modified:

created a new field in sqlserver table but cannot update it.

Ive added a new column to my tblwordtags table and I can see it in the column of the table i would like to update it, it is underlining the column the error message is;
Msg 209, Level 16, State 1, Line 5
Ambiguous column name 'ClientCode'.

this works
select *
from TblWordTags wt
LEFT JOIN tblwords w ON w.clientcodeWordPosition = wt.clientcodeWordPosition;

Open in new window


this does not
Use Dictionary
update TblWordTags
set wt.clientcode=(      'error here
select ClientCode
from TblWordTags wt
LEFT JOIN tblwords w ON W.clientcodeWordPosition = wt.clientcodeWordPosition);

Open in new window


its strange if you look at the screenshot the column is not showing the field to choose.
2016-08-09.png
0
PeterBaileyUk
Asked:
PeterBaileyUk
  • 5
  • 3
  • 2
  • +2
1 Solution
 
Vitor MontalvãoMSSQL Senior EngineerCommented:
Try to add the table name to the column name:

update TblWordTags
set clientcode=(      'error here
select wt.ClientCode
from TblWordTags wt
LEFT JOIN tblwords w ON W.clientcodeWordPosition = wt.clientcodeWordPosition);
0
 
Kent OlsenData Warehouse Architect / DBACommented:
The error's probably on line 3.  Qualify the name there (wt.clientcode or w.clientcode) and you should be fine.


Kent
0
 
Éric MoreauSenior .Net ConsultantCommented:
an update statement should not contain a select clause:
update wt
set clientcode= whichfielddoyouwanthere
from TblWordTags wt
LEFT JOIN tblwords w ON W.clientcodeWordPosition = wt.clientcodeWordPosition

Open in new window

0
Concerto's Cloud Advisory Services

Want to avoid the missteps to gaining all the benefits of the cloud? Learn more about the different assessment options from our Cloud Advisory team.

 
Jim HornMicrosoft SQL Server Developer, Architect, and AuthorCommented:
Couple things wrong with your query:

  • Line 2 : Uses the alias wt., but wt only lives in the subquery in lines 3-5, so line 2 does not know what wt. is.  Remove it.
  • Line 3-5:  Are you certain that that query will return one and only one row?  If not, you'll get a 'Subquery cannot return more than one row' error message, as line 2 attempts to assign a single value to the result of a subquery, which cannot return more than one row.
  • Looks like you're setting tblWordTags.ClientCode to TblWordTags.ClientCode.  Are you sure that is correct?
1
 
PeterBaileyUkAuthor Commented:
tblwords contains the field clientcode with clientcodewordposition as pk in both tables and i want to get each clientcodewordposition that exists in the tblwordtags and update its clientcode to the same value.

the select works here are the rows attached
ee.JPG
0
 
PeterBaileyUkAuthor Commented:
I thought this might work but it doesnt

UPDATE TblWords LEFT JOIN TblWordTags ON TblWords.ClientCodeWordPosition = TblWordTags.ClientCodeWordPosition SET TblWordTags.ClientCode = [TblWords].[ClientCode]
WHERE (((TblWordTags.ClientCodeWordPosition) Is Not Null));

Open in new window

0
 
Éric MoreauSenior .Net ConsultantCommented:
that would be:
update wt
set clientcode= w.clientcode
from TblWordTags wt
LEFT JOIN tblwords w ON W.clientcodeWordPosition = wt.clientcodeWordPosition

Open in new window

0
 
PeterBaileyUkAuthor Commented:
41748967 updated a similar table in access. obviously very different now in transact sql
0
 
Jim HornMicrosoft SQL Server Developer, Architect, and AuthorCommented:
Still not abundantly clear what you are trying to pull off here, but taking the above T-SQL and making the syntax correct.  

UPDATE wt
SET wt.ClientCode = w.ClientCode
FROM TblWords w
   LEFT JOIN TblWordTags wt ON w.ClientCodeWordPosition = wt.ClientCodeWordPosition 
WHERE wt.ClientCodeWordPosition Is Not Null

Open in new window


btw notice the elimination of unnecessary square brackets [] and parentheses marks ().
0
 
Jim HornMicrosoft SQL Server Developer, Architect, and AuthorCommented:
>updated a similar table in access. obviously very different now in transact sql
For a handy guide in converting Access SQL to T-SQL check out  Migrating your Access Queries to SQL Server Transact-SQL
1
 
PeterBaileyUkAuthor Commented:
saved everything then closed and opened sql server and the query on ID: 41748976 that i tried earlier now works.
0
 
PeterBaileyUkAuthor Commented:
thank you
0

Featured Post

[Webinar On Demand] Database Backup and Recovery

Does your company store data on premises, off site, in the cloud, or a combination of these? If you answered “yes”, you need a data backup recovery plan that fits each and every platform. Watch now as as Percona teaches us how to build agile data backup recovery plan.

  • 5
  • 3
  • 2
  • +2
Tackle projects and never again get stuck behind a technical roadblock.
Join Now