Solved

get all customers

Posted on 2016-08-10
2
38 Views
Last Modified: 2016-08-10
hi there ,
i have this query :
Select C.CID,
         C.NID,
         C.ID,
         C.LastName,
         C.FirstName,
          UpdateCode,
          PT.PayTypeName,
         CT.CancellKey,
         CT.CancellReson,
         Is_Cancell,
         RowType,
         ExportDate,
         EV,
        (select tg.ActionName from Tav_Gift tg where tg.ACTID = d.EV) as EventName,
         SibDate,
         SibsodSum
FROM Customers C
left join (
  Select *
, row_number() over(partition by cid order by [SID] DESC) as rn
  From Sibsodim
 ) d on c.cid=d.cid and d.rn=1
 
left join dbo.PaymentsMoves PM
ON C.CID = PM.CID
left join dbo.PayType PT
ON PM.MoveType = PT.PID
left join dbo.CancellTypes CT
on C.CancellResonId = CT.CancellKey
left join dbo.Tav_ShayHamarot
on C.CustCode = CodeNum
where PayTypeName = 'xxx'

in my customer table i have 100 customers
this query get only  the customer that has row in dbo.PaymentsMoves but i want to see all the customers
how can i do it ?
thanks ...
0
Comment
Question by:Tech_Men
2 Comments
 
LVL 12

Accepted Solution

by:
funwithdotnet earned 500 total points
Comment Utility
Well, you could try commenting
--where PayTypeName = 'xxx'

... for starters, since PayTypeName is in PaymentsMoves table. As long as you are filtering based on data in that table, that's all you'll get.

Good luck!
0
 
LVL 48

Expert Comment

by:PortletPaul
Comment Utility
Hi. look back at this answer: ID: 41746497

Remember that you had to change to a left join AND MOVE the condition to the JOIN

also: PLEASE do yourself a favour ALWAYS use table.column or alias.column

e.g. I have no idea which table PayTypeName = 'xxx' comes from, I can make a guess only

and when you look back at this query in 6 months time, or some other person looks at that query, there will always be the question "Which table does PayTypeName come from?"

I guess that PayTypeName is from PT (PT.PayTypeName), see line 11
SELECT ...

FROM Customers C
LEFT JOIN (
            SELECT
                    *
                  , ROW_NUMBER() OVER (PARTITION BY cid ORDER BY [SID] DESC) AS rn
            FROM Sibsodim
        ) d ON c.cid = d.cid AND d.rn = 1
LEFT JOIN dbo.PaymentsMoves PM ON C.CID = PM.CID
LEFT JOIN dbo.PayType PT ON PM.MoveType = PT.PID AND PT.PayTypeName = 'xxx'
LEFT JOIN dbo.CancellTypes CT ON C.CancellResonId = CT.CancellKey
LEFT JOIN dbo.Tav_ShayHamarot ON C.CustCode = CodeNum

Open in new window

0

Featured Post

Maximize Your Threat Intelligence Reporting

Reporting is one of the most important and least talked about aspects of a world-class threat intelligence program. Here’s how to do it right.

Join & Write a Comment

Composite queries are used to retrieve the results from joining multiple queries after applying any filters. UNION, INTERSECT, MINUS, and UNION ALL are some of the operators used to get certain desired results.​
Slowly Changing Dimension Transformation component in data task flow is very useful for us to manage and control how data changes in SSIS.
This video shows, step by step, how to configure Oracle Heterogeneous Services via the Generic Gateway Agent in order to make a connection from an Oracle session and access a remote SQL Server database table.
Viewers will learn how to use the INSERT statement to insert data into their tables. It will also introduce the NULL statement, to show them what happens when no value is giving for any given column.

771 members asked questions and received personalized solutions in the past 7 days.

Join the community of 500,000 technology professionals and ask your questions.

Join & Ask a Question

Need Help in Real-Time?

Connect with top rated Experts

14 Experts available now in Live!

Get 1:1 Help Now