odd characters inserted at end of string during sql server update

PeterBaileyUk
PeterBaileyUk used Ask the Experts™
on
I have this query, it was part of another ee question but I cannot find the id now.

the query is working but ive spotted some odd additions at the end of the string output which shouldnt be there

the query is below. ive highlighted the attachment to show whats added

ive attached an xml output, i suspect its that space at the end causing this, can i get rid of that during the update sql, if indeed thats what it is.

<TblWords ClientCodeWordPosition="07130219__5" StrFull="320 D GT LUXURY " StrShort="320 D GT LUXURY &amp;#x20;" />
<TblWords ClientCodeWordPosition="07130219_320_1" StrFull="320 D GT LUXURY " StrShort="320 D GT LUXURY &amp;#x20;" />
<TblWords ClientCodeWordPosition="07130219_D_2" StrFull="320 D GT LUXURY " StrShort="320 D GT LUXURY &amp;#x20;" />
<TblWords ClientCodeWordPosition="07130219_GT_3" StrFull="320 D GT LUXURY " StrShort="320 D GT LUXURY &amp;#x20;" />
<TblWords ClientCodeWordPosition="07130219_LUXURY_4" StrFull="320 D GT LUXURY " StrShort="320 D GT LUXURY &amp;#x20;" />

Open in new window


use Dictionary
go

WITH Filtered
AS ( SELECT W.Word, w.WordPosition, w.clientcode, w.ClientCodeWordPosition, w.StrShort
    FROM tblwords w
		LEFT JOIN tblwordtags wt ON W.clientcodeWordPosition = wt.clientcodeWordPosition
    WHERE wt.word IS NULL)

UPDATE tblwords
SET StrShort = RTRIM((SELECT I.Word + ' '
			FROM Filtered I
			WHERE I.clientcode = tblwords.clientcode
			ORDER BY i.WordPosition

			FOR XML PATH('')))

Open in new window

ee.JPG
Comment
Watch Question

Do more with

Expert Office
EXPERT OFFICE® is a registered trademark of EXPERTS EXCHANGE®
Vitor MontalvãoMSSQL Senior Engineer
Distinguished Expert 2017

Commented:
I remember that question.
I don't think the issue is with the space since RTRIM is there to get rid of it. The issue might be with the last 6 chars so try this:
use Dictionary
go

WITH Filtered
AS ( SELECT W.Word, w.WordPosition, w.clientcode, w.ClientCodeWordPosition, w.StrShort
    FROM tblwords w
		LEFT JOIN tblwordtags wt ON W.clientcodeWordPosition = wt.clientcodeWordPosition
    WHERE wt.word IS NULL)

UPDATE tblwords
SET StrShort = RTRIM((SELECT LEFT(I.Word, LEN(I.Word)-6) + ' '
			FROM Filtered I
			WHERE I.clientcode = tblwords.clientcode
			ORDER BY i.WordPosition
			FOR XML PATH('')))

Open in new window

Author

Commented:
the output on this one had a where so as to produce 1 client code but what if that six vary in the other rows, anyway i will try it now see what happens.... it failed with this output message:

Msg 537, Level 16, State 3, Line 4
Invalid length parameter passed to the LEFT or SUBSTRING function.

Author

Commented:
I believe its doing this where there are no rows in the join table.
Should you be charging more for IT Services?

Do you wonder if your IT business is truly profitable or if you should raise your prices? Learn how to calculate your overhead burden using our free interactive tool and use it to determine the right price for your IT services. Start calculating Now!

Author

Commented:
so the sql is working fine, I just need to ensure that it doesnt update strshort on an unjoined row or maybe just look for the 6 characters and remove them after the event
Vitor MontalvãoMSSQL Senior Engineer
Distinguished Expert 2017

Commented:
Sorry, I just assumed by your example that all records have those 6 characters. So you might need to test it first:
use Dictionary
go

WITH Filtered
AS ( SELECT W.Word, w.WordPosition, w.clientcode, w.ClientCodeWordPosition, w.StrShort
    FROM tblwords w
		LEFT JOIN tblwordtags wt ON W.clientcodeWordPosition = wt.clientcodeWordPosition
    WHERE wt.word IS NULL)

UPDATE tblwords
SET StrShort = RTRIM((SELECT CASE CHARINDEX('&#x20;',I.Word)
			WHEN 0 THEN I.Word + ' '
			ELSE LEFT(I.Word, CHARINDEX('&#x20;',I.Word)-1) + ' '
         		END Word
		FROM Filtered I
		WHERE I.clientcode = tblwords.clientcode
		ORDER BY i.WordPosition
		FOR XML PATH('')))

Open in new window

Author

Commented:
Those odd characters are still returned and it returned tags which is not right it may be better for me to update the row after the function and remove those specific odd characters

heres a line its got tags of <word> and the offending characters as well.
ClientCodeWordPosition	StrFull	StrShort	StrShortTag
13414B__4	VN1700 CLASSIC TOURER	<Word>VN1700 </Word><Word>CLASSIC </Word><Word>TOURER </Word><Word>&#x20;</Word>	NULL

Open in new window

Author

Commented:
i found a different type &#x20;A8 HYBRID &#x20;

so it can appear anywhere but always the same characters.

i am still reluctant to alter the working function and just have another update process to remove those
&#x20; without leaving duplicates spaces after

Author

Commented:
heres a xml for the one before.

<TblWords ClientCodeWordPosition="04134932__1" StrFull=" A8 HYBRID" StrShort="&amp;#x20;A8 HYBRID &amp;#x20;" />
<TblWords ClientCodeWordPosition="04134932__4" StrFull=" A8 HYBRID" StrShort="&amp;#x20;A8 HYBRID &amp;#x20;" />
<TblWords ClientCodeWordPosition="04134932_A8_2" StrFull=" A8 HYBRID" StrShort="&amp;#x20;A8 HYBRID &amp;#x20;" />
<TblWords ClientCodeWordPosition="04134932_HYBRID_3" StrFull=" A8 HYBRID" StrShort="&amp;#x20;A8 HYBRID &amp;#x20;" />

Open in new window

MSSQL Senior Engineer
Distinguished Expert 2017
Commented:
Okay, let try another approach. This one replaces all &#x20; with '' (empty string):
use Dictionary
go

WITH Filtered
AS ( SELECT W.Word, w.WordPosition, w.clientcode, w.ClientCodeWordPosition, w.StrShort
    FROM tblwords w
		LEFT JOIN tblwordtags wt ON W.clientcodeWordPosition = wt.clientcodeWordPosition
    WHERE wt.word IS NULL)

UPDATE tblwords
SET StrShort = RTRIM((SELECT REPLACE(I.Word,'&#x20;','') + ' '
			FROM Filtered I
			WHERE I.clientcode = tblwords.clientcode
			ORDER BY i.WordPosition
			FOR XML PATH('')))

Open in new window

Author

Commented:
as a trial i did an update on strfull with a left and right trim and the characters still appear so your right its not space related

Author

Commented:
it didnt do the replace heres some output, i think its the right track though just a question as weather it can be done in function

ClientCodeWordPosition	StrFull	StrShort	StrShortTag
04134932__1	A8 HYBRID	&#x20;A8 HYBRID &#x20;	NULL
04134932__4	A8 HYBRID	&#x20;A8 HYBRID &#x20;	NULL
04134932_A8_2	A8 HYBRID	&#x20;A8 HYBRID &#x20;	NULL
04134932_HYBRID_3	A8 HYBRID	&#x20;A8 HYBRID &#x20;	NULL

Open in new window

ok using your idea I did this outside of that particular sql query

use Dictionary


update TblWords
set StrShort=REPLACE(StrShort,'&#x20;','')

Open in new window

Author

Commented:
ok I took your approach and did it post update of strshort, the strings are now fine, its a pain but for now i think its ok, if it starts producing other strings then i will post back.
Vitor MontalvãoMSSQL Senior Engineer
Distinguished Expert 2017

Commented:
Strange that it didn't work in the original query but glad that you sorted it out.
Cheers

Do more with

Expert Office
Submit tech questions to Ask the Experts™ at any time to receive solutions, advice, and new ideas from leading industry professionals.

Start 7-Day Free Trial