odd characters inserted at end of string during sql server update

I have this query, it was part of another ee question but I cannot find the id now.

the query is working but ive spotted some odd additions at the end of the string output which shouldnt be there

the query is below. ive highlighted the attachment to show whats added

ive attached an xml output, i suspect its that space at the end causing this, can i get rid of that during the update sql, if indeed thats what it is.

<TblWords ClientCodeWordPosition="07130219__5" StrFull="320 D GT LUXURY " StrShort="320 D GT LUXURY &amp;#x20;" />
<TblWords ClientCodeWordPosition="07130219_320_1" StrFull="320 D GT LUXURY " StrShort="320 D GT LUXURY &amp;#x20;" />
<TblWords ClientCodeWordPosition="07130219_D_2" StrFull="320 D GT LUXURY " StrShort="320 D GT LUXURY &amp;#x20;" />
<TblWords ClientCodeWordPosition="07130219_GT_3" StrFull="320 D GT LUXURY " StrShort="320 D GT LUXURY &amp;#x20;" />
<TblWords ClientCodeWordPosition="07130219_LUXURY_4" StrFull="320 D GT LUXURY " StrShort="320 D GT LUXURY &amp;#x20;" />

Open in new window


use Dictionary
go

WITH Filtered
AS ( SELECT W.Word, w.WordPosition, w.clientcode, w.ClientCodeWordPosition, w.StrShort
    FROM tblwords w
		LEFT JOIN tblwordtags wt ON W.clientcodeWordPosition = wt.clientcodeWordPosition
    WHERE wt.word IS NULL)

UPDATE tblwords
SET StrShort = RTRIM((SELECT I.Word + ' '
			FROM Filtered I
			WHERE I.clientcode = tblwords.clientcode
			ORDER BY i.WordPosition

			FOR XML PATH('')))

Open in new window

ee.JPG
PeterBaileyUkAsked:
Who is Participating?

[Product update] Infrastructure Analysis Tool is now available with Business Accounts.Learn More

x
I wear a lot of hats...

"The solutions and answers provided on Experts Exchange have been extremely helpful to me over the last few years. I wear a lot of hats - Developer, Database Administrator, Help Desk, etc., so I know a lot of things but not a lot about one thing. Experts Exchange gives me answers from people who do know a lot about one thing, in a easy to use platform." -Todd S.

Vitor MontalvãoMSSQL Senior EngineerCommented:
I remember that question.
I don't think the issue is with the space since RTRIM is there to get rid of it. The issue might be with the last 6 chars so try this:
use Dictionary
go

WITH Filtered
AS ( SELECT W.Word, w.WordPosition, w.clientcode, w.ClientCodeWordPosition, w.StrShort
    FROM tblwords w
		LEFT JOIN tblwordtags wt ON W.clientcodeWordPosition = wt.clientcodeWordPosition
    WHERE wt.word IS NULL)

UPDATE tblwords
SET StrShort = RTRIM((SELECT LEFT(I.Word, LEN(I.Word)-6) + ' '
			FROM Filtered I
			WHERE I.clientcode = tblwords.clientcode
			ORDER BY i.WordPosition
			FOR XML PATH('')))

Open in new window

PeterBaileyUkAuthor Commented:
the output on this one had a where so as to produce 1 client code but what if that six vary in the other rows, anyway i will try it now see what happens.... it failed with this output message:

Msg 537, Level 16, State 3, Line 4
Invalid length parameter passed to the LEFT or SUBSTRING function.
PeterBaileyUkAuthor Commented:
I believe its doing this where there are no rows in the join table.
The 7 Worst Nightmares of a Sysadmin

Fear not! To defend your business’ IT systems we’re going to shine a light on the seven most sinister terrors that haunt sysadmins. That way you can be sure there’s nothing in your stack waiting to go bump in the night.

PeterBaileyUkAuthor Commented:
so the sql is working fine, I just need to ensure that it doesnt update strshort on an unjoined row or maybe just look for the 6 characters and remove them after the event
Vitor MontalvãoMSSQL Senior EngineerCommented:
Sorry, I just assumed by your example that all records have those 6 characters. So you might need to test it first:
use Dictionary
go

WITH Filtered
AS ( SELECT W.Word, w.WordPosition, w.clientcode, w.ClientCodeWordPosition, w.StrShort
    FROM tblwords w
		LEFT JOIN tblwordtags wt ON W.clientcodeWordPosition = wt.clientcodeWordPosition
    WHERE wt.word IS NULL)

UPDATE tblwords
SET StrShort = RTRIM((SELECT CASE CHARINDEX('&#x20;',I.Word)
			WHEN 0 THEN I.Word + ' '
			ELSE LEFT(I.Word, CHARINDEX('&#x20;',I.Word)-1) + ' '
         		END Word
		FROM Filtered I
		WHERE I.clientcode = tblwords.clientcode
		ORDER BY i.WordPosition
		FOR XML PATH('')))

Open in new window

PeterBaileyUkAuthor Commented:
Those odd characters are still returned and it returned tags which is not right it may be better for me to update the row after the function and remove those specific odd characters

heres a line its got tags of <word> and the offending characters as well.
ClientCodeWordPosition	StrFull	StrShort	StrShortTag
13414B__4	VN1700 CLASSIC TOURER	<Word>VN1700 </Word><Word>CLASSIC </Word><Word>TOURER </Word><Word>&#x20;</Word>	NULL

Open in new window

PeterBaileyUkAuthor Commented:
i found a different type &#x20;A8 HYBRID &#x20;

so it can appear anywhere but always the same characters.

i am still reluctant to alter the working function and just have another update process to remove those
&#x20; without leaving duplicates spaces after
PeterBaileyUkAuthor Commented:
heres a xml for the one before.

<TblWords ClientCodeWordPosition="04134932__1" StrFull=" A8 HYBRID" StrShort="&amp;#x20;A8 HYBRID &amp;#x20;" />
<TblWords ClientCodeWordPosition="04134932__4" StrFull=" A8 HYBRID" StrShort="&amp;#x20;A8 HYBRID &amp;#x20;" />
<TblWords ClientCodeWordPosition="04134932_A8_2" StrFull=" A8 HYBRID" StrShort="&amp;#x20;A8 HYBRID &amp;#x20;" />
<TblWords ClientCodeWordPosition="04134932_HYBRID_3" StrFull=" A8 HYBRID" StrShort="&amp;#x20;A8 HYBRID &amp;#x20;" />

Open in new window

Vitor MontalvãoMSSQL Senior EngineerCommented:
Okay, let try another approach. This one replaces all &#x20; with '' (empty string):
use Dictionary
go

WITH Filtered
AS ( SELECT W.Word, w.WordPosition, w.clientcode, w.ClientCodeWordPosition, w.StrShort
    FROM tblwords w
		LEFT JOIN tblwordtags wt ON W.clientcodeWordPosition = wt.clientcodeWordPosition
    WHERE wt.word IS NULL)

UPDATE tblwords
SET StrShort = RTRIM((SELECT REPLACE(I.Word,'&#x20;','') + ' '
			FROM Filtered I
			WHERE I.clientcode = tblwords.clientcode
			ORDER BY i.WordPosition
			FOR XML PATH('')))

Open in new window

Experts Exchange Solution brought to you by

Your issues matter to us.

Facing a tech roadblock? Get the help and guidance you need from experienced professionals who care. Ask your question anytime, anywhere, with no hassle.

Start your 7-day free trial
PeterBaileyUkAuthor Commented:
as a trial i did an update on strfull with a left and right trim and the characters still appear so your right its not space related
PeterBaileyUkAuthor Commented:
it didnt do the replace heres some output, i think its the right track though just a question as weather it can be done in function

ClientCodeWordPosition	StrFull	StrShort	StrShortTag
04134932__1	A8 HYBRID	&#x20;A8 HYBRID &#x20;	NULL
04134932__4	A8 HYBRID	&#x20;A8 HYBRID &#x20;	NULL
04134932_A8_2	A8 HYBRID	&#x20;A8 HYBRID &#x20;	NULL
04134932_HYBRID_3	A8 HYBRID	&#x20;A8 HYBRID &#x20;	NULL

Open in new window

PeterBaileyUkAuthor Commented:
ok using your idea I did this outside of that particular sql query

use Dictionary


update TblWords
set StrShort=REPLACE(StrShort,'&#x20;','')

Open in new window

PeterBaileyUkAuthor Commented:
ok I took your approach and did it post update of strshort, the strings are now fine, its a pain but for now i think its ok, if it starts producing other strings then i will post back.
Vitor MontalvãoMSSQL Senior EngineerCommented:
Strange that it didn't work in the original query but glad that you sorted it out.
Cheers
It's more than this solution.Get answers and train to solve all your tech problems - anytime, anywhere.Try it for free Edge Out The Competitionfor your dream job with proven skills and certifications.Get started today Stand Outas the employee with proven skills.Start learning today for free Move Your Career Forwardwith certification training in the latest technologies.Start your trial today
Microsoft SQL Server

From novice to tech pro — start learning today.