Graeme McGilvray
asked on
Issue with Loop
Hi all, I have set up a category of items to display in a 2 wide format.
The 1st and 2nd item display perfectly fine, however the 3rd is missed but the 4th takes its place
Here is the code:
I believe it would have to do with this section:
however I dont know how to fix it :(
Help please!
The 1st and 2nd item display perfectly fine, however the 3rd is missed but the 4th takes its place
Here is the code:
<%
If Request.QueryString("category")>0 Then
Set CatItins=oConn.Execute("SELECT * FROM itinerary WHERE brand_ID='"&SubDomain("brand_short")&"' AND itin_depdate>#"&NOW()&"# AND itin_type="&Request.QueryString("category")&" AND itin_live=TRUE ORDER BY itin_depdate")
%>
<table width=1000 border=0 cellpadding=0 cellspacing=0>
<tr>
<td width=1000 height=56 bgcolor=white valign=top colspan=3>
<table bordercolor=<%=BGColor%> bgcolor=<%=BGColor%> border=3 cellpadding=0 cellspacing=0 width=1000 height=50>
<tr>
<td> <font class=menu size=5> // <%=HomeRow%></td>
</tr>
</table>
</td>
</tr>
<%
Count=1
Do Until CatItins.EOF
If Count=1 Then
%>
<tr>
<td height=20 colspan=3> </td>
</tr>
<tr>
<td width=490 height=76 bgcolor=white valign=top>
<table bordercolor=<%=BGColor%> border=3 cellpadding=0 cellspacing=0 width=490 height=278 bgcolor=white>
<tr>
<td>
<table width=478 height=84 align=center valign=top>
<tr>
<td colspan=2 height=30 valign=middle> <img src=http://members.amnet.net.au/~webber4/supplier-<%=CatItins("supplier_ID")%>.png height=26> <font size=5><b><a href=?category=<%=CatItins("itin_type")%>&itin=<%=CatItins("itin_ID")%>><%=CatItins("itin_name")%></a></b></font>
<br><font size=2> -Nights
<%
If CatItins("itin_type")=39 Then
Response.Write(" of ")
Else
Response.Write(" from ")
End If
Set Ports=oConnAE.Execute("SELECT * FROM IATA WHERE IATA='"&CatItins("itin_depcity")&"'")
Response.Write(Ports("IATA_name")&", ")
%>
Departs: <%=WeekdayName(Weekday(CatItins("itin_depdate")),TRUE)&" "&CatItins("itin_depdate")%></font></td>
</tr>
</table>
<table width=478 height=190>
<tr>
<%
If fs.fileexists("e:\activenquiry.info\www\images\ship-"&CatItins("ship_ID")&".jpg") Then
Response.Write("<td align=center valign=top height=180 background=http://members.amnet.net.au/~webber4/ship-"&CatItins("ship_ID")&".jpg style='background-size: cover; background-position: center,center' rowspan=3></td>")
ElseIf fs.fileexists("e:\activenquiry.info\www\images\city-"&CatItins("itin_depcity")&".jpg") Then
Response.Write("<td align=center valign=top height=180 background=http://members.amnet.net.au/~webber4/city-"&CatItins("itin_depcity")&".jpg style='background-size: cover; background-position: center,center' rowspan=3></td>")
ElseIf fs.fileexists("e:\activenquiry.info\www\images\country-"&CatItins("itin_depcity")&".jpg") Then
Response.Write("<td align=center valign=top height=180 background=http://members.amnet.net.au/~webber4/country-"&CatItins("itin_depcity")&".jpg style='background-size: cover; background-position: center,center' rowspan=3></td>")
Else
Response.Write("<td align=center valign=top height=180 rowspan=3></td>")
End If
Set Cat=oConn.Execute("SELECT * FROM category,category_type WHERE type_ID=cat_type_ID AND itin_ID="&CatItins("itin_ID")&" ORDER BY cat_price")
TotalCat=0
Do Until Cat.EOF
If TotalCat=3 Then
Exit Do
Else
Response.Write("<td height=35 valign=middle style='background-size: cover; background-position: center,center' width=190 align=right><font size=2><b>"&Cat("cat_type_name")&"</b></font>")
If Cat("cat_soldout")=TRUE Then
Response.Write("<br><b>SOLD OUT</b>")
Else
Response.Write("<br><font size=2>fr <b><font size=4>"&FormatCurrency(Cat("cat_price"),0)&"</font>pp*</b> twin share")
End If
Response.Write("</td>")
Response.Write("</tr>")
Response.Write("<tr>")
TotalCat=TotalCat+1
End If
Cat.MoveNext
Loop
%> </table>
</td>
</tr>
</table>
</td>
<td width=20> </td>
<%
Count=Count+1
ElseIf Count=2 Then
%>
<td width=490 height=76 bgcolor=white valign=top>
<table bordercolor=<%=BGColor%> border=3 cellpadding=0 cellspacing=0 width=490 height=278 bgcolor=white>
<tr>
<td>
<table width=478 height=84 align=center valign=top>
<tr>
<td colspan=2 height=30 valign=middle> <img src=http://members.amnet.net.au/~webber4/supplier-<%=CatItins("supplier_ID")%>.png height=26> <font size=5><b><a href=?category=<%=CatItins("itin_type")%>&itin=<%=CatItins("itin_ID")%>><%=CatItins("itin_name")%></a></b></font>
<br><font size=2> -Nights
<%
If CatItins("itin_type")=39 Then
Response.Write(" of ")
Else
Response.Write(" from ")
End If
Set Ports=oConnAE.Execute("SELECT * FROM IATA WHERE IATA='"&CatItins("itin_depcity")&"'")
Response.Write(Ports("IATA_name")&", ")
%>
Departs: <%=WeekdayName(Weekday(CatItins("itin_depdate")),TRUE)&" "&CatItins("itin_depdate")%></font></td>
</tr>
</table>
<table width=478 height=190>
<tr>
<%
If fs.fileexists("e:\activenquiry.info\www\images\ship-"&CatItins("ship_ID")&".jpg") Then
Response.Write("<td align=center valign=top height=180 background=http://members.amnet.net.au/~webber4/ship-"&CatItins("ship_ID")&".jpg style='background-size: cover; background-position: center,center' rowspan=3></td>")
ElseIf fs.fileexists("e:\activenquiry.info\www\images\city-"&CatItins("itin_depcity")&".jpg") Then
Response.Write("<td align=center valign=top height=180 background=http://members.amnet.net.au/~webber4/city-"&CatItins("itin_depcity")&".jpg style='background-size: cover; background-position: center,center' rowspan=3></td>")
ElseIf fs.fileexists("e:\activenquiry.info\www\images\country-"&CatItins("itin_depcity")&".jpg") Then
Response.Write("<td align=center valign=top height=180 background=http://members.amnet.net.au/~webber4/country-"&CatItins("itin_depcity")&".jpg style='background-size: cover; background-position: center,center' rowspan=3></td>")
Else
Response.Write("<td align=center valign=top height=180 rowspan=3></td>")
End If
Set Cat=oConn.Execute("SELECT * FROM category,category_type WHERE type_ID=cat_type_ID AND itin_ID="&CatItins("itin_ID")&" ORDER BY cat_price")
TotalCat=0
Do Until Cat.EOF
If TotalCat=3 Then
Exit Do
Else
Response.Write("<td height=35 valign=middle style='background-size: cover; background-position: center,center' width=190 align=right><font size=2><b>"&Cat("cat_type_name")&"</b></font>")
If Cat("cat_soldout")=TRUE Then
Response.Write("<br><b>SOLD OUT</b>")
Else
Response.Write("<br><font size=2>fr <b><font size=4>"&FormatCurrency(Cat("cat_price"),0)&"</font>pp*</b> twin share")
End If
Response.Write("</td>")
Response.Write("</tr>")
Response.Write("<tr>")
TotalCat=TotalCat+1
End If
Cat.MoveNext
Loop
%> </table>
</td>
</tr>
</table>
</td>
</tr>
<%
Count=Count+1
ElseIf Count>2 Then
Count=1
End If
CatItins.MoveNext
Loop
%>
</tr>
</table>
<%
End If
%>
I believe it would have to do with this section:
<%
Count=Count+1
ElseIf Count>2 Then
Count=1
End If
CatItins.MoveNext
Loop
%>
however I dont know how to fix it :(
Help please!
ASKER
Hi Guy and thank you very much for that, wouldnt that conflict where i already have:
I have tested it and it makes no difference (prob due to the conflict)
ElseIF Count=2 Then
?I have tested it and it makes no difference (prob due to the conflict)
ASKER CERTIFIED SOLUTION
membership
This solution is only available to members.
To access this solution, you must be a member of Experts Exchange.
ASKER
Thanks for that, however it was quite confusing in the way you set it out.
All works, thank you
All works, thank you
should be:
ElseIf Count>=2 Then
because if you processed item 2, you go back to "col1"