Solved

Macro to delete blank rows and run from drop down list

Posted on 2016-08-17
14
39 Views
Last Modified: 2016-08-18
Hi Experts Using Excel 2013

See attached file

I want the macro to run from the drop down in sheet “Master” cell B2. i have the following code in the Worksheet module

Private Sub Worksheet_Change(ByVal Target As Range)
    If Target.Address = "$B$2" Then
        Call CopyandPasteValues
    End If
End Sub


The following copy and paste macro works fine I believe See below…
Sub CopyandPasteValues()

    Sheets("Data").Columns("AW").Copy
    Sheets("Unique List").Range("$A$1:$A:$A$3500").PasteSpecial Paste:=xlPasteValues, Operation:=xlNone, SkipBlanks _
                                                                                          :=False, Transpose:=False
    Application.CutCopyMode = False
    Sheets("Unique List").Range("$A$1:$A$3500").RemoveDuplicates Columns:=Array(1, 2), _
                                                                 Header:=xlYes

End Sub

Open in new window


But need to add function to remove blank rows from the data set, not sure how to integrate this part..

well this all work...
Test-1234.xlsx
0
Comment
Question by:route217
  • 7
  • 4
  • 3
14 Comments
 
LVL 28

Accepted Solution

by:
Subodh Tiwari (Neeraj) earned 500 total points
ID: 41760611
If your intention is to copy the Employee's names from col. A of Data into col. A of Unique List sheet, try this.....


Sub CopyandPasteValues()
Application.ScreenUpdating = False
Sheets("Unique List").Columns(1).ClearContents
Sheets("Data").Range("A:A").SpecialCells(xlCellTypeConstants).Copy
Sheets("Unique List").Range("A1").PasteSpecial Paste:=xlPasteValues
Application.CutCopyMode = False
Sheets("Unique List").Range("A:A").RemoveDuplicates Columns:=1, Header:=xlYes
Application.ScreenUpdating = True
End Sub

Open in new window

0
 

Author Comment

by:route217
ID: 41760619
And remove blank rows too
0
 

Author Comment

by:route217
ID: 41760623
Excellent the macro work but can i use the following to run the macro from a drop down list...

Private Sub Worksheet_Change(ByVal Target As Range) 
    If Target.Address = "$B$2" Then
        Call CopyandPasteValues
    End If
End Sub

Open in new window


Add the following to ThisWorksheet
0
 
LVL 28

Expert Comment

by:Subodh Tiwari (Neeraj)
ID: 41760624
That's because your drop down list is in B1 not in B2, so change the following line...

If Target.Address = "$B$2"

Open in new window


TO THIS
If Target.Address = "$B$1"

Open in new window

0
 
LVL 28

Expert Comment

by:Subodh Tiwari (Neeraj)
ID: 41760627
Right click the Master Tab --> View Code and place the following code into the opened code window.

Private Sub Worksheet_Change(ByVal Target As Range) 
    If Target.Address = "$B$1" Then
        Call CopyandPasteValues
    End If
End Sub

Open in new window

0
 

Author Comment

by:route217
ID: 41760628
Many thank excellence feedback.
0
 
LVL 28

Expert Comment

by:Subodh Tiwari (Neeraj)
ID: 41760630
You're welcome. Glad to help.
0
Is Your Active Directory as Secure as You Think?

More than 75% of all records are compromised because of the loss or theft of a privileged credential. Experts have been exploring Active Directory infrastructure to identify key threats and establish best practices for keeping data safe. Attend this month’s webinar to learn more.

 
LVL 17

Expert Comment

by:Roy_Cox
ID: 41761275
SpecialCells will cause an error if no cells match the criteria so it's best to use an error handler. If an error occurs and the macro fails then Screen Updating will not be restored automatically. I would amend the code slightly
Option Explicit

Sub CopyandPasteValues()
    On Error GoTo exit_proc
    With Application
        .ScreenUpdating = False
        With Sheets("Unique List")
            .Columns(1).ClearContents
            Sheets("Data").Range("A:A").SpecialCells(xlCellTypeConstants).Copy
            .Range("A1").PasteSpecial Paste:=xlPasteValues
            .Range("A:A").RemoveDuplicates Columns:=1, Header:=xlYes
        End With
exit_proc:
MsgBox "An error occurred", vbCritical, "Quitting"
        .CutCopyMode = False
        .ScreenUpdating = True
    End With
End Sub

Open in new window

0
 
LVL 28

Expert Comment

by:Subodh Tiwari (Neeraj)
ID: 41761305
@Roy

There are so many ifs and buts...
like what if Sheet Unique List or Sheet Data doesn't exists in the workbook?
With the kind of error handling you included in your code will suppress the error only, if any, during the code execution and will prompt the user in the end that "An error occurred" but with no clue of what error has been occurred. In other words, this will only stop the debug window to appear.
Won't it be better if the error message also includes the Err.Description, I think then only your error handling makes any sense.
0
 
LVL 17

Expert Comment

by:Roy_Cox
ID: 41761323
Makes more sense than no error handling. It was only a quick suggestion
0
 
LVL 17

Expert Comment

by:Roy_Cox
ID: 41761325
Amended code

Option Explicit

Sub CopyandPasteValues()

    On Error GoTo exit_proc

    On Error GoTo exit_proc
    With Application
        .ScreenUpdating = False
        With Sheets("Unique List")
            .Columns(1).ClearContents
            Sheets("Data").Range("A:A").SpecialCells(xlCellTypeConstants).Copy
            .Range("A1").PasteSpecial Paste:=xlPasteValues
            .Range("A:A").RemoveDuplicates Columns:=1, Header:=xlYes
        End With
exit_proc:
        MsgBox "Error " & Err.Number & " (" & Err.Description & ") in procedure CopyandPasteValues of Module Module1"
        .CutCopyMode = False
        .ScreenUpdating = True
    End With
    On Error GoTo 0

End Sub

Open in new window

0
 
LVL 28

Expert Comment

by:Subodh Tiwari (Neeraj)
ID: 41761327
I am happy that you got my point. :)
0
 
LVL 17

Expert Comment

by:Roy_Cox
ID: 41761356
I didn't get your point, I was only trying to help  the OP by suggesting a slight amendment to your code. Didn't expect criticism from you when I didn't start by criticizing your original post. My point was simply really to avoid an error using SpecialCells. I then noticed ScreenUpdating, which can be very confusing to a beginner if it is not restored by the code, I don't really see what advantage there is in using it with your code, but it wouldn't be a problem unless an un-trapped error occurred.

I've just spotted a typo in my code, it should be
Option Explicit


Sub CopyandPasteValues()

    On Error GoTo exit_proc
   
    With Application
        .ScreenUpdating = False
        With Sheets("Unique List")
            .Columns(1).ClearContents
            Sheets("Data").Range("A:A").SpecialCells(xlCellTypeConstants).Copy
            .Range("A1").PasteSpecial Paste:=xlPasteValues
            .Range("A:A").RemoveDuplicates Columns:=1, Header:=xlYes
        End With
exit_proc:
        MsgBox "Error " & Err.Number & " (" & Err.Description & ") in procedure CopyandPasteValues of Module Module1"
        .CutCopyMode = False
        .ScreenUpdating = True
    End With
    On Error GoTo 0

End Sub

Open in new window


Although I think this is all that is bneeded

Option Explicit


Sub CopyandPasteValues()

    On Error GoTo exit_proc

        With Sheets("Unique List")
            .Columns(1).ClearContents
            Sheets("Data").Range("A:A").SpecialCells(xlCellTypeConstants).Copy
            .Range("A1").PasteSpecial Paste:=xlPasteValues
            .Range("A:A").RemoveDuplicates Columns:=1, Header:=xlYes
        End With
exit_proc:
        MsgBox "Error " & Err.Number & " (" & Err.Description & ") . Probable cause is that no cells could be found for the macro to work with"
        Application.CutCopyMode = False
    On Error GoTo 0

End Sub
0
 
LVL 28

Expert Comment

by:Subodh Tiwari (Neeraj)
ID: 41761389
haha
0

Featured Post

Is Your Active Directory as Secure as You Think?

More than 75% of all records are compromised because of the loss or theft of a privileged credential. Experts have been exploring Active Directory infrastructure to identify key threats and establish best practices for keeping data safe. Attend this month’s webinar to learn more.

Question has a verified solution.

If you are experiencing a similar issue, please ask a related question

Approximate matching with VLOOKUP and MATCH seems to me to be a greatly under-used technique, and one which is vital for getting good performance out of large lookups. Until recently I would always have advised using an exact match for simplicity an…
Improved? Move/Copy Add-in Replacement - How to avoid the annoying, “A formula or sheet you want to move or copy contains the name XXX, which already exists on the destination worksheet.” David Miller (dlmille)  It was one of those days… I wa…
This Micro Tutorial demonstrates how to create Excel charts: column, area, line, bar, and scatter charts. Formatting tips are provided as well.
This Micro Tutorial will demonstrate on a Mac how to change the sort order for chart legend values and decrpyt the intimidating chart menu.

920 members asked questions and received personalized solutions in the past 7 days.

Join the community of 500,000 technology professionals and ask your questions.

Join & Ask a Question

Need Help in Real-Time?

Connect with top rated Experts

12 Experts available now in Live!

Get 1:1 Help Now