Solved

Core java. Please help me catch a bug.

Posted on 2016-08-22
5
74 Views
Last Modified: 2016-08-31
To make story short, I simplify the code as much as possible.  Please help me to catch a bug. What do I miss ? I know about HashSet and I know how to use google. I'm interesting in my particular code.

package TaskChAll;

import java.util.Arrays;


public class Taskv4_interestingBUG2 {

    public static String removeAllDuplications(int[] initialArray) {
        int size = initialArray.length;
        System.out.println("Size before deletion: " + size);
        for (int i = 0; i < size; i++) {
            for (int j = i + 1; j < size; j++) {
                if (initialArray[i] == initialArray[j]) {   // step 1
                    while (j < (size) - 1) {    // inside this loop step 2
                        initialArray[j] = initialArray[j + 1];
                        j++;
                    }
                    size--; // step 3
                }
            }
        }
        int[] outputArray = new int[size]; // step 4
        for (int k = 0; k < size; k++) {
            outputArray[k] = initialArray[k];
        }
       // initialArray = outputArray;
        if (isThereDublication(outputArray)) {
            removeAllDuplications(outputArray);
        }
        return Arrays.toString(outputArray);
    }

    protected static boolean isThereDublication(int[] initialArray) {
        for (int i = 0; i < initialArray.length - 1; i++) {
            for (int j = i + 1; j < initialArray.length - 1; j++) {
                if ((initialArray[i] == initialArray[j]) && (i != j)) {
                    return true;
                }
            }
        }
        return false;
    }
}

Open in new window


package TaskChAll;



public class Taskv4Test_interestingBUG2 {

    public static void main(String[] args) {
        testRemoveAllDuplications();
    }

    private static void testRemoveAllDuplications() {
        System.out.println("To pass the test enter number of elements '5'");
        int[] vectorWithDuplication = {4, 2, 53, 2, 53,53,53};

       //  String  expectedTestResults = "{4, 2, 53}";
        

        System.out.println(Taskv4_interestingBUG.removeAllDuplications(vectorWithDuplication)); 

       

    }
}

Open in new window

0
Comment
Question by:SunnyX
5 Comments
 
LVL 8

Expert Comment

by:James Bilous
ID: 41765783
What are the symptoms of your problem? What is going wrong?
0
 

Author Comment

by:SunnyX
ID: 41765804
the output : [4, 2, 53, 53]

I don't know, I never saw such before. On debugging the code doing everything that I expect every assign  right output to the "outputArray" array. However, somehow reassign on the wrong one and return it. Please, copy past this code to the ide ( I tried intellij idea and eclipse both show wrong result ) take a look what happen during debugging , quite interesting.
0
 
LVL 14

Assisted Solution

by:CPColin
CPColin earned 350 total points
ID: 41765811
When you call removeAllDuplications() again, you're modifying the array you're passing into it, but you're not keeping track of the updated size of the array, so you're never actually discarding that last duplicate value.

Edit: Maybe.
0
 
LVL 35

Accepted Solution

by:
mccarl earned 150 total points
ID: 41766342
There are 3 problems with your code above...

- CPColin has found one of them, yes you have a call to the removeAllDuplications method (line 28) but you AREN'T doing anything with the return value. Add a   return   keyword in front of line 28 so that you return the String that it generates.

 - Now that alone won't change anything though. Why? Because in this particular test case, you aren't actually calling removeAllDuplicates the second time. That's because there is a problem in your isThereDublication method. You AREN'T checking the last element in the array and so it never sees the two 53's.  You need to remove the   " - 1"   after initialArray.length from the inner loop (line 25)

 - The above two steps will resolve the issues HOWEVER, I assume that you went to the trouble of doing the recursive removeAllDuplicates call because the first loop wasn't fully removing all duplicates. The EASIEST way to fix all this is to just do it properly in the first place. If you add a line     j = i;     just after line 18 above, your j variable will do the right thing and you will remove ALL the duplicates in one go. You can then delete lines 27 - 29, and then delete the extra method at lines 33 - 42.
1
 

Author Closing Comment

by:SunnyX
ID: 41778274
Thx!
0

Featured Post

Networking for the Cloud Era

Join Microsoft and Riverbed for a discussion and demonstration of enhancements to SteelConnect:
-One-click orchestration and cloud connectivity in Azure environments
-Tight integration of SD-WAN and WAN optimization capabilities
-Scalability and resiliency equal to a data center

Question has a verified solution.

If you are experiencing a similar issue, please ask a related question

Suggested Solutions

Title # Comments Views Activity
How to get all the API from website? 11 106
check java version using powershell 13 181
hibernate example using maven 12 59
How do I remove an object from a 3 40
After being asked a question last year, I went into one of my moods where I did some research and code just for the fun and learning of it all.  Subsequently, from this journey, I put together this article on "Range Searching Using Visual Basic.NET …
Introduction This article is the last of three articles that explain why and how the Experts Exchange QA Team does test automation for our web site. This article covers our test design approach and then goes through a simple test case example, how …
Viewers learn about the “for” loop and how it works in Java. By comparing it to the while loop learned before, viewers can make the transition easily. You will learn about the formatting of the for loop as we write a program that prints even numbers…
This video teaches viewers about errors in exception handling.

828 members asked questions and received personalized solutions in the past 7 days.

Join the community of 500,000 technology professionals and ask your questions.

Join & Ask a Question