scoresIncreasing challenge

Hi,

I am working on below challege.
http://codingbat.com/prob/p146974
my psedo code :
1. loop thorugh given array.
2. compare first array element with second and alsos third with second to make sure later is bigger than earlier one.
3. if yes return true.
4. if no return false

public boolean scoresIncreasing(int[] scores) {
  boolean result=false;
  int len=scores.length;
for(int i=0;i<len;i++){
  if(scores[i+1]>scores[i]&&scores[i+2]>scores[i+1]){
    result=true;
    
    return result;
  }
}
return result;
  
}

Open in new window


Expected      Run            
scoresIncreasing([1, 3, 4]) → true      true      OK      
scoresIncreasing([1, 3, 2]) → false      Exception:java.lang.ArrayIndexOutOfBoundsException: 3 (line number:5)      X      
scoresIncreasing([1, 1, 4]) → true      Exception:java.lang.ArrayIndexOutOfBoundsException: 3 (line number:5)      X      
scoresIncreasing([1, 1, 2, 4, 4, 7]) → true      true      OK      
scoresIncreasing([1, 1, 2, 4, 3, 7]) → false      true      X      
scoresIncreasing([-5, 4, 11]) → true      true      OK      
Your progress graph for this problem

i am failing few tests. How to fix and improve my code. please advise
LVL 7
gudii9Asked:
Who is Participating?
 
Gerwin Jansen, EE MVEConnect With a Mentor Topic Advisor Commented:
Your if statement is too complex, you only need one comparison.
1
 
gudii9Author Commented:
public boolean scoresIncreasing(int[] scores) {
  boolean result=true;
  int len=scores.length;
for(int i=0;i<len-2;i++){
  if(scores[i+1]<scores[i]||scores[i+2]<scores[i+1]){
    result=false;
    
    return result;
  }
}
return result;
  
}

Open in new window


above passed all tests. Any improvements/refinement/refactoring my code?
0
 
awking00Connect With a Mentor Commented:
Without requiring a loop -
int[] sorted = scores.clone();
Arrays.sort(sorted);
return Arrays.equals(scores, sorted);
0
Free Tool: Port Scanner

Check which ports are open to the outside world. Helps make sure that your firewall rules are working as intended.

One of a set of tools we are providing to everyone as a way of saying thank you for being a part of the community.

 
gudii9Author Commented:
public boolean scoresIncreasing(int[] scores) {
  boolean result=true;
  int len=scores.length;
for(int i=0;i<len-1;i++){
  if(scores[i+1]<scores[i]){
    result=false;
    
    return result;
  }
}
return result;
  
}

Open in new window


passing all tests
0
 
gudii9Author Commented:
public boolean scoresIncreasing(int[] scores) {
int[] sorted = scores.clone();
Arrays.sort(sorted);
return Arrays.equals(scores, sorted);
  
}

Open in new window


i like this solution too
0
 
gudii9Author Commented:
i hope no other changes?
0
 
mccarlIT Business Systems Analyst / Software DeveloperCommented:
No change to your logic, but I think the local variables actually make it harder to understand, compare your solution to this... same logic but just reads differently...
public boolean scoresIncreasing(int[] scores) {
    for (int i = 0; i < scores.length - 1; i++) {
        if (scores[i+1] < scores[i]) {
            return false;
        }
    }
    return true;
}

Open in new window

0
 
gudii9Author Commented:
public boolean scoresIncreasing(int[] scores) {
    for (int i = 0; i < scores.length - 1; i++) {
        if (scores[i+1] < scores[i]) {
            return false;
        }
    }
    return true;
}

Open in new window


above is much better
0
 
mccarlIT Business Systems Analyst / Software DeveloperCommented:
A few tips on tidying up code like that...

- Look for variables that are only used once. Now, if the variable name doesn't add any extra information, you might consider removing it like we did above. For example, scores.length is pretty obvious in what it means, and "len" doesn't add anything. This isn't always the case, so don't just blindly remove ALL of them, but just think it through.

- Secondly, look for cases where you are setting a variable to just immediately return it, ie. the "result" variable in the if statement above. And then once you tidy that up, apply the first tip above and you can get rid of it completely.
0
 
gudii9Author Commented:
sure
0
Question has a verified solution.

Are you are experiencing a similar issue? Get a personalized answer when you ask a related question.

Have a better answer? Share it in a comment.

All Courses

From novice to tech pro — start learning today.