Drastically shorten your training time with WalkMe's advanced online training solution that Guides your trainees to action. Forget about retraining and skyrocket knowledge retention rates.
Course Of The Month
Become a Premium Member and unlock a new, free course in leading technologies each month.
Solved
scoresIncreasing challenge
Posted on 2016-08-26
Hi,
I am working on below challege.
http://codingbat.com/prob/p146974
my psedo code :
1. loop thorugh given array.
2. compare first array element with second and alsos third with second to make sure later is bigger than earlier one.
3. if yes return true.
4. if no return false
i am failing few tests. How to fix and improve my code. please advise
I am working on below challege.
http://codingbat.com/prob/p146974
my psedo code :
1. loop thorugh given array.
2. compare first array element with second and alsos third with second to make sure later is bigger than earlier one.
3. if yes return true.
4. if no return false
public boolean scoresIncreasing(int[] scores) {
boolean result=false;
int len=scores.length;
for(int i=0;i<len;i++){
if(scores[i+1]>scores[i]&&scores[i+2]>scores[i+1]){
result=true;
return result;
}
}
return result;
}
Expected Run
scoresIncreasing([1, 3, 4]) → true true OK
scoresIncreasing([1, 3, 2]) → false Exception:java.lang.ArrayIndexOutOfB oundsExcep tion: 3 (line number:5) X
scoresIncreasing([1, 1, 4]) → true Exception:java.lang.ArrayIndexOutOfB oundsExcep tion: 3 (line number:5) X
scoresIncreasing([1, 1, 2, 4, 4, 7]) → true true OK
scoresIncreasing([1, 1, 2, 4, 3, 7]) → false true X
scoresIncreasing([-5, 4, 11]) → true true OK
Your progress graph for this problem
i am failing few tests. How to fix and improve my code. please advise
[X]
Welcome to Experts Exchange
Add your voice to the tech community where 5M+ people just like you are talking about what matters.
- Help others & share knowledge
- Earn cash & points
- Learn & ask questions
-
6
2
- +1
10 Comments
Active today
public boolean scoresIncreasing(int[] scores) {
boolean result=true;
int len=scores.length;
for(int i=0;i<len-2;i++){
if(scores[i+1]<scores[i]||scores[i+2]<scores[i+1]){
result=false;
return result;
}
}
return result;
}
above passed all tests. Any improvements/refinement/re
Active today
Without requiring a loop -
int[] sorted = scores.clone();
Arrays.sort(sorted);
return Arrays.equals(scores, sorted);
int[] sorted = scores.clone();
Arrays.sort(sorted);
return Arrays.equals(scores, sorted);
Active today
public boolean scoresIncreasing(int[] scores) {
boolean result=true;
int len=scores.length;
for(int i=0;i<len-1;i++){
if(scores[i+1]<scores[i]){
result=false;
return result;
}
}
return result;
}
passing all tests
Active today
public boolean scoresIncreasing(int[] scores) {
int[] sorted = scores.clone();
Arrays.sort(sorted);
return Arrays.equals(scores, sorted);
}
i like this solution too
Active 2 days ago
No change to your logic, but I think the local variables actually make it harder to understand, compare your solution to this... same logic but just reads differently...
public boolean scoresIncreasing(int[] scores) {
for (int i = 0; i < scores.length - 1; i++) {
if (scores[i+1] < scores[i]) {
return false;
}
}
return true;
}
Active today
public boolean scoresIncreasing(int[] scores) {
for (int i = 0; i < scores.length - 1; i++) {
if (scores[i+1] < scores[i]) {
return false;
}
}
return true;
}
above is much better
Active 2 days ago
A few tips on tidying up code like that...
- Look for variables that are only used once. Now, if the variable name doesn't add any extra information, you might consider removing it like we did above. For example, scores.length is pretty obvious in what it means, and "len" doesn't add anything. This isn't always the case, so don't just blindly remove ALL of them, but just think it through.
- Secondly, look for cases where you are setting a variable to just immediately return it, ie. the "result" variable in the if statement above. And then once you tidy that up, apply the first tip above and you can get rid of it completely.
- Look for variables that are only used once. Now, if the variable name doesn't add any extra information, you might consider removing it like we did above. For example, scores.length is pretty obvious in what it means, and "len" doesn't add anything. This isn't always the case, so don't just blindly remove ALL of them, but just think it through.
- Secondly, look for cases where you are setting a variable to just immediately return it, ie. the "result" variable in the if statement above. And then once you tidy that up, apply the first tip above and you can get rid of it completely.
Featured Post
Are you interested in becoming an AWS Certified Solutions Architect?
Discover a new interactive way of training for the exam.
Question has a verified solution.
If you are experiencing a similar issue, please ask a related question
Whether you’re a college noob or a soon-to-be pro, these tips are sure to help you in your journey to becoming a programming ninja and stand out from the crowd.
Part One of the two-part Q&A series with MalwareTech.
This theoretical tutorial explains exceptions, reasons for exceptions, different categories of exception and exception hierarchy.
Suggested Courses
Earn Certification
HTML5 Specialist - Certification
Free withPremium
Course of the Month3 days, 17 hours left to enroll
630 members asked questions and received personalized solutions in the past 7 days.
Join the community of 500,000 technology professionals and ask your questions.