Solved

wordsCount challenge

Posted on 2016-08-28
10
72 Views
Last Modified: 2016-08-30
Hi,

I wrote as below and passing all tests
public int wordsCount(String[] words, int len) {
int count=0;
for(int i=0;i<words.length;i++){
  if(words[i].length()==len){
    count++;
    
  }
  
  
}
return count;
  
}

Open in new window


any improvement to this?
0
Comment
Question by:gudii9
  • 4
  • 3
  • 2
  • +1
10 Comments
 
LVL 37

Expert Comment

by:zzynx
ID: 41774403
>> any improvement to this?
Yes.
1) Give us the url of the challenge
2) Correctly indent your code
0
 
LVL 35

Assisted Solution

by:mccarl
mccarl earned 125 total points
ID: 41774404
You didn't link to the problem but I can pretty much deduce the requirements from the code. I wouldn't have done anything different to what you have done.
0
 
LVL 32

Accepted Solution

by:
awking00 earned 250 total points
ID: 41774657
Only a slight modification to what you have done -
int count = 0;
for (String word : words) {
  if (word.length == len) {
    count++;
  }
}
return count;
0
Is Your AD Toolbox Looking More Like a Toybox?

Managing Active Directory can get complicated.  Often, the native tools for managing AD are just not up to the task.  The largest Active Directory installations in the world have relied on one tool to manage their day-to-day administration tasks: Hyena. Start your trial today.

 
LVL 37

Expert Comment

by:zzynx
ID: 41774670
@awking00
That's a modification. But is it an improvement?
Also, only advisable when gudii9 is working with Java 8
0
 
LVL 32

Expert Comment

by:awking00
ID: 41774679
It wasn't meant as an improvement. I was only trying to show gudii9 an alternate means of looping through an array other than incrementing an index.
0
 
LVL 37

Expert Comment

by:zzynx
ID: 41774707
It wasn't meant as an improvement.
It's good that that is cleared out now. Since he asked for improvements.

Correction: my remark about Java 8 is incorrect.
0
 
LVL 7

Author Comment

by:gudii9
ID: 41775287
for (String word : words) {
i like above.
0
 
LVL 7

Author Comment

by:gudii9
ID: 41775288
for each loop right?
0
 
LVL 7

Author Comment

by:gudii9
ID: 41775294
oops here is the URL of the problem.
http://codingbat.com/prob/p124620
 How to indent codingbat code without starting eclipse which some times takes time?

I used

http://codebeautify.org/javaviewer

it gave exact output after beautifying
beautify.png
0
 
LVL 37

Assisted Solution

by:zzynx
zzynx earned 125 total points
ID: 41775853
for each loop right?
Right

I used
http://codebeautify.org/javaviewer
it gave exact output after beautifying
That gives you an indentation of 1 space. Which is better than nothing.
But that's not what you posted.

How to indent codingbat code without starting eclipse which some times takes time?
By indenting by hand (= adding 4 spaces). It's so worth the effort. You gain readability for yourself and us.

Concerning your real question: there's nothing to improve.
0

Featured Post

U.S. Department of Agriculture and Acronis Access

With the new era of mobile computing, smartphones and tablets, wireless communications and cloud services, the USDA sought to take advantage of a mobilized workforce and the blurring lines between personal and corporate computing resources.

Question has a verified solution.

If you are experiencing a similar issue, please ask a related question

Suggested Solutions

Title # Comments Views Activity
Where to store the queries for modification of table 4 63
session migration servlets 2 38
ForLoop Example 3 49
How do I remove an object from a 3 27
INTRODUCTION Working with files is a moderately common task in Java.  For most projects hard coding the file names, using parameters in configuration files, or using command-line arguments is sufficient.   However, when your application has vi…
Introduction This article is the second of three articles that explain why and how the Experts Exchange QA Team does test automation for our web site. This article covers the basic installation and configuration of the test automation tools used by…
Viewers will learn about arithmetic and Boolean expressions in Java and the logical operators used to create Boolean expressions. We will cover the symbols used for arithmetic expressions and define each logical operator and how to use them in Boole…
This tutorial covers a practical example of lazy loading technique and early loading technique in a Singleton Design Pattern.

803 members asked questions and received personalized solutions in the past 7 days.

Join the community of 500,000 technology professionals and ask your questions.

Join & Ask a Question