copyEvens challenge

gudii9
gudii9 used Ask the Experts™
on
I am working on below challenge
http://codingbat.com/prob/p134174

Psedo code:
0. create new array of given count
1. for given arry loop through it
2. check if each element is even or not
3. if even fill till the new array ends
4. return new array
I wrote my code as below

public int[] copyEvens(int[] nums, int count) {
  int[] arr=new int[count];
  for(int i=0;i<nums.length-1;i++){
    if(nums[i]%2==0){
      arr[i]=nums[i];
      
      
    }
  }
  return arr;
}

Open in new window






I am not passing all tests
xpected      Run            
copyEvens([3, 2, 4, 5, 8], 2) → [2, 4]      Exception:java.lang.ArrayIndexOutOfBoundsException: 2 (line number:5)      X      
copyEvens([3, 2, 4, 5, 8], 3) → [2, 4, 8]      [0, 2, 4]      X      
copyEvens([6, 1, 2, 4, 5, 8], 3) → [6, 2, 4]      Exception:java.lang.ArrayIndexOutOfBoundsException: 3 (line number:5)      X      
copyEvens([6, 1, 2, 4, 5, 8], 4) → [6, 2, 4, 8]      [6, 0, 2, 4]      X      
copyEvens([3, 1, 4, 1, 5], 1) → [4]      Exception:java.lang.ArrayIndexOutOfBoundsException: 2 (line number:5)      X      
copyEvens([2], 1) → [2]      [0]      X      
copyEvens([6, 2, 4, 8], 2) → [6, 2]      Exception:java.lang.ArrayIndexOutOfBoundsException: 2 (line number:5)      X      
copyEvens([6, 2, 4, 8], 3) → [6, 2, 4]      [6, 2, 4]      OK      
copyEvens([6, 2, 4, 8], 4) → [6, 2, 4, 8]      [6, 2, 4, 0]      X      
copyEvens([1, 8, 4], 1) → [8]      Exception:java.lang.ArrayIndexOutOfBoundsException: 1 (line number:5)      X      
copyEvens([1, 8, 4], 2) → [8, 4]      [0, 8]      X      
copyEvens([2, 8, 4], 2) → [2, 8]      [2, 8]      OK      
other tests
X      
Your progress graph for this problem

How to improve/modify my design, code and any other alternate approaches. please advise
Comment
Watch Question

Do more with

Expert Office
EXPERT OFFICE® is a registered trademark of EXPERTS EXCHANGE®
In for loop it should be
I < nums.length

And other observation is,  you are passing no of even elements are 2 but in actuality trying to access 3. So getting array out of bound exception
int temp =0;

for(int i=0;i<nums.length;i++){
      if(nums[i]%2==0 &&  temp < count){
          arr[temp++]=nums[i];
      }
}

But this code can be improved.
public int[] copyEvens(int[] nums, int count) {
  int[] arr=new int[count];
  int temp = 0;
  for(int i=0; i<nums.length; i++){
    if(nums[i]%2==0 &&  temp < count){ 
          arr[temp++]=nums[i]; 
    }
  }
  return arr;
}

Open in new window

Ensure you’re charging the right price for your IT

Do you wonder if your IT business is truly profitable or if you should raise your prices? Learn how to calculate your overhead burden using our free interactive tool and use it to determine the right price for your IT services. Start calculating Now!

Better would be instead of iterating all elements of array, loop only upto your count is reached and exit from loop.

Ex:
public int[] copyEvens(int[] nums, int count) {
  int[] arr=new int[count];
  int temp = 0;
  for(int i=0; (temp < count) && (i < nums.length); ++i){
    if(nums[i]%2==0){ 
          arr[temp++]=nums[i]; 
    }
  }
  return arr;
}

Open in new window

Commented:
FYI ... gudii9 has posted about 20 challenges from codingbat.com site...just to watch you guys jump through hoops. Is that what EE does? If it is, I for one, am leaving...

Author

Commented:
public int[] copyEvens(int[] nums, int count) {
  int[] arr=new int[count];
  int temp = 0;
  for(int i=0;(temp<count)&&(i<nums.length);i++){
    if(nums[i]%2==0){
      arr[temp++]=nums[i];
      
      
    }
  }
  return arr;
}

Open in new window


i like temp approach. Above (with i++ instead of ++i) also passed all tests. Any difference using i++ or ++i in this challenge?

Do more with

Expert Office
Submit tech questions to Ask the Experts™ at any time to receive solutions, advice, and new ideas from leading industry professionals.

Start 7-Day Free Trial