[Webinar] Learn how to a build a cloud-first strategyRegister Now

x
  • Status: Solved
  • Priority: Medium
  • Security: Public
  • Views: 1100
  • Last Modified:

Excel userform vba code to edit and delete

I have a table of absences which is populated through a userform, I would like to be able to add command buttons or toggles to the userform to be able to search the records and edit or delete them. I have attached the file, the form I am working on is called frmabsences which adds records to absence table.

I am new to vb coding. any help appreciated. All details in the attached spreadsheet are fictitious for the purpose of developing the spreadsheet
TestMAMF2.xlsm
0
rowlandwiliams
Asked:
rowlandwiliams
  • 10
  • 9
1 Solution
 
Martin LissRetired ProgrammerCommented:
I assume you want to edit and delete items on the Mamf sheet. Which columns on that sheet do you want to be able to edit?
0
 
rowlandwiliamsAuthor Commented:
Hi Martin,

I want to able to edit columns C, D & E on the Absences sheet. I would like to be able to delete individual records on the same sheet/
0
 
rowlandwiliamsAuthor Commented:
Just to clarify the delete bit, I would delete an entire row
0
What does it mean to be "Always On"?

Is your cloud always on? With an Always On cloud you won't have to worry about downtime for maintenance or software application code updates, ensuring that your bottom line isn't affected.

 
Martin LissRetired ProgrammerCommented:
OK, here's the delete code. Add a button to frmAbsences named cmdDelete and add this code. I'll be back in a few minutes with the edit code.

Private Sub cmdDelete_Click()

    Dim lngLastRow As Long
    Dim lngRow As Long
    
    lngLastRow = Range("B1048576").End(xlUp).Row
    
    If cmbStaffName = "" Then
        MsgBox "Please select a Staff Name to be deleted"
        Exit Sub
    End If
    
    If vbYes = MsgBox("Are you sure you want to delete staff member " & cmbStaffName.Text & "?", vbYesNo) Then
        For lngRow = 4 To lngLastRow
            If Cells(lngRow, "B") = cmbStaffName Then
                Cells(lngRow, "B").EntireRow.Delete
            End If
        Next
    End If
    
End Sub

Open in new window

0
 
rowlandwiliamsAuthor Commented:
Hi Martin,

The delete code is great thank you, however it deletes any random record with that staff name. There are several records for some staff names, I would like to be able to choose which record to delete.
I have put a list box on the userform,  could I choose which record from the list box? Or scroll through the records in the form to choose the one to delete?
0
 
Martin LissRetired ProgrammerCommented:
OK, I thought you meant that you wanted to delete, say, row 12 from the Mamf sheet. Where do the records reside that you want to delete?
0
 
rowlandwiliamsAuthor Commented:
The records are on the absences worksheet. There is a table on there called absences which the frmabsences adds records to.
0
 
Martin LissRetired ProgrammerCommented:
OK, so let me double-check. You want to select an entry in Listbox1 on frmAbsence and then either delete that entry from both the list and the Absences sheet or edit that Absences entry on the sheet. Correct?
0
 
rowlandwiliamsAuthor Commented:
That would be perfect
0
 
Martin LissRetired ProgrammerCommented:
One more question. You say you want column "C" to be editable. Are there rules to what it can be changed to?
0
 
rowlandwiliamsAuthor Commented:
Hi Martin,

Column C is a combobox of Names selected from a Staff List Table -  StaffList[Name] It should be a name in that list.

Columns D & E are dates, I use the frmabsences to enter the dates using a text box and the cdate vba

I hope this all makes sense
0
 
Martin LissRetired ProgrammerCommented:
OK, cooking dinner. Will try to finish this later tonight.
1
 
Roy CoxGroup Finance ManagerCommented:
Take a look at my DataBaseForm available free here. It has been downloaded 1000s of times and has many features for working with Excel Databases.

Free DataBaseForm

Take a look and post back if you want help adapting it.
0
 
Martin LissRetired ProgrammerCommented:
Here's a workbook that allows you to edit and delete entries from the Absences sheet. There is a problem however and that is that deleting records causes problems with your existing formulas.
28967563.xlsm
0
 
rowlandwiliamsAuthor Commented:
Hi Martin,

Thank you for all the work you've put into this. It is exactly what I'm looking for. When I edit records it doesn't appear to change the right record.

There is an entry for example 5 rows down called Ann Green, I've tried changing the end date and it changes a different record leaving Ann Green record unchanged.

I have a look through the code but I cant really establish what is causing this.
0
 
Martin LissRetired ProgrammerCommented:
I'll be back in a couple of hours and I'll look at it then.
1
 
Martin LissRetired ProgrammerCommented:
Replace the cmdOK_Click sub on frmEdit with this.

Private Sub cmdOK_Click()
Dim lngRowToUpdate As Long

With Sheets("Absences")
    lngRowToUpdate = frmAbsences.ListBox1.ListIndex + 4
    If vbYes = MsgBox("Are you sure you want to update the absence for " _
          & .Cells(lngRowToUpdate, "C") _
          & " for the period " & .Cells(lngRowToUpdate, "D") & " to " _
          & .Cells(lngRowToUpdate, "E"), vbYesNo) Then
        .Cells(lngRowToUpdate, "C") = cboName.Text
        .Cells(lngRowToUpdate, "D") = txtFirst.Text
        .Cells(lngRowToUpdate, "E") = txtLast.Text
    End If
End With

Unload Me

End Sub

Open in new window

BTW I noticed that the code for adding an absence allows the end date to be before the start date. Also if it were my workbook I wouldn't blank out the date when an invalid date is added. IMO it's better to just highlight it. That way the user can see whet he typed in and not think "dumb program, I know I entered a good date".
0
 
rowlandwiliamsAuthor Commented:
Thanks Martin,

That is absolutely perfect. Thank you so much for all your the time and quick responses :-)
0
 
rowlandwiliamsAuthor Commented:
Thank you Martin, that has solved all of the problems and the form is working perfectly - Thank you again.
0
 
Martin LissRetired ProgrammerCommented:
You're welcome and I'm glad I was able to help.

In my profile you'll find links to some articles I've written that may interest you.

Marty - Microsoft MVP 2009 to 2016
              Experts Exchange MVE 2015
              Experts Exchange Top Expert Visual Basic Classic 2012 to 2015
0

Featured Post

Free Tool: SSL Checker

Scans your site and returns information about your SSL implementation and certificate. Helpful for debugging and validating your SSL configuration.

One of a set of tools we are providing to everyone as a way of saying thank you for being a part of the community.

  • 10
  • 9
Tackle projects and never again get stuck behind a technical roadblock.
Join Now