php inclusion acting differntly between 2 pages.

breeze351
breeze351 used Ask the Experts™
on
I created a small inclusion to do the query write/update.  It works in page 1, but when I added the code to page 2, it displays the remarks, all the code and does not perform the update.

I've attached the relevant code for the two pages as well as the inclusion.
page1.php
page2.php
IO_inc.php
Comment
Watch Question

Do more with

Expert Office
EXPERT OFFICE® is a registered trademark of EXPERTS EXCHANGE®
Marco GasiFreelancer
Top Expert 2010

Commented:
It looks like page 2 is not recognized as a php script: is there the php opening tag? In code you posted here that is missing in all files...
Most Valuable Expert 2011
Top Expert 2016

Commented:
Agree with Marco.  Please add <?php error_reporting(E_ALL); as the top line of all three scripts, and try it again.  Please let us know if you get different output, or if you get messages that might be associated with these scripts.

Author

Commented:
The <?php is at the top of both pages.
I added error_reporting(E_ALL) to the top of page 2.
Got the same results with the display of comments and code.

Just for the halibut, I added <?php ..... ?> to the inclusion.  It processes the code as expected (update worked), however I got the following error message:

Warning: Cannot modify header information - headers already sent by (output started at /home/mrbreez1/public_html/IO_inc.php:25) in /home/mrbreez1/public_html/Update_Tenant.php on line 268

I know what the error means, but the only thing that would cause this is echo statement in the inclusion that isn't executed.
OWASP: Forgery and Phishing

Learn the techniques to avoid forgery and phishing attacks and the types of attacks an application or network may face.

Most Valuable Expert 2017
Distinguished Expert 2018
Commented:
Try removing the closing ?> on the io_inc.php page

The error is saying that some output was sent. This could be a space that comes after the closing ?>

If the page is all PHP code you can omit the closing ?> which prevents any empty spaces at the end of the script being interpreted as output to the browser
i.e
<?php
// **************************************************************
// * IO_inc.php                                                 *
// * Inclusion to preform SQL I/O with error checking.          *
// **************************************************************
// * Version 4.0                                                *
// **************************************************************
// * Modifications:                                             *
// * Ver   By     Date       Description                        *
// * 4.0   GJJD   09/06/16   Created                            *
// *                                                            *
// ************************************************************** 
	$io = $conn->query($SqlString);			
	if (!$io)
	{
		$io_error = "Query Failed: "
		. $SqlString
		. ' ERRNO: '
		. $conn->errno
		. ' ERROR: '
		. $conn->error
		;
		echo $io_error."<br>";
	}

Open in new window

Most Valuable Expert 2011
Top Expert 2016
Commented:
Unless it's absolutely necessary, you never want to use the close-PHP tag.  It creates more problems than it's worth.

"Cannot modify header..." is covered here (check the part about output buffering):
https://www.experts-exchange.com/articles/4423/Warning-Cannot-modify-header-information-headers-already-sent.html

It sounds like the issue might be something in the context or scope of the scripts.  I don't think we have enough information here to debug it (without a lucky guess), so if you can tell us a little more about how these scripts get called, or better yet create the SSCCE that we can install and run on our own servers, that would be very helpful.

Author

Commented:
I removed the ?> and it worked.  I don't care right now because it does work, but why would it work on page1 and not page2!
Most Valuable Expert 2017
Distinguished Expert 2018

Commented:
Without access to the raw files cannot say. The files you posted seemed sanitized - there were no script tags so assuming they are not strictly the same as the live ones.

Do more with

Expert Office
Submit tech questions to Ask the Experts™ at any time to receive solutions, advice, and new ideas from leading industry professionals.

Start 7-Day Free Trial