count8 challlenge

Hi,
I am working on below challenge

http://codingbat.com/prob/p192383

Given a non-negative int n, compute recursively (no loops) the count of the occurrences of 8 as a digit, except that an 8 with another 8 immediately to its left counts double, so 8818 yields 4. Note that mod (%) by 10 yields the rightmost digit (126 % 10 is 6), while divide (/) by 10 removes the rightmost digit (126 / 10 is 12).

count8(8) → 1
count8(818) → 2
count8(8818) → 4

i am not clear on how to find eight count using recursion. please advise
LVL 7
gudii9Asked:
Who is Participating?
 
rrzConnect With a Mentor Commented:
 if ((n+1 % 10) == 8)

Open in new window

That is not what you want to do. That tests whether the present input + 1 has a 8 as its last digit. You want to use n/10 to peek at the input that will follow the present one.
0
 
Pawan KumarConnect With a Mentor Database ExpertCommented:
--
----

DECLARE @intValue AS VARCHAR(10) = '8818'
 
SELECT SUM( CASE WHEN SUBSTRING(@intValue,number,1) LIKE '[8]' THEN 1 ELSE 0 END ) Count8DIGITS FROM
( 
  SELECT DISTINCT number FROM
  MASTER..SPT_VALUES WHERE number > 0 AND number <= DATALENGTH(@intValue) 
) x

--
--

Open in new window

0
 
rrzCommented:
This challenge is almost the same as  
https://www.experts-exchange.com/questions/28968896/count7-challenge.html 
There is just an extra conditional here.
0
What Kind of Coding Program is Right for You?

There are many ways to learn to code these days. From coding bootcamps like Flatiron School to online courses to totally free beginner resources. The best way to learn to code depends on many factors, but the most important one is you. See what course is best for you.

 
gudii9Author Commented:
I will try
0
 
gudii9Author Commented:
public int count8(int n) {
  if (n < 1) {
    return 0;
  }
  if ((n % 10) == 8){ return 1 + count8(n/10);
  }
  else {
  return count8(n/10);
  }
}

Open in new window


above failing some tests
Expected      Run            
count8(8) → 1      1      OK      
count8(818) → 2      2      OK      
count8(8818) → 4      3      X      
count8(8088) → 4      3      X      
count8(123) → 0      0      OK      
count8(81238) → 2      2      OK      
count8(88788) → 6      4      X      
count8(8234) → 1      1      OK      
count8(2348) → 1      1      OK      
count8(23884) → 3      2      X      
count8(0) → 0      0      OK      
count8(1818188) → 5      4      X      
count8(8818181) → 5      4      X      
count8(1080) → 1      1      OK      
count8(188) → 3      2      X      
count8(88888) → 9      5      X      
count8(9898) → 2      2      OK      
count8(78) → 1      1      OK      
other tests
X      

This challenge is almost the same as  
https://www.experts-exchange.com/questions/28968896/count7-challenge.html 
There is just an extra conditional here.

what is extra conditional compared to count7 challenge here for count8 challenge?
0
 
rrzCommented:
what is extra conditional
The challenge stated
except that an 8 with another 8 immediately to its left counts double
So, we need something like
    if(n % 10 == 8){
		if(next digit is 8)return 2 + count8(n / 10);
		else return 1 + count8(n / 10);
    }

Open in new window

0
 
Pawan KumarDatabase ExpertCommented:
Enjoy ! Without Recursion and loop;

--

DECLARE @intValue AS VARCHAR(10) = '1818E8'
 
SELECT SUM( CASE WHEN SUBSTRING(@intValue,number,1) LIKE '[8]' THEN 1 ELSE 0 END ) Count8DIGITS FROM
(
  SELECT DISTINCT number FROM
  MASTER..SPT_VALUES WHERE number > 0 AND number <= DATALENGTH(@intValue)
) x

--
0
 
gudii9Author Commented:
public int count8(int n) {
  int result=0;
  if (n < 1) {
     result=0;
  }
  if ((n % 10) == 8){
    if ((n+1 % 10) == 8){
      result= 2 + count8(n/10);
     // return result;
    }
   else{ 
     result= 1 + count8(n/10);
    // return result;
  }
  }
  return result;
}
 /* else {
  return count8(n/10);
  }*/
   /* if(n % 10 == 8){
		if(next digit is 8)return 2 + count8(n / 10);
		else return 1 + count8(n / 10);*/
    

Open in new window



above fails below tests

Expected      Run            
count8(8) → 1      1      OK      
count8(818) → 2      1      X      
count8(8818) → 4      1      X      
count8(8088) → 4      2      X      
count8(123) → 0      0      OK      
count8(81238) → 2      1      X      
count8(88788) → 6      2      X      
count8(8234) → 1      0      X      
count8(2348) → 1      1      OK      
count8(23884) → 3      0      X      
count8(0) → 0      0      OK      
count8(1818188) → 5      2      X      
count8(8818181) → 5      0      X      
count8(1080) → 1      0      X      
count8(188) → 3      2      X      
count8(88888) → 9      5      X      
count8(9898) → 2      1      X      
count8(78) → 1      1      OK      
other tests
X      

please advise
0
 
gudii9Author Commented:
public int count8(int n) {
  int result=0;
  if (n < 1) {
     result=0;
  }
  if ((n % 10) == 8){
    if ((n/10) == 8){
      result= 2 + count8(n/10);
     // return result;
    }
   else{ 
     result= 1 + count8(n/10);
    // return result;
  }
  }
  return result;
}
 /* else {
  return count8(n/10);
  }*/
   /* if(n % 10 == 8){
		if(next digit is 8)return 2 + count8(n / 10);
		else return 1 + count8(n / 10);*/
    /*That is not what you want to do. That tests whether the present input + 1
    has a 8 as its last digit.
    You want to use n/10 to peek at the input that will follow the present one.*/

Open in new window

like above?it still fails same tests?
0
 
gudii9Author Commented:
I think i got approach.
public int count8(int n) {
  //int result=0;
  if (n < 1) {
     return 0;
  }
  if (n >=88 && n%100==88){
   
      return 2 + count8(n/10);
     // return result;
    }
    else if( n%10==8){
    // result= 1 + count8(n/10);
    // return result;
    return 1 + count8(n/10);
  }
  return count8(n/10);
  
 // return result;
}
 /* else {
  return count8(n/10);
  }*/
   /* if(n % 10 == 8){
		if(next digit is 8)return 2 + count8(n / 10);
		else return 1 + count8(n / 10);*/
    /*That is not what you want to do. That tests whether the present input + 1
    has a 8 as its last digit.
    You want to use n/10 to peek at the input that will follow the present one.*/

Open in new window


above passed all tests. any improvements or alternate approaches?
0
 
gudii9Author Commented:
if then if then else
in above fashion code is there else belong to top if or second(last if in this case)?
0
 
rrzCommented:
  if (n >=88 && n%100==88){

Open in new window

That doesn't look right.
Here is my solution.  
public int count8(int n) {
      if(n == 0)return 0;
    if(n % 10 == 8){
		if((n / 10) % 10 == 8)return 2 + count8(n / 10);
		else return 1 + count8(n / 10);
    }
    else return count8(n / 10);
}

Open in new window

0
 
gudii9Author Commented:
public int count8(int n) {
      if(n == 0)return 0;
    if(n % 10 == 8){
		if((n / 10) % 10 == 8)return 2 + count8(n / 10);
		else return 1 + count8(n / 10);
    }
    else return count8(n / 10);
}

Open in new window

i like this approach
0
Question has a verified solution.

Are you are experiencing a similar issue? Get a personalized answer when you ask a related question.

Have a better answer? Share it in a comment.

All Courses

From novice to tech pro — start learning today.