Pass Parameters from a Date Range Form to a Report

As you have already indicated, you already refer to those controls in your reports RecordSource.  I generally don't do it this way, perferring to use the OpenReport methods WhereCriteria argument so that I don't have to have the form open when I run the report in design view.  To do it this way,  You would remove those values from the query that is the reports recordsource and build a criteria string before opening the report, somehing like:

Private Sub cmdReport_Click

    dim strCriteria as string

    strCriteria = "([DateFieldName] >= #" & me.txtFromDate & "#) AND " _
                       & "([DateFieldName] < #" & cdate(me.txtThruDate) + 1 & "#)"
    docmd.openreport "ReportName", acViewPreview, , strCriteria

End Sub

Select all Open in new window

But if you want to do it with the form and the references to the form in your query, then you need to either:

2.  Declare those form controls as parameters in your query.  You can do this by inserting a parameter declaration statement at the top of the queries SQL, like:

PARAMETERS [Forms]![MyForm]![txtDateFrom] DateTime, [Forms]![myForm]![txtDateTo] DateTime;
SELECT * FROM yourTable
WHERE [DateFieldName] >= [Forms]![MyForm]![txtDateFrom]
AND [DateFieldName] < [Forms]![MyForm]![txtDateFrom] + 1

3.  Another way to process this is to use the Eval function to force Access to evaluate the references to the form:

SELECT * FROM yourTable
WHERE [DateFieldName] >= Eval([Forms]![MyForm]![txtDateFrom])
AND [DateFieldName] < Eval([Forms]![MyForm]![txtDateFrom]) + 1)

When Iwant to use a form like that for multiple reports, I use the Report_Open event to open the form in acDialog mode.  Then, instead of having a cmd_Report button on the form to I put two buttons on the form, cmdCancel and cmdContinue.  In both cases I set the forms Tag property to either "Cancel" or "Continue", then hide the form.

Hiding the form returns control to the Report_Open event which then checks the Tag property of the form to determine whether it is Cancel.  If so, then I set the Cancel argument of the Form object to True and exit the subroutine (which closes the report).  If the Tag property was "Continue", I check to see whether txtDateFrom and txtDateTo contain values and construct a criteria string which I then apply to the forms Filter property.  This way, you can reuse that form for multiple reports and force the form to open whenever any of those reports are called.