Solved

return array from dll

Posted on 2016-09-15
13
35 Views
Last Modified: 2016-09-15
hi.
I created dll that have to output an array from one of functions.
In program for dll no errors shows, but when I try to use the function in another program then it is impossible.
Here the code in dll:
  public static ushort GetSamplTrace(int m=16)
        {
            var arr = Array<ushort>.Empty(16)
            int pos;
            using (BinaryReader b = new BinaryReader(File.Open(dataPath, FileMode.Open)))
            {
                   pos = 29;
                    b.BaseStream.Seek(pos, SeekOrigin.Begin);
                    byte[] by = b.ReadBytes(2);
                    arr[0] = BitConverter.ToUInt16(by, 0);
                    for (int i=1;i<16;i++)
                    {
                        arr[i] = 0;
                    }

                return arr[16];
            }

        }

Here I try to use it:
                var arr = Array<ushort>.Empty(16);
                arr[16] =MyDll.fun.GetSamplTrace();
0
Comment
Question by:mastiSoft
  • 5
  • 4
  • 3
  • +1
13 Comments
 
LVL 44

Expert Comment

by:AndyAinscow
ID: 41799542
>> it is impossible.

Why?  What error message?


ps.  You return a ushort from the function but you talk of returning an array (NOT the same thing) in the question.
0
 
LVL 1

Author Comment

by:mastiSoft
ID: 41799555
first problem was pointed to dll. return arr[16]
it seams that I try to return value from index 16 (it not exist because the size of array 16)
I changed code lite:
  public static ushort GetSamplTrace(string path, int size)
        {
            var arr = Array<ushort>.Empty(size);
            int pos;
            using (BinaryReader b = new BinaryReader(File.Open(dataPath, FileMode.Open)))
            {
           
                    pos = 29;
                    b.BaseStream.Seek(pos, SeekOrigin.Begin);
                    byte[] by = b.ReadBytes(2);
                    arr[0] = BitConverter.ToUInt16(by, 0);
                    for (int y=1;y<size;i++)
                    {
                        arr[y] = 0;
                    }

                    return arr[16];
            }

        }
No error but I know it will not work. How to return an array not only the one item from it?

Then when  I call the array from dll in another program how to do that?
0
 
LVL 1

Author Comment

by:mastiSoft
ID: 41799557
if I try:   return arr;
then the error : cannot implicitly convert ushort[] to ushort.
0
 
LVL 33

Expert Comment

by:sarabande
ID: 41799595
if I try:   return arr;
the return type must be ushort[].

Sara
0
 
LVL 44

Expert Comment

by:AndyAinscow
ID: 41799600
When you declare the function you declare what it will return, in this case you tell the compiler it will return a ushort.
public static ushort GetSamplTrace(string path, int size)

If you want to return an array you need to say so, try
public static Array<ushort> GetSamplTrace(string path, int size)
and then use return arr when the function is finished in the implementation.


ps.  Don't forget that arrays are zero based so an array with two members has, as valid, indexes of 0 and 1
0
 
LVL 62

Accepted Solution

by:
Fernando Soto earned 500 total points
ID: 41799606
Hi mastiSoft;

Change the signature of the function and variable in the function to this.
 public static ushort[] GetSamplTrace ( int m = 16 ) {
            ushort[] arr = new ushort[16];

Open in new window

0
Is Your Active Directory as Secure as You Think?

More than 75% of all records are compromised because of the loss or theft of a privileged credential. Experts have been exploring Active Directory infrastructure to identify key threats and establish best practices for keeping data safe. Attend this month’s webinar to learn more.

 
LVL 1

Author Comment

by:mastiSoft
ID: 41799635
To Andy:
now I have 2 errors not one as before
1. static types cannot be used as return type ( public static Array<ushort>GetSamplTrace(string path, int size)
2. cannot implicitly convert ushort[] to ushort. ( return arr)
0
 
LVL 1

Author Closing Comment

by:mastiSoft
ID: 41799644
simple and beautiful solution
0
 
LVL 44

Expert Comment

by:AndyAinscow
ID: 41799671
Hmmm.
I suggested using Array<ushort> as the return because you had said your function compiled OK.
Trying it here the compiler objects to
          var arr = Array<ushort>.Empty(size);

so you would have to do as Sara first suggested and use ushort[] as the return type.
0
 
LVL 62

Expert Comment

by:Fernando Soto
ID: 41799985
@Andy Array's are not generic types and you would get an error like this, " The non-generic type 'Array' cannot be used with type arguments".
0
 
LVL 44

Expert Comment

by:AndyAinscow
ID: 41800007
I can't always remember small details - I trusted the asker when they said their code compiled despite using that construct.  :-(
0
 
LVL 62

Expert Comment

by:Fernando Soto
ID: 41800018
Its OK Andy we all fall into that as well.
0
 
LVL 44

Expert Comment

by:AndyAinscow
ID: 41800041
It didn't help that I would not use a collection class anyway for an array of a basic type.  Too much overhead for when a simple classical array would suffice, but it would have meant rather less changes to the code for the asker and, who knows, maybe they did require the functionality of a collection.
0

Featured Post

Is Your Active Directory as Secure as You Think?

More than 75% of all records are compromised because of the loss or theft of a privileged credential. Experts have been exploring Active Directory infrastructure to identify key threats and establish best practices for keeping data safe. Attend this month’s webinar to learn more.

Question has a verified solution.

If you are experiencing a similar issue, please ask a related question

Suggested Solutions

Title # Comments Views Activity
c# if statement weird reaction 3 42
install app on other machine 13 32
IO.FileSystemWatcher dies when used in Powershell 1 44
Visual Studio 2013 debugging 2 35
Extention Methods in C# 3.0 by Ivo Stoykov C# 3.0 offers extension methods. They allow extending existing classes without changing the class's source code or relying on inheritance. These are static methods invoked as instance method. This…
Performance in games development is paramount: every microsecond counts to be able to do everything in less than 33ms (aiming at 16ms). C# foreach statement is one of the worst performance killers, and here I explain why.
When you create an app prototype with Adobe XD, you can insert system screens -- sharing or Control Center, for example -- with just a few clicks. This video shows you how. You can take the full course on Experts Exchange at http://bit.ly/XDcourse.
Need to grow your business through quality cloud solutions? With everything required to build a cloud platform and solution, you may feel like the distance between you and the cloud is quite long. Help is here. Spend some time learning about the Con…

932 members asked questions and received personalized solutions in the past 7 days.

Join the community of 500,000 technology professionals and ask your questions.

Join & Ask a Question

Need Help in Real-Time?

Connect with top rated Experts

8 Experts available now in Live!

Get 1:1 Help Now