Solved

changePi Challenge

Posted on 2016-09-15
15
127 Views
Last Modified: 2016-09-20
Hi,

I am working on below challenge
http://codingbat.com/prob/p170924

Psedo code:

1. if array length is zero return ""
2. if array length is 1  return same str
3. else find location of pi and replace with 3.14 if greater than length
4. return replaced string

I wrote my code as below

public String changePi(String str) {
   if(str.length()==0){
    return "";
  }
  if(str.length()==1){
    return str;
  }
  if(str.length()==2&&"pi".equals(str)){
    return "3.14";
  }
   if(str.length()==1&&!"x".equals(str)){
    return str;
  }
   if(str.length()>1){
    return str.replace("pi","3.14");
  }
  
  
  return null;
}

Open in new window




I am passing all tests

How to improve/modify my design, code and any other alternate approaches. please advise
0
Comment
Question by:gudii9
  • 4
  • 3
  • 3
  • +1
15 Comments
 
LVL 32

Expert Comment

by:phoffric
ID: 41799990
>> Given a string, compute recursively (no loops) a new string where all appearances of "pi" have been replaced by "3.14".

The instructions say you have to do this challenge recursively.
What would happen if you modified your code to just call replace without all those if statements?
0
 
LVL 27

Expert Comment

by:rrz
ID: 41800191
0
 
LVL 32

Expert Comment

by:phoffric
ID: 41800271
>> No recursion is necessary for this challenge.
You are already stating what the author has observed.
But the challenge is to learn how to use recursion.
0
Master Your Team's Linux and Cloud Stack

Come see why top tech companies like Mailchimp and Media Temple use Linux Academy to build their employee training programs.

 

Expert Comment

by:Filonowst
ID: 41800312
phoffric,
I respect the fact that you did not find my answer acceptable. I feel the best way to learn recursion is to step through an example. To try to explain this one without the code would be more difficult for both the explainer and the explainee. This is a fairly basic recursion question and there are many online tutorials as to how recursion works. So I guess my answer turns into: lookup some basic recursion tutorials.

OP,
The question specifically asks for a recursive solution which your code is not.
0
 

Expert Comment

by:Filonowst
ID: 41800313
Sorry for the confusion but I just changed my profile name from IT Manager.
0
 
LVL 27

Expert Comment

by:rrz
ID: 41800347
@phoffric,  gudii9 has already gone through 11 recursion challenges last week.  He will not learn anything by using recursion when it is not useful.  He really needs to learn the API better.
0
 
LVL 32

Expert Comment

by:phoffric
ID: 41800369
@rrz,
>> He will not learn anything by using recursion when it is not useful.  He really needs to learn the API better.

Of course, learning the API is critical to becoming a successful professional. You are welcome to advise the author for this generality.

However, the author is choosing which challenges to participate in. If this question were on a college test, then he would get zero credit for the posted solution. It is up to the author to begin to realize why he got the right answer without using recursion (and that will be useful to him), and then proceed, if he wants, to come up with a recursive solution as required by the challenge.
0
 
LVL 27

Expert Comment

by:rrz
ID: 41801649
I'm sorry. I was wrong.   Your choice of the replace method is fine.
0
 
LVL 7

Author Comment

by:gudii9
ID: 41804074
public String changePi(String str) {

    if (str.length() == 0){ 
      return str;
      
    }
   else if (str.substring(0,2) == "pi") {
     return "3.14" + changePi(str.substring(2));
     
   }
   else{ 
     return str.substring(0,2) + changePi(str.substring(2));
     
   }
}
  
  
 

Open in new window

Expected      Run            
changePi("xpix") → "x3.14x"      "xpix"      X      
changePi("pipi") → "3.143.14"      "pipi"      X      
changePi("pip") → "3.14p"      Exception:java.lang.StringIndexOutOfBoundsException: String index out of range: 2 (line number:7)      X      
changePi("pi") → "3.14"      "3.14"      OK      
changePi("hip") → "hip"      Exception:java.lang.StringIndexOutOfBoundsException: String index out of range: 2 (line number:7)      X      
changePi("p") → "p"      Exception:java.lang.StringIndexOutOfBoundsException: String index out of range: 2 (line number:7)      X      
changePi("x") → "x"      Exception:java.lang.StringIndexOutOfBoundsException: String index out of range: 2 (line number:7)      X      
changePi("") → ""      ""      OK      
changePi("pixx") → "3.14xx"      "pixx"      X      
changePi("xyzzy") → "xyzzy"      Exception:java.lang.StringIndexOutOfBoundsException: String index out of range: 2 (line number:7)      X      
other tests
X

wrote as above and failing some tests.

please advise
0
 
LVL 7

Author Comment

by:gudii9
ID: 41804112
public String changePi(String str) {

    if (str.length()==0||str.length()<2){ 
      return str;
      
    }
   else if (str.substring(0,2) == "pi") {
     return "3.14" + changePi(str.substring(2));
     
   }
   else{ 
     return str.charAt(0) + changePi(str.substring(1));
     
   }
}
  
  
 
 

Open in new window


above passes more tests but still fails some. please advise
Expected      Run            
changePi("xpix") → "x3.14x"      "xpix"      X      
changePi("pipi") → "3.143.14"      "pipi"      X      
changePi("pip") → "3.14p"      "pip"      X      
changePi("pi") → "3.14"      "3.14"      OK      
changePi("hip") → "hip"      "hip"      OK      
changePi("p") → "p"      "p"      OK      
changePi("x") → "x"      "x"      OK      
changePi("") → ""      ""      OK      
changePi("pixx") → "3.14xx"      "pixx"      X      
changePi("xyzzy") → "xyzzy"      "xyzzy"      OK      
other tests
X      
0
 
LVL 27

Accepted Solution

by:
rrz earned 500 total points
ID: 41804125
You are almost there. You just forgot not to use == for comparing String content. Please use the String method.
0
 
LVL 7

Author Comment

by:gudii9
ID: 41807401
public String changePi(String str) {

    if (str.length()==0||str.length()<2){ 
      return str;
      
    }
   else if (str.substring(0,2).equals("pi")) {
     return "3.14" + changePi(str.substring(2));
     
   }
   else{ 
     return str.charAt(0) + changePi(str.substring(1));
     
   }
}
  
  
 
 A
/* public String changePi(String str) {
  if (str.equals("") || str.length() < 2) return str;
  if (str.charAt(0) == 'p' && str.charAt(1) == 'i') 
    return "3.14" + changePi(str.substring(2));
  return str.charAt(0) + changePi(str.substring(1));
}*/

Open in new window

passed all
0

Featured Post

3 Use Cases for Connected Systems

Our Dev teams are like yours. They’re continually cranking out code for new features/bugs fixes, testing, deploying, testing some more, responding to production monitoring events and more. It’s complex. So, we thought you’d like to see what’s working for us.

Question has a verified solution.

If you are experiencing a similar issue, please ask a related question

Suggested Solutions

Title # Comments Views Activity
Advice on Xojo as a development tool over VB. 4 55
tomcat not starting 6 45
Eclipse with gitlab 1 41
going to wrong jsp page 2 20
Displaying an arrayList in a listView using the default adapter is rarely the best solution. To get full control of your display data, and to be able to refresh it after editing, requires the use of a custom adapter.
This is about my first experience with programming Arduino.
Viewers will learn about if statements in Java and their use The if statement: The condition required to create an if statement: Variations of if statements: An example using if statements:
This tutorial covers a step-by-step guide to install VisualVM launcher in eclipse.

770 members asked questions and received personalized solutions in the past 7 days.

Join the community of 500,000 technology professionals and ask your questions.

Join & Ask a Question