[Last Call] Learn how to a build a cloud-first strategyRegister Now

x
  • Status: Solved
  • Priority: Medium
  • Security: Public
  • Views: 80
  • Last Modified:

Excel calculation using VBA

I want to add two cells based on the text in two other cells.  

I have this now that works in the VBA editor.  

Function CalcQtys()
Dim intPrev, intNew
Dim strType, strLocation

intPrev = Range("C4").Value
intNew = Range("F3").Value

strType = Range("L3").Value
strLocation = Range("N3").Value

If (strType = "Adj-In") And (strLocation = "Transfer from Final Inspect") Then
    CalcQtys = intPrev + intNew
End If

End Function

In the spreadsheet cell formula I have this: = CalcQtys().
But the cell displays #VALUE!.

This will end up a multi-level if else-if statement.  I'm new at Excel ...

Thanks,
Brooks
0
gbnorton
Asked:
gbnorton
  • 4
  • 3
  • 2
  • +1
1 Solution
 
Roy CoxGroup Finance ManagerCommented:
Why use VBA for calculations? Excel's inbuilt calculations will be more efficient than coding.

Provide an example workbook
0
 
Subodh Tiwari (Neeraj)Excel & VBA ExpertCommented:
The function you posted should work without an issue though it doesn't seems to be useful as this can be achieved with simple IF formula on the sheet.
What's your intention behind this? What are you trying to achieve?
Also what do you mean by multiple If else statement here, how would you incorporate them in the function.
I guess you need a sub-routine rather than a Function.
Better upload a sample workbook with some dummy data and lets know the steps you are trying to automate.
0
 
Martin LissRetired ProgrammerCommented:
If you want to improve what you have then change it to this.

'  Without the "As Integer", the function returns a Variant, which will work
'  but Variants are larger and slower than any other type of variable.
Function CalcQtys() As Integer

' Unless you explicitly declare a type, the variables are Variants
' as described above.
Dim intPrev As Integer, intNew As Integer
Dim strType As String, strLocation As String

intPrev = Range("C4").Value
intNew = Range("F3").Value

strType = Range("L3").Value
strLocation = Range("N3").Value

If (strType = "Adj-In") And (strLocation = "Transfer from Final Inspect") Then
    CalcQtys = intPrev + intNew
End If

' You don't really need any of your variables. Instead of the above you could do 
' the following instead of lines 5 through 18
If (Range("L3").Value = "Adj-In") And (Range("N3").Value = "Transfer from Final Inspect") Then
    CalcQtys =  Range("C4").Value + Range("F3").Value
End If

End Function

Open in new window

0
Concerto Cloud for Software Providers & ISVs

Can Concerto Cloud Services help you focus on evolving your application offerings, while delivering the best cloud experience to your customers? From DevOps to revenue models and customer support, the answer is yes!

Learn how Concerto can help you.

 
Roy CoxGroup Finance ManagerCommented:
I still cannot see the advantage of VBA here, especially as the ranges are hard coded.
0
 
Martin LissRetired ProgrammerCommented:
I still cannot see the advantage of VBA here, especially as the ranges are hard coded.
I agree (unless there's more to it) and I was just trying point out a few coding improvements.
0
 
Roy CoxGroup Finance ManagerCommented:
martin, I'm not faulting your code, I just think it is totally unnecessary. So many people seem to think VBA is the answer to all problems.
0
 
gbnortonAuthor Commented:
Thanks for your comments.  At this point, I'm just trying to get some VBA to work.  I've seen that VBA is not the way to go in this case.  I just want to learn how to use it.  The example is uploaded.  The function is in cell C3.  My goal is to add F3 and C4 and display the result in C3.
Thanks,
Brooks
Excel-vba.xlsm
0
 
Subodh Tiwari (Neeraj)Excel & VBA ExpertCommented:
It seems that you need the formulas for C3, C5 and C7 based on the conditions for columns L and N. Right?
So as per your description if C3 = F3 + C4, what formula do you want for C5 and C7 then?
0
 
Martin LissRetired ProgrammerCommented:
Function CalcQtys() As Integer
Dim lngCurRow As Long
lngCurRow = Application.Caller.Row
If (Range("L" & lngCurRow).Value = "Adj-In") And (Range("N" & lngCurRow).Value = "Transfer from Final Inspect") Then
    CalcQtys = Range("C" & lngCurRow + 1).Value + Range("F" & lngCurRow).Value
End If
End Function

Open in new window

0
 
Roy CoxGroup Finance ManagerCommented:
The OP insists that he wants VBA so Martin's final Function does as asked.
0

Featured Post

Concerto's Cloud Advisory Services

Want to avoid the missteps to gaining all the benefits of the cloud? Learn more about the different assessment options from our Cloud Advisory team.

  • 4
  • 3
  • 2
  • +1
Tackle projects and never again get stuck behind a technical roadblock.
Join Now