gudii9
asked on
array11 challenge
Hi,
I am working on below challenge.
http://codingbat.com/prob/p135988
Psedo code:
1. create new array of the portion of original array length
2. check to see if if given index has 1 and next index also has 1iif yes return increment count by 1
3.else repeat recursion
I wrote my code as below
i am failing some tests
please advise
I am working on below challenge.
http://codingbat.com/prob/p135988
Psedo code:
1. create new array of the portion of original array length
2. check to see if if given index has 1 and next index also has 1iif yes return increment count by 1
3.else repeat recursion
I wrote my code as below
public int array11(int[] nums, int index) {
int count=0;
if(nums.length==0){
return 0;
}
/* if(index>=nums.length){
return 0;
}*/
if(index>=nums.length){
return 0;
}
else if((nums[index]==1)&&nums[index+1]==11){
return count++;
}
else return array11(nums,index+1);
}
i am failing some tests
Expected Run
array11([1, 2, 11], 0) → 1 0 X
array11([11, 11], 0) → 2 0 X
array11([1, 2, 3, 4], 0) → 0 0 OK
array11([1, 11, 3, 11, 11], 0) → 3 0 X
array11([11], 0) → 1 0 X
array11([1], 0) → 0 Exception:java.lang.ArrayIndexOutOfB oundsExcep tion: 1 (line number:14) X
array11([], 0) → 0 0 OK
array11([11, 2, 3, 4, 11, 5], 0) → 2 0 X
array11([11, 5, 11], 0) → 2 0 X
other tests
OK
please advise
ASKER CERTIFIED SOLUTION
membership
This solution is only available to members.
To access this solution, you must be a member of Experts Exchange.
Pseudo code above is wrong.
Working solution (one of) is:
Output on my machine (I wrote in C#):
array11([11, 11], 0) = 2
array11([1, 2, 3, 4], 0) = 0
array11([1, 11, 3, 11, 11], 0) = 3
array11([11], 0) = 1
array11([1], 0) = 0
array11([], 0) = 0
array11([11, 2, 3, 4, 11, 5], 0) = 2
array11([11, 5, 11], 0) = 2
Working solution (one of) is:
public int array11(int[] nums, int index)
{
int count = 0;
if (index >= nums.Length)
{
return 0;// we need to stop recursion immediately and prevent any index out of range exceptions
}
else if (nums[index] == 11)
{
count = 1;
}
return count + array11(nums, index + 1);
}
Output on my machine (I wrote in C#):
array11([11, 11], 0) = 2
array11([1, 2, 3, 4], 0) = 0
array11([1, 11, 3, 11, 11], 0) = 3
array11([11], 0) = 1
array11([1], 0) = 0
array11([], 0) = 0
array11([11, 2, 3, 4, 11, 5], 0) = 2
array11([11, 5, 11], 0) = 2
SOLUTION
membership
This solution is only available to members.
To access this solution, you must be a member of Experts Exchange.
ASKER
you should remove the commented parts and the final 'else'.
if i remove else getting below error
public int array11(int[] nums, int index) {
int count=0;
if(index>=nums.length){
return 0;
}
if(nums[index]==11){
return 1+array11(nums,index+1);
}
}
Compile problems:
Error: public int array11(int[] nums, int index) {
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
This method must return a result of type int
Possible problem: the if-statement structure may theoretically
allow a run to reach the end of the method without calling return.
Consider adding a last line in the method return some_value;
so a value is always returned.
see Example Code to help with compile problems
please advise
if i remove else getting below error
your last valid code:
public int array11(int[] nums, int index) {
int count=0;
/* if(nums.length==0){
return 0;
}*/
if(index>=nums.length){
return 0;
}
if(nums[index]==11){
return 1+array11(nums,index+1);
}
/* else if((nums[index]==1)&&nums[index+1]==11){
return count++;
}*/
else return array11(nums,index+1);
}
if you would remove commented statements and final 'else' you get
public int array11(int[] nums, int index) {
int count=0;
if(index>=nums.length){
return 0;
}
if(nums[index]==11){
return 1+array11(nums,index+1);
}
return array11(nums,index+1);
}
note, i said the final 'else' and not the final 'else statement/block'.
the 'else' is not needed when the if block before ends with a return statement.
Sara
ASKER
note, i said the final 'else' and not the final 'else statement/block'.
the 'else' is not needed when the if block before ends with a return statement.
got it. new to me else not needed when if block before ends with a return. any other detailed links on this concept to read or any other examples on it?
new to me else not needed when if block before ends with a return
that is not a concept but basic boolean logic:
if (some_condition)
{
do_something();
return;
}
// if you reached this point, some_condition was false and
// therefore you are effectively in an 'else' block here.
do_something_else();
return;
the above is equivalent to
if (some_condition)
{
do_something();
return;
}
else
{
do_something_else();
return;
}
note, i would recommend to always use {} for if and else.
Sara
ASKER
that is not a concept but basic boolean logic:above is very clear
if (some_condition)
{
do_something();
return;
}
// if you reached this point, some_condition was false and
// therefore you are effectively in an 'else' block here.
do_something_else();
return;
Select all
Open in new window
the above is equivalent to
if (some_condition)
{
do_something();
return;
}
else
{
do_something_else();
return;
}
after if it is implicitly else whether we write or not
But recommended to use explicit else with { and }
But recommended to use explicit else with { and }
actually, it is a matter of style and therefore it is recommended to always do it same way and use the method which is better readable. the readability may be different for you and me. i like the first better (without else), but you may use the second one. anyway, you should not omit the barckets if using 'else'.
Sara
ASKER
sure
ASKER
public int array11(int[] nums, int index) {
int count=0;
if(index>=nums.length){
return 0;
}
if(nums[index]==11){
return 1+array11(nums,index+1);
}
return array11(nums,index+1);
}
how above different from below
public int array11(int[] nums, int index) {
int count=0;
if(index>=nums.length){
return 0;
}
else if(nums[index]==11){
return 1+array11(nums,index+1);
}
return array11(nums,index+1);
}
when to use above when to use below.
i confuse always with above 2 use cases?
ASKER
both of above constructs passes all tests?
any preference one over other here or in general?
any preference one over other here or in general?
There is no difference really. In both cases you check the first condition:
(index>=nums.length)
If it is not satisfied - you test second condition:
(nums[index]==11)
If you want you may check what is compiled CIL code. I have suspicion it will be exactly same.
One note: there is no point to declare
int count=0;
You do not use the variable.
(index>=nums.length)
If it is not satisfied - you test second condition:
(nums[index]==11)
If you want you may check what is compiled CIL code. I have suspicion it will be exactly same.
One note: there is no point to declare
int count=0;
You do not use the variable.
ASKER
If you want you may check what is compiled CIL code.
how to check this?
You may use something like http://ilspy.net/
Try to search for "How can I view MSIL / CIL generated by C# compiler?"
Try to search for "How can I view MSIL / CIL generated by C# compiler?"
ASKER
Open in new window
above passed all. any improvements or alternate approaches?