array11 challenge

Hi,

I am working on below challenge.
http://codingbat.com/prob/p135988
Psedo code:
1. create new array of the portion of original array length

2. check to see if if given index has 1 and next index also has 1iif yes return increment count by 1
3.else repeat recursion

I wrote my code as below
public int array11(int[] nums, int index) {
  int count=0;
  
   if(nums.length==0){
    return 0;
  }
  
/*   if(index>=nums.length){
    return 0;
  }*/
  if(index>=nums.length){
    return 0;
  }
    else if((nums[index]==1)&&nums[index+1]==11){
      return count++;
    }
    else return array11(nums,index+1);
  
}

Open in new window


i am failing some tests
Expected      Run            
array11([1, 2, 11], 0) → 1      0      X      
array11([11, 11], 0) → 2      0      X      
array11([1, 2, 3, 4], 0) → 0      0      OK      
array11([1, 11, 3, 11, 11], 0) → 3      0      X      
array11([11], 0) → 1      0      X      
array11([1], 0) → 0      Exception:java.lang.ArrayIndexOutOfBoundsException: 1 (line number:14)      X      
array11([], 0) → 0      0      OK      
array11([11, 2, 3, 4, 11, 5], 0) → 2      0      X      
array11([11, 5, 11], 0) → 2      0      X      
other tests
OK      

please advise
LVL 7
gudii9Asked:
Who is Participating?
 
sarabandeCommented:
you should remove the commented parts and the final 'else'.

since you have a return in the if block above the else statement  the 'else' keyword can (and should) be omitted.

Sara
0
 
gudii9Author Commented:
public int array11(int[] nums, int index) {
  int count=0;
  
  /* if(nums.length==0){
    return 0;
  }*/
  
   if(index>=nums.length){
    return 0;
  }
  if(nums[index]==11){
    return 1+array11(nums,index+1);
  }
   /* else if((nums[index]==1)&&nums[index+1]==11){
      return count++;
    }*/
    else return array11(nums,index+1);
  
}

Open in new window


above passed all. any improvements or alternate approaches?
0
 
anarki_jimbelCommented:
Pseudo code above is wrong.

Working solution (one of) is:

        public int array11(int[] nums, int index)
        {
            int count = 0;

            if (index >= nums.Length)
            {
                return  0;// we need to stop recursion immediately and prevent any index out of range exceptions
            }
            else if (nums[index] == 11)
            {
                count = 1;
            }

            return count + array11(nums, index + 1);
        }

Open in new window



Output on my machine (I wrote in C#):

array11([11, 11], 0)  = 2
array11([1, 2, 3, 4], 0)  = 0
array11([1, 11, 3, 11, 11], 0)  = 3
array11([11], 0)  = 1
array11([1], 0)  = 0
array11([], 0)  = 0
array11([11, 2, 3, 4, 11, 5], 0)  = 2
array11([11, 5, 11], 0)  = 2
0
Get your problem seen by more experts

Be seen. Boost your question’s priority for more expert views and faster solutions

 
anarki_jimbelCommented:
Below is Java code you may run on the web site:

public int array11(int[] nums, int index) {
              int count = 0;

            if (index >= nums.length)
            {
                return  0;// we need to stop recursion immediately and prevent any index out of range exceptions
            }
            else if (nums[index] == 11)
            {
                count = 1;
            }

            return count + array11(nums, index + 1);
}

Open in new window

0
 
gudii9Author Commented:
you should remove the commented parts and the final 'else'.

if i remove else getting below error
public int array11(int[] nums, int index) {
  int count=0;
  if(index>=nums.length){
    return 0;
  }
  if(nums[index]==11){
    return 1+array11(nums,index+1);
  }
  
}

Open in new window


Compile problems:


Error:      public int array11(int[] nums, int index) {
                 ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
This method must return a result of type int

Possible problem: the if-statement structure may theoretically
allow a run to reach the end of the method without calling return.
Consider adding a last line in the method return some_value;
so a value is always returned.

see Example Code to help with compile problems

please advise
0
 
sarabandeCommented:
if i remove else getting below error

your last valid code:

public int array11(int[] nums, int index) {
  int count=0;
  
  /* if(nums.length==0){
    return 0;
  }*/
  
   if(index>=nums.length){
    return 0;
  }
  if(nums[index]==11){
    return 1+array11(nums,index+1);
  }
   /* else if((nums[index]==1)&&nums[index+1]==11){
      return count++;
    }*/
    else return array11(nums,index+1);
  
}

Open in new window


if you would remove commented statements and final 'else' you get

public int array11(int[] nums, int index) {
  int count=0;
 
  if(index>=nums.length){
    return 0;
  }
  if(nums[index]==11){
    return 1+array11(nums,index+1);
  }
  return array11(nums,index+1);

}

Open in new window


note, i said the final 'else' and not the final 'else statement/block'.

the 'else' is not needed when the if block before ends with a return statement.

Sara
0
 
gudii9Author Commented:
note, i said the final 'else' and not the final 'else statement/block'.

the 'else' is not needed when the if block before ends with a return statement.

got it. new to me else not needed when if block before ends with a return. any other detailed links on this concept to read or any other examples on it?
0
 
sarabandeCommented:
new to me else not needed when if block before ends with a return

that is not a concept but basic boolean logic:

if (some_condition)
{
       do_something();
       return;
}
// if you reached this point, some_condition was false and 
// therefore you are effectively in an 'else' block here. 

do_something_else();
return;

Open in new window


the above is equivalent to

if (some_condition)
{
       do_something();
       return;
}
else
{
     do_something_else();
     return;
}

Open in new window


note, i would recommend to always use {} for if and else.


Sara
0
 
gudii9Author Commented:
that is not a concept but basic boolean logic:
if (some_condition)
{
       do_something();
       return;
}
// if you reached this point, some_condition was false and
// therefore you are effectively in an 'else' block here.

do_something_else();
return;

Select all
 
Open in new window

the above is equivalent to

if (some_condition)
{
       do_something();
       return;
}
else
{
     do_something_else();
     return;
}
above is very clear
after if it is implicitly else whether we write or not

But recommended to use explicit else with { and }
0
 
sarabandeCommented:
But recommended to use explicit else with { and }

actually, it is a matter of style and therefore it is recommended to always do it same way and use the method which is better readable. the readability may be different for you and me. i like the first better (without else), but you may use the second one. anyway, you should not omit the barckets if using 'else'.

Sara
0
 
gudii9Author Commented:
sure
0
 
gudii9Author Commented:
public int array11(int[] nums, int index) {
  int count=0;
 
  if(index>=nums.length){
    return 0;
  }
   if(nums[index]==11){
    return 1+array11(nums,index+1);
  }
  return array11(nums,index+1);

}

Open in new window


how above different from below

public int array11(int[] nums, int index) {
  int count=0;
 
  if(index>=nums.length){
    return 0;
  }
  else if(nums[index]==11){
    return 1+array11(nums,index+1);
  }
  return array11(nums,index+1);

}

Open in new window


when to use above when to use below.
i confuse always with above 2 use cases?
0
 
gudii9Author Commented:
both of above constructs passes all tests?

any preference one over other here or in general?
0
 
anarki_jimbelCommented:
There is no difference really. In both cases you check the first condition:
(index>=nums.length)
If it is not satisfied - you test second condition:
(nums[index]==11)

If you want you may check what is compiled CIL code. I have suspicion it will be exactly same.

One note: there is no point to declare
int count=0;
You do not use the variable.
0
 
gudii9Author Commented:
If you want you may check what is compiled CIL code.

how to check this?
0
 
anarki_jimbelCommented:
You may use something like http://ilspy.net/

Try to search for "How can I view MSIL / CIL generated by C# compiler?"
0
Question has a verified solution.

Are you are experiencing a similar issue? Get a personalized answer when you ask a related question.

Have a better answer? Share it in a comment.

All Courses

From novice to tech pro — start learning today.