Solved

countHi2 challenge

Posted on 2016-09-23
7
43 Views
Last Modified: 2016-09-23
Hi,

I am working on below challenge.
http://codingbat.com/prob/p143900
Psedo code:
1. check the given string starts with hi and does not have x infront of it
2.if true increment by 1 and call recursive function
3. if false call recusive function again

I wrote my code as below and not passing all tests
public int countHi2(String str) {
 if (str.length() <2){ 
	    	return 0;
	    		}
	    if (str.startsWith( "hi")&!str.startsWith("xhi")) {
	    	return 1 + countHi2(str.substring(2));
	    	}
	    	else {
		   return countHi2(str.substring(1));
	    	  
	    	}
	
}

Open in new window


Expected      Run            
countHi2("ahixhi") → 1      2      X      
countHi2("ahibhi") → 2      2      OK      
countHi2("xhixhi") → 0      2      X      
countHi2("hixhi") → 1      2      X      
countHi2("hixhhi") → 2      2      OK      
countHi2("hihihi") → 3      3      OK      
countHi2("hihihix") → 3      3      OK      
countHi2("xhihihix") → 2      3      X      
countHi2("xxhi") → 0      1      X      
countHi2("hixxhi") → 1      2      X      
countHi2("hi") → 1      1      OK      
countHi2("xxxx") → 0      0      OK      
countHi2("h") → 0      0      OK      
countHi2("x") → 0      0      OK      
countHi2("") → 0      0      OK      
countHi2("Hellohi") → 1      1      OK      
other tests
X      
Any improvements or alternate approaches?      

please advise
0
Comment
Question by:gudii9
  • 4
  • 3
7 Comments
 
LVL 27

Expert Comment

by:rrz
Comment Utility
Your error in logic is this line
if (str.startsWith( "hi")&!str.startsWith("xhi")) 

Open in new window

You will have to break this up into two conditionals. If str starts with "xhi" then skip 3 indexes.
0
 
LVL 7

Author Comment

by:gudii9
Comment Utility
public int countHi2(String str) {
 if (str.length() <2){ 
	    	return 0;
	    		}
	    if (str.startsWith( "hi")) {
	      if(!str.startsWith("xhi")){
	    	return 1 + countHi2(str.substring(2));
	    	}
	    }
	    	else {
		   return countHi2(str.substring(1));
	    	  
	    	}
	
}

Open in new window


something like above
I keep getting below error many times
Compile problems:


Error:      public int countHi2(String str) {
                 ^^^^^^^^^^^^^^^^^^^^
This method must return a result of type int

Possible problem: the if-statement structure may theoretically
allow a run to reach the end of the method without calling return.
Consider adding a last line in the method return some_value;
so a value is always returned.

please advise
0
 
LVL 27

Expert Comment

by:rrz
Comment Utility
I will try to write pseudo code for  the code you posted.

if(length of str is less than 2) return 0  
if(str starts with hi and does not starts with xhi)
         return 1 + whatever countHi2(str minus the first two characters) returns
else return whatever countHi2(str minus the first character) returns

In the second if statement, you and I know that that if str starts with hi then it can't start with xhi(mutually exclusive). But the compiler doesn't know that. So, the compiler thinks that the first condition(start with hi) could be true and the second condition(start with xhi) could be false. If that did happen, then your code wouldn't return anything.  That is why you get that error.
Anyway, as I posted above here, you will have to break this up into two separate conditionals. If str starts with "xhi" then skip 3 indexes.
0
Top 6 Sources for Identifying Threat Actor TTPs

Understanding your enemy is essential. These six sources will help you identify the most popular threat actor tactics, techniques, and procedures (TTPs).

 
LVL 7

Author Comment

by:gudii9
Comment Utility
public int countHi2(String str) {
 if (str.length() <2){ 
	    	return 0;
	    		}
	    if (str.startsWith( "hi")) {
	      
	    	return 1 + countHi2(str.substring(2));
	    	}	  
	    	
	    	if (str.startsWith( "xhi")) {
	      
	    	return countHi2(str.substring(3));
	    	}	
	    	
  
	    	else {
		   return countHi2(str.substring(1));
	    	}
}
/*if(length of str is less than 2) return 0  
if(str starts with hi and does not starts with xhi)
         return 1 + whatever countHi2(str minus the first two characters) returns 
else return whatever countHi2(str minus the first character) returns */

Open in new window


above passes all tests. any improvement or alternate approaches?
0
 
LVL 27

Accepted Solution

by:
rrz earned 500 total points
Comment Utility
My code is the same as yours. Personally, I like to format it differently.
public int countHi2(String str) {
    if(str.length() < 2)return 0;
	if(str.startsWith("xhi"))return countHi2(str.substring(3));
	if(str.startsWith("hi"))return 1 + countHi2(str.substring(2));
	return countHi2(str.substring(1));
}

Open in new window

0
 
LVL 7

Author Comment

by:gudii9
Comment Utility
if(str.startsWith("xhi"))return countHi2(str.substring(3));
	if(str.startsWith("hi"))return 1 + countHi2(str.substring(2));

Open in new window

your order as above is reverse compared to my order as below

 if (str.startsWith( "hi")) {
	      
	    	return 1 + countHi2(str.substring(2));
	    	}	  
	    	
	    	if (str.startsWith( "xhi")) {
	      
	    	return countHi2(str.substring(3));
	    	}	
	    	

Open in new window



does it matter the order here or in general??
0
 
LVL 27

Expert Comment

by:rrz
Comment Utility
does it matter the order here or in general??
In general, it probably matters. But, in this case it doesn't matter.
0

Featured Post

Free Trending Threat Insights Every Day

Enhance your security with threat intelligence from the web. Get trending threat insights on hackers, exploits, and suspicious IP addresses delivered to your inbox with our free Cyber Daily.

Join & Write a Comment

Suggested Solutions

If you haven’t already, I encourage you to read the first article (http://www.experts-exchange.com/articles/18680/An-Introduction-to-R-Programming-and-R-Studio.html) in my series to gain a basic foundation of R and R Studio.  You will also find the …
In this post we will learn how to connect and configure Android Device (Smartphone etc.) with Android Studio. After that we will run a simple Hello World Program.
The goal of the video will be to teach the user the difference and consequence of passing data by value vs passing data by reference in C++. An example of passing data by value as well as an example of passing data by reference will be be given. Bot…
The viewer will be introduced to the technique of using vectors in C++. The video will cover how to define a vector, store values in the vector and retrieve data from the values stored in the vector.

771 members asked questions and received personalized solutions in the past 7 days.

Join the community of 500,000 technology professionals and ask your questions.

Join & Ask a Question

Need Help in Real-Time?

Connect with top rated Experts

12 Experts available now in Live!

Get 1:1 Help Now