Solved

PHP/REGEX: Where file names do not have underscore with glob

Posted on 2016-09-29
8
44 Views
Last Modified: 2016-09-30
$f = glob('files/courses/{*_[0-9]*.zip}', GLOB_BRACE);

Open in new window

This matches:
x_123.zip
y_543.zip
z_789.zip

But it does not match:
x123.zip
y543.zip
z789.zip

How can I get it to match:
x123.zip
y543.zip
z789.zip

but not:
x_123.zip
y_543.zip
z_789.zip
?
0
Comment
Question by:skij
  • 3
  • 2
  • 2
  • +1
8 Comments
 
LVL 34

Expert Comment

by:gr8gonzo
Comment Utility
add a ? after the _
0
 
LVL 10

Author Comment

by:skij
Comment Utility
I don't want these to match!
x_123.zip
y_543.zip
z_789.zip

If there is a _ before the number then it should not match.
0
 
LVL 34

Assisted Solution

by:Dan Craciun
Dan Craciun earned 50 total points
Comment Utility
$f = glob('files/courses/{[^_]+[0-9]*.zip}', GLOB_BRACE);

HTH,
Dan
0
 
LVL 34

Expert Comment

by:gr8gonzo
Comment Utility
{[a-zA-Z0-9]+.zip}
0
What Security Threats Are You Missing?

Enhance your security with threat intelligence from the web. Get trending threat insights on hackers, exploits, and suspicious IP addresses delivered to your inbox with our free Cyber Daily.

 
LVL 10

Author Comment

by:skij
Comment Utility
Please look carefully at the examples I gave in my original post.

None of the ideas work with the examples provided.
0
 
LVL 34

Assisted Solution

by:gr8gonzo
gr8gonzo earned 150 total points
Comment Utility
Sorry - I was trying to get back a quick response earlier. I have a few more minutes now and I can tell you that glob() doesn't have a full regex engine, which will make it pretty difficult to do any sort of complex filtering in the future.

So if those are truly the filenames, then this should work:
$f = glob('files/courses/[a-z][0-9]*.zip');

But I'd recommend you set yourself up for success later on and put in a quick use of the full regex engine using preg_match to filter the results that come back:

$f = glob('files/courses/*[0-9]*.zip');
foreach($f as $fk => $fv) { if(!preg_match("/^[a-zA-Z][0-9]+.zip/",basename($fv))) { unset($f[$fk]); } }
0
 
LVL 51

Accepted Solution

by:
Julian Hansen earned 300 total points
Comment Utility
glob is actually quite a slow function - especially if you are going to iterate through the results afterwards.
Try the FileSystemIterator instead

$regex = "/^[a-zA-Z]+[0-9]+\.zip$/";
$path = 'files/courses';

$iterator = new FilesystemIterator($path, FilesystemIterator::SKIP_DOTS + FilesystemIterator::CURRENT_AS_PATHNAME + FilesystemIterator::KEY_AS_FILENAME);
$desirable = array();
foreach ($iterator as $key => $filepath) {
  if (preg_match($regex, $key)) {
    $desirable[] = $filepath;
  }
}

Open in new window

EDIT
Changed to use KEY_AS_FILENAME to remove requirement for basename - 50% faster.
0
 
LVL 51

Expert Comment

by:Julian Hansen
Comment Utility
For interest FSI ran in approx 1/5 of the time of the glob solution.
0

Featured Post

What Security Threats Are You Missing?

Enhance your security with threat intelligence from the web. Get trending threat insights on hackers, exploits, and suspicious IP addresses delivered to your inbox with our free Cyber Daily.

Join & Write a Comment

Deprecated and Headed for the Dustbin By now, you have probably heard that some PHP features, while convenient, can also cause PHP security problems.  This article discusses one of those, called register_globals.  It is a thing you do not want.  …
I imagine that there are some, like me, who require a way of getting currency exchange rates for implementation in web project from time to time, so I thought I would share a solution that I have developed for this purpose. It turns out that Yaho…
Learn how to match and substitute tagged data using PHP regular expressions. Demonstrated on Windows 7, but also applies to other operating systems. Demonstrated technique applies to PHP (all versions) and Firefox, but very similar techniques will w…
This tutorial will teach you the core code needed to finalize the addition of a watermark to your image. The viewer will use a small PHP class to learn and create a watermark.

762 members asked questions and received personalized solutions in the past 7 days.

Join the community of 500,000 technology professionals and ask your questions.

Join & Ask a Question

Need Help in Real-Time?

Connect with top rated Experts

9 Experts available now in Live!

Get 1:1 Help Now