Solved

# topping2 challenge

Posted on 2016-09-29
62 Views
Hi,

I am working on below challenge.
http://codingbat.com/prob/p196458

Given a map of food keys and their topping values, modify and return the map as follows: if the key "ice cream" has a value, set that as the value for the key "yogurt" also. If the key "spinach" has a value, change that value to "nuts".

topping2({"ice cream": "cherry"}) → {"yogurt": "cherry", "ice cream": "cherry"}
topping2({"spinach": "dirt", "ice cream": "cherry"}) → {"yogurt": "cherry", "spinach": "nuts", "ice cream": "cherry"}
topping2({"yogurt": "salt"}) → {"yogurt": "salt"}

0
Question by:gudii9
• 8
• 5

LVL 37

Expert Comment

ID: 41823223
Rule 1. if the key "ice cream" has a value, (=the condition)
set that as the value for the key "yogurt" also. (=the action to perform)

Rule 2. If the key "spinach" has a value, (= condition)
change that value to "nuts". (=the action to perform)

Tell me, what exactly do you not understand about that?

Rule 1 changes
{"ice cream": "cherry"}
into
{"yogurt": "cherry", "ice cream": "cherry"}
What do you not understand?

Both rules change
{"spinach": "dirt", "ice cream": "cherry"}
into
{"yogurt": "cherry", "spinach": "nuts", "ice cream": "cherry"}
What do you not understand?

For the example
{"yogurt": "salt"}
the condition of rule 1 is NOT fullfilled and the condition of rule 2 is NOT fullfilled, hence
it stays unchanged.
What do you not understand?
0

LVL 7

Author Comment

ID: 41823483
let me re read and think
0

LVL 7

Author Comment

ID: 41847359
topping2({"ice cream": "cherry"}) → {"yogurt": "cherry", "ice cream": "cherry"}
i understand rule 1 now
0

LVL 7

Author Comment

ID: 41847364
Rule 2. If the key "spinach" has a value, (= condition)
change that value to "nuts". (=the action to perform)
based on above i thought
{"spinach": "dirt", "ice cream": "cherry"}
into
{"yogurt": "cherry", "spinach": "nuts", "ice cream": "cherry"}
instead of above it should be as below

{"spinach": "dirt", "ice cream": "cherry"}
into
{"nuts" "dirt"}
0

LVL 37

Expert Comment

ID: 41847780
0

LVL 7

Author Comment

ID: 41881009
``````public Map<String, String> topping2(Map<String, String> map) {
//public Map < String, String > topping1(Map < String, String > map) {
//  if (map.containsKey("ice cream")) {
map.put("ice cream", "cherry");

//  }
return map;

}
``````

Expected      Run
topping2({"ice cream": "cherry"}) → {"yogurt": "cherry", "ice cream": "cherry"}      {"bread": "butter", "ice cream": "cherry"} missing: "yogurt": "cherry"      X
topping2({"spinach": "dirt", "ice cream": "cherry"}) → {"yogurt": "cherry", "spinach": "nuts", "ice cream": "cherry"}      {"bread": "butter", "spinach": "dirt", "ice cream": "cherry"} missing: "yogurt": "cherry"      X
topping2({"yogurt": "salt"}) → {"yogurt": "salt"}      {"yogurt": "salt", "bread": "butter", "ice cream": "cherry"}      X
topping2({"yogurt": "salt", "bread": "butter"}) → {"yogurt": "salt", "bread": "butter"}      {"yogurt": "salt", "bread": "butter", "ice cream": "cherry"}      X
topping2({}) → {}      {"bread": "butter", "ice cream": "cherry"}      X
topping2({"salad": "oil", "ice cream": "air"}) → {"salad": "oil", "yogurt": "air", "ice cream": "air"}      {"salad": "oil", "bread": "butter", "ice cream": "cherry"} missing: "yogurt": "air"      X
0

LVL 37

Expert Comment

ID: 41881746
So, your code - without the commented lines - is this:
``````public Map<String, String> topping2(Map<String, String> map) {
map.put("ice cream", "cherry");
return map;
}
``````

So, in all cases your result is always {"bread": "butter", "ice cream": "cherry"}
In that case, I think you shouldn't be surprised that some tests fail...

Use what you learned already in other topping challenges.
You're certainly able to write that yourself.
0

LVL 7

Author Comment

ID: 41887007
``````public Map<String, String> topping2(Map<String, String> map) {
//public Map < String, String > topping1(Map < String, String > map) {
// map.put("spinach", "nuts");
if (map.containsKey("spinach")) {
map.put("spinach", "nuts");

}
if (map.containsKey("yogurt")) {
map.put("yogurt", map.get("ice cream"));

}
return map;

}
``````

Expected      Run
topping2({"ice cream": "cherry"}) → {"yogurt": "cherry", "ice cream": "cherry"}      {"ice cream": "cherry"} missing: "yogurt": "cherry"      X
topping2({"spinach": "dirt", "ice cream": "cherry"}) → {"yogurt": "cherry", "spinach": "nuts", "ice cream": "cherry"}      {"spinach": "nuts", "ice cream": "cherry"} missing: "yogurt": "cherry"      X
topping2({"yogurt": "salt"}) → {"yogurt": "salt"}      {"yogurt": null}      X
topping2({}) → {}      {}      OK
topping2({"salad": "oil", "ice cream": "air"}) → {"salad": "oil", "yogurt": "air", "ice cream": "air"}      {"salad": "oil", "ice cream": "air"} missing: "yogurt": "air"      X
Your progress graph for this problem

0

LVL 7

Author Comment

ID: 41887010
``````Rule 1 changes
{"ice cream": "cherry"}
into
{"yogurt": "cherry", "ice cream": "cherry"}
What do you not understand?
``````

0

LVL 7

Author Comment

ID: 41887017
``````public Map<String, String> topping2(Map<String, String> map) {
//public Map < String, String > topping1(Map < String, String > map) {
// map.put("spinach", "nuts");
if (map.containsValue("spinach")) {
map.put("spinach", "nuts");
}
if (map.containsKey("ice cream")) {
map.put("yogurt", map.get("ice cream"));
// map.put("ice cream", map.get("ice cream"));

}
return map;
}
``````

public Map<String, String> topping2(Map<String, String> map) {
//public Map < String, String > topping1(Map < String, String > map) {
// map.put("spinach", "nuts");
if (map.containsValue("spinach")) {
map.put("spinach", "nuts");
}
if (map.containsKey("ice cream")) {
map.put("yogurt", map.get("ice cream"));
// map.put("ice cream", map.get("ice cream"));

}
return map;
}

0

LVL 37

Accepted Solution

zzynx earned 500 total points
ID: 41887443
Rule 1 is correctly implemented.
Rule 2 is not.

Why do you implement the condition
>> If the key "spinach" has a value,
like
>> if (map.containsValue("spinach")) {

containsKey() is not the same as containsValue()!!!
0

LVL 7

Author Comment

ID: 41888157
``````public Map<String, String> topping2(Map<String, String> map) {
//public Map < String, String > topping1(Map < String, String > map) {
// map.put("spinach", "nuts");
if (map.containsKey("spinach")) {
map.put("spinach", "nuts");
}
if (map.containsKey("ice cream")) {
map.put("yogurt", map.get("ice cream"));
// map.put("ice cream", map.get("ice cream"));

}
return map;
}
``````

above pass all
0

LVL 37

Expert Comment

ID: 41888258
Good!
0

## Featured Post

### Suggested Solutions

Introduction This article is the second of three articles that explain why and how the Experts Exchange QA Team does test automation for our web site. This article covers the basic installation and configuration of the test automation tools used by…
Although it can be difficult to imagine, someday your child will have a career of his or her own. He or she will likely start a family, buy a home and start having their own children. So, while being a kid is still extremely important, it’s also …
Viewers will learn about the regular for loop in Java and how to use it. Definition: Break the for loop down into 3 parts: Syntax when using for loops: Example using a for loop:
This tutorial explains how to use the VisualVM tool for the Java platform application. This video goes into detail on the Threads, Sampler, and Profiler tabs.