Solved

Reverse asset logic not working

Posted on 2016-10-04
11
45 Views
Last Modified: 2016-10-05
If I do this:

if(isset($_SESSION['sessionID']) || isset($_COOKIE['userID'])) {

echo "Welcome";

} else {

header("location:login.php");
exit;
}

Open in new window


then it works fine. If no session or cookie is set then the user is redirected. I don't want to do it this way because I don't actually want to do anything if the user is logged in, I only want to worry about if the cookie or session isn't set so I can redirect them. I tried to reverse the logic like this:

if(!isset($_SESSION['sessionID']) || !isset($_COOKIE['userID'])) {
	
	header("location:login.php");
	exit;
	
	}

Open in new window


but it doesn't work. I THINK it is saying, if no session is found OR if no cookie is found, redirect. If I enter correct login details it doesn't log me in, just sends me back to the login page.
0
Comment
Question by:Black Sulfur
  • 5
  • 4
  • 2
11 Comments
 
LVL 109

Expert Comment

by:Ray Paseur
ID: 41828599
Not sure whether this is the problem or not, but isset() may be too sensitive a test.  You might want to use empty() instead.  A field can be TRUE for isset() but FALSE for empty(), according to the man pages.  

The best approach might be to follow the design pattern in this article.
https://www.experts-exchange.com/articles/2391/PHP-Client-Registration-Login-Logout-and-Easy-Access-Control.html
0
 

Author Comment

by:Black Sulfur
ID: 41828615
Sorry, I did type isset but I noticed when typing it now that spell check changed it to asset, haha!

Thanks, Ray. I have been reading that from your previous post on my last question.

I think this is your code which is doing a similar thing:

function access_control($test=FALSE)
{
    // REMEMBER HOW WE GOT HERE
    $_SESSION["entry_uri"] = $_SERVER["REQUEST_URI"];

    // IF THE UID IS SET, WE ARE LOGGED IN
    if (isset($_SESSION["uid"])) return $_SESSION["uid"];

    // IF WE ARE NOT LOGGED IN - RESPOND TO THE TEST REQUEST
    if ($test) return FALSE;

    // IF THIS IS NOT A TEST, REDIRECT TO CALL FOR A LOGIN
    header("Location: RAY_EE_login.php");
    exit;
}

Open in new window


But then you also have this going on:

if (!isset($_SESSION["uid"]))
{

    // DETERMINE IF THE CLIENT IS ALREADY LOGGED IN BECAUSE OF "REMEMBER ME" FEATURE
    if (isset($_COOKIE["uuk"]))
    {

Open in new window

0
 

Author Comment

by:Black Sulfur
ID: 41828618
PS. I did try empty and I got the same result:

if(empty($_SESSION['sessionID']) || empty($_COOKIE['userID'])) {
	
	header("location:login.php");
	exit;
	
	}

Open in new window

0
Free Tool: ZipGrep

ZipGrep is a utility that can list and search zip (.war, .ear, .jar, etc) archives for text patterns, without the need to extract the archive's contents.

One of a set of tools we're offering as a way to say thank you for being a part of the community.

 
LVL 109

Assisted Solution

by:Ray Paseur
Ray Paseur earned 150 total points
ID: 41828654
The general logic I follow goes like this...

1. Test the session value.  If it's set, the client is logged in.
2. Test the cookie value.  If it's set, look up the client information and set the session value.
3. Else, the client is not logged in.

In this logic, the session is the canonical indicator of whether the client is logged in.  The cookie is used only to set the session value.

Consider this if statement:
if(empty($_SESSION['sessionID']) || empty($_COOKIE['userID'])) {
	
	header("location:login.php");
	exit;
	
	}

Open in new window

This is saying that if either the session or cookie is empty(), return TRUE.  In other words, a session alone is not going to allow the client to be logged in; there must be a separate cookie, too.  That's probably not what you want.
0
 
LVL 83

Accepted Solution

by:
Dave Baldwin earned 350 total points
ID: 41828671
I think you want to use 'AND' logic to test for both of them being empty.
if(empty($_SESSION['sessionID']) && empty($_COOKIE['userID'])) {

Open in new window

0
 

Author Comment

by:Black Sulfur
ID: 41828682
Ah, can't believe I didn't see that as that seems really obvious now that you pointed it out!
0
 

Author Comment

by:Black Sulfur
ID: 41828690
Regarding this...

  $_SESSION["entry_uri"] = $_SERVER["REQUEST_URI"];

Open in new window


Would you only use this as an extra security layer with a session based login because then you will always have to come from the login page to get to your account area? But it would not  work with cookies because I might just open my browser and go directly to the account page and completely bypass the login page?
0
 
LVL 83

Expert Comment

by:Dave Baldwin
ID: 41828735
$_SERVER["REQUEST_URI"] is the page you are currently on.  If you want to see where you came from, use $_SERVER["HTTP_REFERER"].  $_SERVER["HTTP_REFERER"] is Not set if you went directly to the page instead of from another page.  And since it can be spoofed, you should not rely only on it.  I do use it on a lot of pages though.  If they can't get that right, they shouldn't be there anyway.

http://php.net/manual/en/reserved.variables.server.php
1
 
LVL 109

Expert Comment

by:Ray Paseur
ID: 41828922
This is a complicated issue that produces a simple, intuitive, "good-UX" result.  If you read the article and still have questions about why we use that, please post a new question and I'll try to explain.
$_SESSION["entry_uri"] = $_SERVER["REQUEST_URI"];

Open in new window

0
 

Author Comment

by:Black Sulfur
ID: 41829300
Thanks guys. Ray, I have read the part of the article which explains it and I have looked at the code but I still can't understand why exactly you do it. I initially thought that maybe it was for if you are browsing a site and for example find a page with a particular product or article and you want to make a purchase, then if you login you will stay on that page instead of being taken to your dashboard and you have to hunt for that page again. But that probably isn't it. I will open a related question.
0
 
LVL 109

Expert Comment

by:Ray Paseur
ID: 41830108
I posted in the related question.  HTH, ~Ray
0

Featured Post

Free Tool: ZipGrep

ZipGrep is a utility that can list and search zip (.war, .ear, .jar, etc) archives for text patterns, without the need to extract the archive's contents.

One of a set of tools we're offering as a way to say thank you for being a part of the community.

Question has a verified solution.

If you are experiencing a similar issue, please ask a related question

Suggested Solutions

Title # Comments Views Activity
Huge email mystery. Receiving the same email, sometimes months apart. Maybe PHP? Maybe VPS server? 5 58
hbo knew my windows software 4 62
Help with PHP 13 27
PHP Mail error 3 26
Popularity Can Be Measured Sometimes we deal with questions of popularity, and we need a way to collect opinions from our clients.  This article shows a simple teaching example of how we might elect a favorite color by letting our clients vote for …
Password hashing is better than message digests or encryption, and you should be using it instead of message digests or encryption.  Find out why and how in this article, which supplements the original article on PHP Client Registration, Login, Logo…
The viewer will learn how to look for a specific file type in a local or remote server directory using PHP.
The viewer will learn how to create a basic form using some HTML5 and PHP for later processing. Set up your basic HTML file. Open your form tag and set the method and action attributes.: (CODE) Set up your first few inputs one for the name and …

856 members asked questions and received personalized solutions in the past 7 days.

Join the community of 500,000 technology professionals and ask your questions.

Join & Ask a Question