Solved

perl: Cleaning meta tags using RegEX

Posted on 2016-10-18
12
40 Views
Last Modified: 2016-10-19
I  need to clean the mata tags post building a html page by removing the forward slash at end of the line
I cannot  use a global replace =~s{\/>}{>}  as <hr /> and <src="example.com" /> are both valid so need to ensure i'm only removing from the end of the outputted meta tag

#!/usr/bin/perl


use strict; use warnings;
use HTML::TreeBuilder;
use HTML::Element;


my $body =HTML::TreeBuilder->new_from_file(*DATA);
#print $body->as_HTML('<>&','    ',{}) . "\n";

my %meta= (
"Author"=>"J K Rolling",
"title","Harry Potter and the Philosopher's Stone"

);
my $head = $body -> find_by_tag_name('_tag', 'head'); 
for my $m (sort keys %meta)
{
  my $m_el = HTML::Element->new('meta');
    # keep name content in correct order
     $m_el->attr('0name',$m);
     $m_el->attr('1content',$meta{$m});
     $head->push_content($m_el);
}
my $CloneOut = $body->as_HTML('<>&','      ',{});
    # clean up / remove 0 & 1
   $CloneOut =~ s/0name/name/ig;
   $CloneOut =~ s/1content/content/ig;  

   

   while(<$CloneOut>){  ##  Errors here on test script readline() on unopened filehandle
     my $line = $1;
     if ($line =~ m/meta/i){
        $line =~ s{\"\s+\/>}{\">};  ## is this correct?
     }
     print $line;
   }
    


__DATA__
<!DOCTYPE HTML PUBLIC "-//W3C//DTD HTML 4.01 Transitional//EN">
<html>
  <head>
  <title>Hello World</title>
  </head>
  <body>
    <h1> Books by J K Rolling</h1>
  </body>
</html>

Open in new window


this Outputs

<meta name="Author" content="J K Rolling" />

Open in new window


I need this

<meta name="Author" content="J K Rolling">

Open in new window

0
Comment
Question by:trevor1940
  • 5
  • 4
  • 3
12 Comments
 
LVL 48

Expert Comment

by:Rgonzo1971
Comment Utility
HI,

pls try
\s*\/(>)

Open in new window

Regards
0
 
LVL 48

Expert Comment

by:Rgonzo1971
Comment Utility
Maybe try

$y = "<meta name="Author" content="J K Rolling" />";
$y =~ s/\s*\/(>)/$1/;

Open in new window

0
 
LVL 1

Author Comment

by:trevor1940
Comment Utility
Your regex seems to work however I'm still getting this error

while(<$CloneOut>){  ##  Errors here readline() on unopened filehandle

Open in new window


$CloneOut isn't a filehandle it's a scaler so how do I  ensure i'm only changing the meta data and not html body?
0
 
LVL 48

Expert Comment

by:Rgonzo1971
Comment Utility
Sorry can't help further Perl not my speciality
0
 
LVL 28

Expert Comment

by:FishMonger
Comment Utility
Why are you using the diamond operator and why are you using a while loop?

If you remove the diamond operator, that will fix the "readline() on unopened filehandle" error; then you'll need to fix the infinite loop that your while loop creates.
0
 
LVL 1

Author Comment

by:trevor1940
Comment Utility
fix the infinite loop that your while loop creates

How do I do that?
0
What Should I Do With This Threat Intelligence?

Are you wondering if you actually need threat intelligence? The answer is yes. We explain the basics for creating useful threat intelligence.

 
LVL 28

Expert Comment

by:FishMonger
Comment Utility
You first need to ask yourself why you are using a loop.

$CloneOut is a scalar which holds a string of html and when used in the while condition, you're testing for truthfulness and since it never changes, it will always evaluate to true and becomes an infinite loop.

Instead of the loop, you could simply apply the regex to the scalar (making sure you use the g modifier).  If you want to use a loop, then you need to split the string into separate lines (i.e. turn it into an array or list) and loop over each of them.
0
 
LVL 1

Author Comment

by:trevor1940
Comment Utility
Instead of the loop, you could simply apply the regex to the scalar
$CloneOut  =~ s/\s*\/(>)/$1/g;

Open in new window


doesn't work because  

<hr /> and <img src="mypic.jpg" /> are both valid 

Open in new window


I'm  guessing
split the string into separate lines (i.e. turn it into an array or list) and loop over each of them.
I'd do something like this?

 
my @CloneOut = split  /$/m, $CloneOut;

Open in new window

0
 
LVL 28

Assisted Solution

by:FishMonger
FishMonger earned 500 total points
Comment Utility
You need to make your regex more specific so that it only matches the meta tag.

If you're going to split the string into its separate lines, then do this:
my @CloneOut = split  /\n/, $CloneOut;

Open in new window

0
 
LVL 28

Accepted Solution

by:
FishMonger earned 500 total points
Comment Utility
$CloneOut =~ s!(<meta [^/]+) /!$1!g;

Open in new window

0
 
LVL 1

Author Closing Comment

by:trevor1940
Comment Utility
Thank You  for your help
0
 
LVL 28

Expert Comment

by:FishMonger
Comment Utility
You're welcome, glad I was able to help.
0

Featured Post

What Security Threats Are You Missing?

Enhance your security with threat intelligence from the web. Get trending threat insights on hackers, exploits, and suspicious IP addresses delivered to your inbox with our free Cyber Daily.

Join & Write a Comment

I have been pestered over the years to produce and distribute regular data extracts, and often the request have explicitly requested the data be emailed as an Excel attachement; specifically Excel, as it appears: CSV files confuse (no Red or Green h…
In the distant past (last year) I hacked together a little toy that would allow a couple of Manager types to query, preview, and extract data from a number of MongoDB instances, to their tool of choice: Excel (http://dilbert.com/strips/comic/2007-08…
Explain concepts important to validation of email addresses with regular expressions. Applies to most languages/tools that uses regular expressions. Consider email address RFCs: Look at HTML5 form input element (with type=email) regex pattern: T…
When you create an app prototype with Adobe XD, you can insert system screens -- sharing or Control Center, for example -- with just a few clicks. This video shows you how. You can take the full course on Experts Exchange at http://bit.ly/XDcourse.

771 members asked questions and received personalized solutions in the past 7 days.

Join the community of 500,000 technology professionals and ask your questions.

Join & Ask a Question

Need Help in Real-Time?

Connect with top rated Experts

14 Experts available now in Live!

Get 1:1 Help Now