Using ADODB connects ok, but get "Object doesn't support this property or method"

See my sample code below. I can connect, and all looks good until I get the run-time errormessage when trying to get USER_NAME from r in line 11.

Sub testSql()
    Dim myConnection, myRecord, x, password
    password = InputBox("Passord: ")
    Set myConnection = CreateObject("ADODB.Connection")
    myConnection.Open "Driver={Microsoft ODBC for Oracle};" & "Server=(DESCRIPTION=(ADDRESS_LIST=(ADDRESS =(PROTOCOL=TCP)(HOST = 10.5.159.184)(PORT = 1541)))(CONNECT_DATA=(SERVICE_NAME=tiaqat)));" & "Uid=ive;" & "Pwd=" & password & ";"
    Set myRecord = CreateObject("ADODB.recordset")
    Sql = "SELECT * FROM TOP_USER"
    myRecord.Open Sql, myConnection
    For Each r In myRecord.Fields
       x = r.USER_NAME
    Next
End Sub

Open in new window

Then I am getting a 438-Object doesn't support this property or method-error. I am able to connect and do all sorts of stuff with the same connect string when I use e.g. PL/SQL-developer...

Thx!

Brgds
IVer
Iver Erling ArvaSenior consultantAsked:
Who is Participating?
 
ste5anConnect With a Mentor Senior DeveloperCommented:
Yup, kinda typo. It's myRecord![UserName] or myRecord.Fields("myRecord").
0
 
ste5anConnect With a Mentor Senior DeveloperCommented:
It's  x = r![USER_NAME] or x = r.Fields("USER_NAME").
1
 
xtermieCommented:
The x variable in your code will be a Field object. A field object does not have an id property hence the error. I suspect that user name is actually the name of the fields you want to use. Hence your code should look like ste5an's suggestion

You could also try changing your open to

myConnection.Open "SELECT USER_NAME FROM TOP_USER", db  
...
Server.URLEncode(myConnection("USER_NAME"))
...
and make your code smaller and only include the fields you need, andnever send unencoded data directly from the DB.
0
Cloud Class® Course: Ruby Fundamentals

This course will introduce you to Ruby, as well as teach you about classes, methods, variables, data structures, loops, enumerable methods, and finishing touches.

 
Iver Erling ArvaSenior consultantAuthor Commented:
ste5an:

Thanks, but

x = r![USER_NAME] gives me the following error:

Run-time error 450: Wrong number of arguments or invalid property assignment

x = r.Fields("USER_NAME")  gives me the following error:

Run-time error 438: Object doesn't support this property or method.

xtermie:

Thanks, encoded data is fine, but first I need to be able to get something back from the db.
I am not sure I understand your myConnection.Open line. Where do I put the connection details? And as I told you, I AM able to connect. If I put in another password, the database responds with wrong username and/or password, so that seem to be ok.

If I do a
SELECT USER_NAME FROM TOP_USER in PL/SQL Developer it works. The query here is just a simple sample anyway to test that I actually can do it this way. So far no luck, though.

Brgds
IVer
0
 
Iver Erling ArvaSenior consultantAuthor Commented:
That worked just fine! Thanks!

Brgds
IVer
0
 
Iver Erling ArvaSenior consultantAuthor Commented:
But the loop seems to just find the first record, though. It should be hundreds in that file. Do I need to do some sort of fetch between each?

Brgds
IVer
0
 
ste5anConnect With a Mentor Senior DeveloperCommented:
Yup, cause For Each is the wrong approach. You need a classic loop:

Do While Not myRecord.Bof And Not myRecord.Eof
  x = myRecord![USER_NAME]
  'Do something with x...
  myRecord.MoveNext
Loop

Open in new window

0
 
Iver Erling ArvaSenior consultantAuthor Commented:
ste5an:

Yes, thanks! I just figured that out myself while waiting for your answer ;-)

Great to have such good helpers around!

ALl the best from
IVer
0
 
xtermieCommented:
solution provided by Expert
0
Question has a verified solution.

Are you are experiencing a similar issue? Get a personalized answer when you ask a related question.

Have a better answer? Share it in a comment.

All Courses

From novice to tech pro — start learning today.