Solved

Novice question on VBScript

Posted on 2016-10-21
8
51 Views
Last Modified: 2016-10-27
Hello folks,

I'm working on a writing a VBScript and I have no experience with VBS.  I can do this with a command line with no problem, however, it needs to be in VBS.

The script I'm working on checks to see if 2 registry key exist, and if so, deletes a third key.  I've been looking around on the net and found some code that works for what I want to do.  My issue is on the delete RegKey code.  I found this code which works fine, however, if I modify it to point to a different location, it doesn't work.

Here is the code I found and if I put a key in the registry, it deletes it just fine:  HKCU\Software\Test

Const HKEY_CURRENT_USER = &H80000001 

strComputer = "."
strKeyPath = "Software\Test" 

Set objRegistry = GetObject("winmgmts:\\" & _
    strComputer & "\root\default:StdRegProv") 

DeleteSubkeys HKEY_CURRENT_USER, strKeypath 

Sub DeleteSubkeys(HKEY_CURRENT_USER, strKeyPath) 
    objRegistry.EnumKey HKEY_CURRENT_USER, strKeyPath, arrSubkeys 

    If IsArray(arrSubkeys) Then 
        For Each strSubkey In arrSubkeys 
            DeleteSubkeys HKEY_CURRENT_USER, strKeyPath & "\" & strSubkey 
        Next 
    End If 

    objRegistry.DeleteKey HKEY_CURRENT_USER, strKeyPath 
End Sub

Open in new window


But if I change the code to this, it doesn't work.  What am I doing wrong?  HKLM\Software\Test

Const HKEY_LOCAL_MACHINE = &H80000002 

strComputer = "."
strKeyPath = "Software\Test" 

Set objRegistry = GetObject("winmgmts:\\" & 
    strComputer & "\root\default:StdRegProv") 

DeleteSubkeys HKEY_LOCAL_MACHINE, strKeypath 

Sub DeleteSubkeys(HKEY_LOCAL_MACHINE, strKeyPath) 
    objRegistry.EnumKey HKEY_LOCAL_MACHINE, strKeyPath, arrSubkeys 

    If IsArray(arrSubkeys) Then 
        For Each strSubkey In arrSubkeys 
            DeleteSubkeys HKEY_LOCAL_MACHINE, strKeyPath & "\" & strSubkey 
        Next 
    End If 

    objRegistry.DeleteKey HKEY_LOCAL_MACHINE, strKeyPath 
End Sub

Open in new window

0
Comment
Question by:Jody Phillips
  • 3
  • 2
  • 2
  • +1
8 Comments
 
LVL 1

Expert Comment

by:CFB_Surfgoddess
ID: 41854330
You have a variable strKeyPath, but I do not see that variable assigned.  Don't know if that is the problem, but I would look at that.  Also are you using anything like notepad++ to write this?
What line is the error on...?  You can put on error resume which may make it work.
0
 

Author Comment

by:Jody Phillips
ID: 41854352
I'm using MetaPad and verified that it's a DOS VBS file.  The only thing I changed is the first line:

Const HKEY_CURRENT_USER = &H80000001

to

Const HKEY_LOCAL_MACHINE = &H80000002

and all instances of HKEY_CURRENT_USER to HKEY_LOCAL_MACHINE.  The first one works fine, but the second one doesn't.

Looks like I also have a typo in the second script.  In line 6 I forgot the underscore, but it's there in the script I have.
0
 
LVL 45

Assisted Solution

by:aikimark
aikimark earned 250 total points
ID: 41854493
I forgot the underscore
that's why you should always include an Option Explicit statement
1
 
LVL 21

Accepted Solution

by:
JesterToo earned 250 total points
ID: 41854779
HKCU keys are for the current user and are readable/writable by the current user.  However, HKLM keys are shared by all users and are read-only by all users.  In order to modify an HKLM key you need to run the script with elevated permissions (aka as administrator).
1
Is Your Active Directory as Secure as You Think?

More than 75% of all records are compromised because of the loss or theft of a privileged credential. Experts have been exploring Active Directory infrastructure to identify key threats and establish best practices for keeping data safe. Attend this month’s webinar to learn more.

 

Author Comment

by:Jody Phillips
ID: 41860851
OK, so I've tried to use this to elevate the permissions, but it's STILL not working.  My script name is Axcess-regkey.VBS and it's in the same directory.

Set objShell = CreateObject("Shell.Application")
Set FSO = CreateObject("Scripting.FileSystemObject")
strPath = FSO.GetParentFolderName (WScript.ScriptFullName)
     objShell.ShellExecute "wscript.exe", _ 
        Chr(34) & strPath & "\Axcess-regkey.VBS" & Chr(34), "", "runas", 1

Open in new window

0
 
LVL 45

Assisted Solution

by:aikimark
aikimark earned 250 total points
ID: 41860980
it's STILL not working
What error message do you get?
0
 
LVL 21

Assisted Solution

by:JesterToo
JesterToo earned 250 total points
ID: 41861004
Jody,
Your exact code (with the correction you mentioned above) works perfectly for me.
0
 

Author Comment

by:Jody Phillips
ID: 41862911
Not sure what I was doing wrong, but it seems to be working now.  Thanks for the help folks.
0

Featured Post

Is Your Active Directory as Secure as You Think?

More than 75% of all records are compromised because of the loss or theft of a privileged credential. Experts have been exploring Active Directory infrastructure to identify key threats and establish best practices for keeping data safe. Attend this month’s webinar to learn more.

Question has a verified solution.

If you are experiencing a similar issue, please ask a related question

Unlike scripting languages such as C# where a semi-colon is used to indicate the end of a command, Microsoft's VBScript language relies on line breaks to determine when a command begins and ends. As you can imagine, this quickly results in messy cod…
Welcome, welcome!  If you are new to the series and haven't been following along, please take a brief moment to review the first three installments: Part 1 (http://www.experts-exchange.com/Programming/Languages/Visual_Basic/VB_Script/A_266-VBScri…
Internet Business Fax to Email Made Easy - With eFax Corporate (http://www.enterprise.efax.com), you'll receive a dedicated online fax number, which is used the same way as a typical analog fax number. You'll receive secure faxes in your email, fr…
Many functions in Excel can make decisions. The most simple of these is the IF function: it returns a value depending on whether a condition you describe is true or false. Once you get the hang of using the IF function, you will find it easier to us…

911 members asked questions and received personalized solutions in the past 7 days.

Join the community of 500,000 technology professionals and ask your questions.

Join & Ask a Question

Need Help in Real-Time?

Connect with top rated Experts

20 Experts available now in Live!

Get 1:1 Help Now