AD User Modification PS script won't update user properties if manager ID is not available in AD

Help required for user modification script on list of users

The script has condition that if user manager is available in AD, set the same along with other properties, if not it should update the other properties

# Start of script
Import-Module ActiveDirectory

# Import File
$Users = Import-Csv "C:\userupdate\users.csv"
#Processing each user
Foreach ($User in $Users) {
    
    try {
        $ADUser = $null

        
        $ADUser = Get-ADUser -Identity $User.Username -ErrorAction SilentlyContinue
        if ($ADUser -ne $null) {
            $Manager = $null
            $Manager = Get-ADUser -Identity $User.ManagerID -ErrorAction SilentlyContinue
            if ($Manager -ne $null) {
                Set-ADUser -Identity $ADUser -Department $User.Department -Manager $user.ManagerID `
                -EmailAddress $User.Email -Company $user.Company -MobilePhone $user.CellPhone -Title $user.Title
                                
            }
            else {
                Set-ADUser -Identity $ADUser -Department $User.Department `
                -EmailAddress $User.Email -Company $user.Company -MobilePhone $user.CellPhone -Title $user.Title
                
            }
        }
       
             "$($ADUser.sAMAccountName), User Modified Successfully" | Out-File -FilePath "C:\userupdate\result.txt" -Append -Force
    }
# Catch error if any
    catch {
        "$($ADUser.sAMAccountName), Failed" | Out-File -FilePath "C:\userupdate\result.txt" -Append -Force
        $error[0] | Out-File "C:\userupdate\errorlog.txt" -Append
    }
}

Open in new window


No matter what I do, if manager ID is not available in AD, script simply won't process that user and don,t update other properties of that user

I wanted that if manager id is not available in AD, still script should process other properties

Any help would be highly appreciated
LVL 41
MaheshArchitectAsked:
Who is Participating?
 
CoralonConnect With a Mentor Commented:
You might try reworking it.. something like this..
Import-Module -Name ActiveDirectory -ErrorAction SilentlyContinue

$Users = Import-Csv -Path 'C:\userupdate\users.csv'

foreach ($User in $Users)
{
	Try
	{
		$ADUser = Get-ADUser -identity $User.UserName 
		Try
		{
		Set-ADUser -Identity $ADUser -Department $User.Department -EmailAddress $User.Email -Company $user.Company -MobilePhone $user.CellPhone -Title $user.Title
		}
		catch
		{
			"$($ADUser.sAMAccountName), User Modified Successfully (base properties)" | Out-File -FilePath "C:\userupdate\result.txt" -Append -Force
		}
		$ManagerID = $User.ManagerID
		
		if ($ManagerID) 
		{
			Try
			{
				$Manager = Get-ADUser -identity $ManagerID 
				Set-ADUser -identity $ADUser -Manager $Manager 
				"$($ADUser.sAMAccountName), User Modified Successfully" | Out-File -FilePath "C:\userupdate\result.txt" -Append -Force
			}
			catch
			{
				Write-Output "The ManagerID for $($User.username) does not exist in ActiveDirectory"
			}
		}
		else
		{
			Write-Output "No ManagerID specified for $($User.UserName)"
		}
	}
	catch
	{
		"$($ADUser.sAMAccountName), Failed" | Out-File -FilePath 'C:\userupdate\result.txt' -Append -Force
        $error[0] | Out-File 'C:\userupdate\errorlog.txt' -Append
	{
	Remove-Variable ManagerID, Manager
}

Open in new window


Coralon
0
 
footechCommented:
Try modifying line 23 to
$ADUser | Set-ADUser -Department $User.Department `

Open in new window


Also, why are you setting -ErrorAction to SilentlyContinue?  It pretty much negates the purpose of the try...catch block.
0
 
David Johnson, CD, MVPOwnerCommented:
Does every user in your csv have a ManagerID?
Line 18
if (($Manager -ne $null) -and ($user.ManagerID -ne $nulll) ){
0
Improved Protection from Phishing Attacks

WatchGuard DNSWatch reduces malware infections by detecting and blocking malicious DNS requests, improving your ability to protect employees from phishing attacks. Learn more about our newest service included in Total Security Suite today!

 
MaheshArchitectAuthor Commented:
Tried that

Still no luck

what should be -Erroraction ?
0
 
MaheshArchitectAuthor Commented:
yes csv has managerID defined because it is import from some other HRMS tool but those managerID may not available in AD

As soon as script did not find managerID in AD, it simply ignore that user by ignoring all conditions (if else etc)
0
 
footechConnect With a Mentor Commented:
I take back my comment about the -ErrorAction parameter.  I thought that Get-ADUser threw a non-terminating error, and you had to set -ErrorAction to Stop (making the error terminating) to get Try/Catch to work with it.  But I can't replicate the behavior now, so maybe my memory is faulty.  In any case, what was happening with your original code was that as soon as any error was thrown by the Get-ADUser command, whether on line 13 or 16, the catch block would be called to handle it.

I think Coralon's approach is good using multiple try/catch blocks.  Another way would be to change your Get-ADUser commands to use the -Filter parameter instead of -Identity, which won't through any errors if no matches are found.
0
 
MaheshArchitectAuthor Commented:
"Get-Aduser" if identity failed / didn't exists, it will pass on to next line in csv file

Basically if I try to modify "Manager" field along with other attributes, if manager id is not available in AD, it will simply ignore user for attributes as well.

I tried "if else" loop with filter specified for manager id and it also working, but then its unable to generate error code in errorlogfile if manager id is not available in AD

Hence I moved manager id modification to new line and now its started working.
I have modified code as below

# Start of script
Import-Module ActiveDirectory -ErrorAction Stop

# Define result and error log file
$DateTime = Get-Date -Format ddMMyyyy_HHmm
$ResultLogFile = "C:\userupdate\ResultLogFile_$DateTime.txt"
$ErrorLogFile = "C:\userupdate\ErrorLogFile_$DateTime.txt"
# Import File
$Users = Import-Csv "C:\userupdate\users.csv"
#Processing each user
Foreach ($User in $Users) {
    
    try {
        $ADUser = $null

        $ADUser = Get-ADUser -Identity $User.Username -ErrorAction SilentlyContinue
        if ($ADUser -ne $null) {
                Set-ADUser -Identity $ADUser -Department $User.Department -Manager $user.ManagerID `
                -EmailAddress $User.Email -Company $user.Company -MobilePhone $user.CellPhone -Title $user.Title
		        Set-Aduser -Identity $ADUser -Manager $user.ManagerID -ErrorAction SilentlyContinue }
            											       
	"$($ADUser.sAMAccountName), User Modified Successfully" | Out-File -FilePath $ResultLogFile -Append -Force
        }
            
       
# Catch error if any
    catch {
            if($ADUser.SamAccountName -eq $null) 
                { 
                    "$($user.Username),Account does not exists in AD" | Out-File -FilePath $ResultLogFile -Append -Force 
                                                                                                                          }
            else
                    { 
                      "$($ADUser.SamAccountName),User Modified Successfully but failed to update Manager field because its not availabe in AD" | Out-File -FilePath $ResultLogFile -Append -Force 
                                                                                                                                                                                                    }
                $($ADuser.SamAccountName) + " : " + $error[0].ToString() | Out-File $ErrorLogFile -Append
    }
}

Open in new window

0
 
MaheshArchitectAuthor Commented:
I am awarding points to Coralon and Footech both because both have provided valid inputs which helps me to resolve the issue
0
Question has a verified solution.

Are you are experiencing a similar issue? Get a personalized answer when you ask a related question.

Have a better answer? Share it in a comment.

All Courses

From novice to tech pro — start learning today.