Solved

Stored procedure with a parameter

Posted on 2016-10-27
6
30 Views
Last Modified: 2016-10-27
Hello,
Need to add a where clause to a stored procedure only if the column is present in the table .
ALTER PROCEDURE  [dbo].[M_SelectMaxVal_FrmCol]
(
     @tableName varchar(100) = null,
	 @ColumnName1 varchar(100) = null
	
)
AS
BEGIN
	-- SET NOCOUNT ON added to prevent extra result sets from
	-- interfering with SELECT statements.
	SET NOCOUNT ON;  	
	
	--   declare @SQL varchar(500) = null
	--  -- NONCLUSTERED INDEX [NIX__UNQ__UID_]

	--SET @SQL = 'SELECT MAX ('    
        
	--		SET @SQL = @SQL +  '[' +  @ColumnName1 + ']'  + ' +1 ) ' +   + ' FROM  [dbo].[' + @tableName + '] '  		
	
	--  SET @SQL = @SQL  	
	  
	--  EXEC(@SQL)


	  DECLARE @SQL VARCHAR(1000) = null


SET @SQL = '
	
		SELECT 
		
				CASE 
						WHEN CAST(GETDATE() AS DATE) = DATEADD(yy, DATEDIFF(yy, 0, GETDATE()), 0) THEN 1 
				ELSE 
				
						MAX ([' +  @ColumnName1 + ']'  + ' +1 ) END Output'  
				
				+ ' FROM  [dbo].[' + @tableName + ']'

			  
EXECUTE(@SQL)
		
   
	
END

Open in new window


Change it to
ALTER PROCEDURE  [dbo].[M_SelectMaxVal_FrmCol]
(
     @tableName varchar(100) = null,
	 @ColumnName1 varchar(100) = null

	
)
AS
BEGIN
	-- SET NOCOUNT ON added to prevent extra result sets from
	-- interfering with SELECT statements.
	SET NOCOUNT ON;  	
	
	--   declare @SQL varchar(500) = null
	--  -- NONCLUSTERED INDEX [NIX__UNQ__UID_]

	--SET @SQL = 'SELECT MAX ('    
        
	--		SET @SQL = @SQL +  '[' +  @ColumnName1 + ']'  + ' +1 ) ' +   + ' FROM  [dbo].[' + @tableName + '] '  		
	
	--  SET @SQL = @SQL  	
	  
	--  EXEC(@SQL)


	  DECLARE @SQL VARCHAR(1000) = null


SET @SQL = '
	
		SELECT 
		
				CASE 
						WHEN CAST(GETDATE() AS DATE) = DATEADD(yy, DATEDIFF(yy, 0, GETDATE()), 0) THEN 1 
				ELSE 
				
						MAX ([' +  @ColumnName1 + ']'  + ' +1 ) END Output'  
				
				+ ' FROM  [dbo].[' + @tableName + ']'


-----Add this only if year_ref column is present in the table 

SET @SQL = @Sql  +'where year_ref ' = '22'
			  
EXECUTE(@SQL)
		
   
	
END

Open in new window

0
Comment
Question by:RIAS
  • 3
  • 3
6 Comments
 
LVL 47

Expert Comment

by:Vitor Montalvão
ID: 41861873
You'll need to check that column name in the sys.columns view. If exists then add the WHERE clause:
ALTER PROCEDURE  [dbo].[M_SelectMaxVal_FrmCol]
(
 @tableName varchar(100) = null,
 @ColumnName1 varchar(100) = null	
)
AS
BEGIN
	-- SET NOCOUNT ON added to prevent extra result sets from interfering with SELECT statements.
	SET NOCOUNT ON;  	
	DECLARE @SQL VARCHAR(1000) = null
	
	SET @SQL = 'SELECT CASE 
			WHEN CAST(GETDATE() AS DATE) = DATEADD(yy, DATEDIFF(yy, 0, GETDATE()), 0) THEN 1 
			ELSE MAX ([' +  @ColumnName1 + ']'  + ' +1 ) END Output'  
		+ ' FROM  [dbo].[' + @tableName + ']'

	IF EXISTS(SELECT 1
		FROM sys.tables t
			INNER JOIN sys.columns c ON t.object_id=c.object_id
		WHERE t.name = @tableName AND c.name = 'year_ref')
		-----Add this only if year_ref column is present in the table 
		SET @SQL = @Sql  +' where year_ref = 22'
			  
	EXECUTE(@SQL)
	
END

Open in new window

0
 

Author Comment

by:RIAS
ID: 41861884
Thanks Vitor,

Is there a way where where year_ref take current year and checks in the look up table for the number my lookup table is like this:
table _YearLookup
Columns are  year_no and year_ref

0	0
1	1995
2	1996
3	1997
4	1998
5	1999
6	2000
7	2001
8	2002
9	2003
10	2004
11	2005
12	2006
13	2007
14	2008
15	2009
16	2010
17	2011
18	2012
19	2013
20	2014
21	2015
22	2016
23	2017
24	2018

Open in new window


So should return '22' for 2016 and so on
0
 
LVL 47

Accepted Solution

by:
Vitor Montalvão earned 500 total points
ID: 41861891
Yes, it can be made but you need to provide me the lookup table structure.
Or, since it looks like a mathematic formula (1995-1994=1; 2016-1994=22; 2018-1994=24; ...) you can add immediately the formula to the query:
ALTER PROCEDURE  [dbo].[M_SelectMaxVal_FrmCol]
(
     @tableName varchar(100) = null,
	 @ColumnName1 varchar(100) = null	
)
AS
BEGIN
	-- SET NOCOUNT ON added to prevent extra result sets from interfering with SELECT statements.
	SET NOCOUNT ON;  	
	DECLARE @SQL VARCHAR(1000) = null
	
	SET @SQL = 'SELECT CASE 
						WHEN CAST(GETDATE() AS DATE) = DATEADD(yy, DATEDIFF(yy, 0, GETDATE()), 0) THEN 1 
						ELSE MAX ([' +  @ColumnName1 + ']'  + ' +1 ) END Output'  
			+ ' FROM  [dbo].[' + @tableName + ']'

	IF EXISTS(SELECT 1
			FROM sys.tables t
				INNER JOIN sys.columns c ON t.object_id=c.object_id
			WHERE t.name = @tableName AND c.name = 'year_ref')
		-----Add this only if year_ref column is present in the table 
		SET @SQL = @Sql  +' WHERE year_ref = YEAR(GETDATE())-1994'
			  
	EXECUTE(@SQL)
	
END

Open in new window

0
Simplifying Server Workload Migrations

This use case outlines the migration challenges that organizations face and how the Acronis AnyData Engine supports physical-to-physical (P2P), physical-to-virtual (P2V), virtual to physical (V2P), and cross-virtual (V2V) migration scenarios to address these challenges.

 

Author Comment

by:RIAS
ID: 41861895
Cheers,

This is the query to create the table
ALTER PROCEDURE  [dbo].[SP_TblCreateYEAR_LOOKUP1]
AS
BEGIN
	-- SET NOCOUNT ON added to prevent extra result sets from
	-- interfering with SELECT statements.
	SET NOCOUNT ON;  

    --Script to create a look up table to dispaly years
	CREATE TABLE YEAR_LOOKUP
		(Year_Ref smallint NOT NULL,
		 Year_no smallint NOT NULL,
		 PRIMARY KEY (Year_Ref))
   
END

Open in new window


Query2 to add values


ALTER PROCEDURE  [dbo].[SP_TblCreateYEAR_LOOKUP1.1]
AS
BEGIN
	-- SET NOCOUNT ON added to prevent extra result sets from
	-- interfering with SELECT statements.
	SET NOCOUNT ON;  

  
    --Script to insert data in table  Year_Lookup 
		
	INSERT INTO YEAR_LOOKUP (Year_Ref, Year_no) VALUES
				 (0,0)
				,(1,1995),(2,1996),(3,1997),(4,1998)
				,(5,1999), (6,2000),(7,2001 ),(8,2002),(9,2003)
				,(10,2004),(11,2005),(12,2006),(13,2007),(14,2008)
				,(15,2009),(16,2010),(17,2011),(18,2012),(19,2013)
				,(20,2014),(21,2015),(22,2016),(23,2017),(24,2018)
END

Open in new window

0
 

Author Comment

by:RIAS
ID: 41861903
Vitor, Cheers!
It worked like charm!
0
 
LVL 47

Expert Comment

by:Vitor Montalvão
ID: 41861904
So you won't need to use the lookup table in the SP?
1

Featured Post

Best Practices: Disaster Recovery Testing

Besides backup, any IT division should have a disaster recovery plan. You will find a few tips below relating to the development of such a plan and to what issues one should pay special attention in the course of backup planning.

Question has a verified solution.

If you are experiencing a similar issue, please ask a related question

Suggested Solutions

Title # Comments Views Activity
Query Optimization 14 44
Help Required 3 97
TSQL query to generate xml 4 35
T-SQL:  Collapsing 9 25
Occasionally there is a need to clean table columns, especially if you have inherited legacy data. There are obviously many ways to accomplish that, including elaborate UPDATE queries with anywhere from one to numerous REPLACE functions (even within…
In this article I will describe the Detach & Attach method as one possible migration process and I will add the extra tasks needed for an upgrade when and where is applied so it will cover all.
Using examples as well as descriptions, and references to Books Online, show the documentation available for date manipulation functions and by using a select few of these functions, show how date based data can be manipulated with these functions.
Viewers will learn how to use the UPDATE and DELETE statements to change or remove existing data from their tables. Make a table: Update a specific column given a specific row using the UPDATE statement: Remove a set of values using the DELETE s…

778 members asked questions and received personalized solutions in the past 7 days.

Join the community of 500,000 technology professionals and ask your questions.

Join & Ask a Question