Solved

SQL Server R2 Stored procedure make faster

Posted on 2016-10-31
7
54 Views
Last Modified: 2016-11-03
Hi Experts,

I was wondering if anyone could help me make this SP faster:

Use this ip for input: 10.124.208.208. 
 
Declare @DD_INPUT as varchar(128)
       Set @DD_INPUT = '10.124.208.208'--@INPUT
       Declare @DD_SCANDATE as Date
       set @DD_SCANDATE = (Select distinct top 1  sd.ScanDate  as [ScanDate]
                    from dflt.scandates as sd
                    Where sd.id in (Select distinct top 1 scandateid from dflt.device order by scandateid desc)
                    order by [ScanDate] desc)
 
;WITH CTE_SCANNED as (
SELECT
count(Case when   [Source type] = 'Nessus Scan' then 1 end) as [TotalScanned],
count(case when  [Source type] = 'Informational' then 1 end) as [Totalbad],
ScanDate, [Source type],[Branch Region], [Branch Network], Branch
 
From
(
SELECT Distinct dsfs.[DeviceID] as [DeviceID],  sd.ScanDate,
case when dsfs.pluginsource = 19506 then 'Nessus Scan' else 'Informational' end as [Source type], sos.OSName as [OS]
,FIP.[Branch Region], FIP.[Branch Network], FIP.Branch
  FROM [FODW_PVT].[Dflt].[Device_ScanInfo_Facts] as dsfs
  INNER JOIN (Select top 4 ID as ScandateID, Scandate from dflt.scandates order by [ScanDate] desc) as sd on sd.ScandateID = dsfs.ScandateID
  INNER JOIN [FODW_PVT].[Dflt].[Device] as d on d.deviceid = dsfs.deviceid
  inner JOIN [Dflt].[SystemsOS] as sos on d.OSID = sos.OSID  
  INNER JOIN dflt.Device_IPLong_FacilityIPRange sip on d.IPlong = sip.IPLong
  INNER JOIN dflt.FacilityIPRange as FIP on (sip.FacilityIPRangeID = FIP.ID)
 
  WHERE 
  (d.[IPAddress] = @DD_INPUT OR d.[Hostname]=@DD_INPUT) 
   AND dsfs.FactName in ( 'SMB Cannot Access Windows Registry',  'Authentication Failure', 'Nessus Windows Scan Performed Non Admin', 'SMB Registry Not Fully Accessible', 'Scan Start Date')
  AND dsfs.pluginsource in (26917, 21745, 24786, 10428, 19506)
  ) as X
 
  group by Scandate, [Branch Region], [Branch Network], Branch, 
  [Source type]
  )
 
  SELECT Sum(TotalScanned) as [TotalScanned], Sum(Totalbad) as [Totalbad], cs.ScanDate, [Branch Region], [Branch Network], Branch
  
  FROM CTE_SCANNED as cs
  GROUP BY cs.Scandate, [Branch Region], [Branch Network], Branch
  
  UNION ALL
 
  SELECT '0' as [TotalScanned] --In VS, 2 = No
  , '0' as [Totalbad] --In VS, 2 = N/A
  , sd.ScanDate,'Null' as [Branch Region], 'Null' as [Branch Network], 'Null' as Branch
  FROM (Select Top 4 ScanDate from dflt.ScanDates where scandate <= @DD_SCANDATE  order by ScanDate Desc) as sd
  LEFT JOIN (SELECT distinct top 4 Scandate from CTE_SCANNED where  scandate <= @DD_SCANDATE ) as cs on sd.ScanDate = cs.ScanDate
  WHERE cs.ScanDate is NULL

Open in new window

0
Comment
Question by:Amour22015
  • 3
  • 2
  • 2
7 Comments
 
LVL 28

Expert Comment

by:Pawan Kumar
ID: 41867760
Could you please attach the actual execution plan? Also you are using lot of Order Bys... Order by normally degrade the performance if the index is not used by the optimizer or if the index is not there.
0
 
LVL 10

Expert Comment

by:HuaMinChen
ID: 41867855
Hi,
Can you check if you have indexes on relevant columns on which you link the tables on INNER JOIN?
0
 

Author Comment

by:Amour22015
ID: 41869188
Yes I have indexes and found that was the problem, the table(s) had grown and not been indexed  for a while.

But looking at the query is there any suggestions on improving performance.  Or is the query the best one can do?


Thank you for responding.
0
Best Practices: Disaster Recovery Testing

Besides backup, any IT division should have a disaster recovery plan. You will find a few tips below relating to the development of such a plan and to what issues one should pay special attention in the course of backup planning.

 
LVL 28

Assisted Solution

by:Pawan Kumar
Pawan Kumar earned 250 total points
ID: 41869452
Ohhh now i think you should Update the stats on the large column and rebuild the indexes.  use below commands..

ALTER INDEX ALL ON tablename  
REBUILD;  

GO

UPDATE STATISTICS tableName;  
GO


Also these should be part of your Maintenance Plan.
0
 
LVL 10

Accepted Solution

by:
HuaMinChen earned 250 total points
ID: 41869457
Amour,
You check your query to see if it does work quickly or not. If not, you add proper indexes.
0
 
LVL 28

Assisted Solution

by:Pawan Kumar
Pawan Kumar earned 250 total points
ID: 41871607
Hi Amour22015
Any update on this?
0
 

Author Closing Comment

by:Amour22015
ID: 41871845
Yes this has been done, thanks great
0

Featured Post

PRTG Network Monitor: Intuitive Network Monitoring

Network Monitoring is essential to ensure that computer systems and network devices are running. Use PRTG to monitor LANs, servers, websites, applications and devices, bandwidth, virtual environments, remote systems, IoT, and many more. PRTG is easy to set up & use.

Question has a verified solution.

If you are experiencing a similar issue, please ask a related question

Naughty Me. While I was changing the database name from DB1 to DB_PROD1 (yep it's not real database name ^v^), I changed the database name and notified my application fellows that I did it. They turn on the application, and everything is working. A …
Ever needed a SQL 2008 Database replicated/mirrored/log shipped on another server but you can't take the downtime inflicted by initial snapshot or disconnect while T-logs are restored or mirror applied? You can use SQL Server Initialize from Backup…
This video shows how to use Hyena, from SystemTools Software, to bulk import 100 user accounts from an external text file. View in 1080p for best video quality.
With Secure Portal Encryption, the recipient is sent a link to their email address directing them to the email laundry delivery page. From there, the recipient will be required to enter a user name and password to enter the page. Once the recipient …

809 members asked questions and received personalized solutions in the past 7 days.

Join the community of 500,000 technology professionals and ask your questions.

Join & Ask a Question