t-sql need help on t-sql

I have a SQL getting error, see below test case.
Need Help on the second SQL, getting error (see below error message). Thank you very much

DECLARE @srvID                  varchar(100)
set @srvID = '2, 281';


 
SELECT cast(Value as smallint) srv_id FROM dbo.Split(@srvID , ',')

create table #tmp(      id int, SERVICE_ID smallint, First_Name varchar(100), last_Name varchar(100),SRV_PRICE smallmoney)  ;
    GO  
      insert into #tmp values(49304, 2, 'John', 'Doe', 180.00);
    insert into #tmp values(49304, 281, 'John', 'Doe', 35.00);
   
    GO
 

SELECT      SRV_PRICE,
      First_Name,
      Last_Name,
      SERVICE_ID
FROM       #tmp
WHERE      id = 49304
AND      SERVICE_ID IN
      ( CASE
             WHEN cast( @srvID as smallint) = 0 THEN (  SERVICE_ID  )
        ELSE
            (  SELECT cast(Value as smallint) FROM dbo.Split(@srvID , ',') )
        END
      )
      
 drop table  #tmp;



The first select get result as:
srv_id
2
281

the second select get the error:
Conversion failed when converting the varchar value '2, 281' to data type smallint.
jfreeman2010Asked:
Who is Participating?

[Product update] Infrastructure Analysis Tool is now available with Business Accounts.Learn More

x
I wear a lot of hats...

"The solutions and answers provided on Experts Exchange have been extremely helpful to me over the last few years. I wear a lot of hats - Developer, Database Administrator, Help Desk, etc., so I know a lot of things but not a lot about one thing. Experts Exchange gives me answers from people who do know a lot about one thing, in a easy to use platform." -Todd S.

Jim HornMicrosoft SQL Server Developer, Architect, and AuthorCommented:
>the second select get the error:  Conversion failed when converting the varchar value '2, 281' to data type smallint.
That's because this line uses the variable in an expression CASTing to a smallint without converting it to numeric values

      ( CASE 
             WHEN cast( @srvID as smallint) = 0 THEN (  SERVICE_ID  )

Open in new window

0
jfreeman2010Author Commented:
When I try this, still get the same error:

SELECT CONVERT(int, Value ) FROM dbo.Split(@srvID , ',')
0
Jim HornMicrosoft SQL Server Developer, Architect, and AuthorCommented:
Where is [Value] defined in your code, and what data type is it?

Please move all your code into a code block, and also include the code for the table valued function dbo.Split
0
Determine the Perfect Price for Your IT Services

Do you wonder if your IT business is truly profitable or if you should raise your prices? Learn how to calculate your overhead burden with our free interactive tool and use it to determine the right price for your IT services. Download your free eBook now!

jfreeman2010Author Commented:
ALTER Function [dbo].[Split] (
   @InputText Varchar(max),  
   @Delimiter Varchar(10))  
                           

RETURNS @Array TABLE (
   TokenID Int PRIMARY KEY IDENTITY(1,1),  
                                           
                                           
   Value Varchar(max))

AS

-----------------------------------------------------------
-- Function Split                                        --
--    • Returns a Varchar rowset from a delimited string --
-----------------------------------------------------------

BEGIN

   DECLARE
      @Pos Int,        
      @End Int,        
      @TextLength Int,  
      @DelimLength Int  

 
   SET @TextLength = DataLength(@InputText)

 
   IF @TextLength = 0 RETURN

   SET @Pos = 1
   SET @DelimLength = DataLength(@Delimiter)

   IF @DelimLength = 0 BEGIN  
      WHILE @Pos <= @TextLength BEGIN
         INSERT @Array (Value) VALUES (SubString(@InputText,@Pos,1))
         SET @Pos = @Pos + 1
      END
   END
   ELSE BEGIN
     
      SET @InputText = @InputText + @Delimiter
     
      SET @End = CharIndex(@Delimiter, @InputText)
      WHILE @End > 0 BEGIN
         
         INSERT @Array (Value) VALUES (SubString(@InputText, @Pos, @End - @Pos))
         
         SET @Pos = @End + @DelimLength
         
         SET @End = CharIndex(@Delimiter, @InputText, @Pos)
      END
   END
   
   RETURN

END

GO
0
Scott PletcherSenior DBACommented:
SELECT      SRV_PRICE,
      First_Name,
      Last_Name,
      SERVICE_ID
FROM       #tmp
WHERE      id = 49304
AND      (@srvID = '0' OR
      SERVICE_ID IN (  SELECT cast(Value as smallint) FROM dbo.Split(@srvID , ',')  )
      )
0

Experts Exchange Solution brought to you by

Your issues matter to us.

Facing a tech roadblock? Get the help and guidance you need from experienced professionals who care. Ask your question anytime, anywhere, with no hassle.

Start your 7-day free trial
jfreeman2010Author Commented:
Scott Pletcher - thank you very much for your help.  that works.
0
jfreeman2010Author Commented:
Scott Pletcher  did result my insure and should got 500 points.  I am what I did close this without give him the point.  Very Sorry Scott.  I did not mean that bad...
0
jfreeman2010Author Commented:
thanks
0
Scott PletcherSenior DBACommented:
You're welcome. I did get the points, but more importantly you got a good answer :).
0
It's more than this solution.Get answers and train to solve all your tech problems - anytime, anywhere.Try it for free Edge Out The Competitionfor your dream job with proven skills and certifications.Get started today Stand Outas the employee with proven skills.Start learning today for free Move Your Career Forwardwith certification training in the latest technologies.Start your trial today
T-SQL

From novice to tech pro — start learning today.