How would you fix this?

Bruce Gust
Bruce Gust used Ask the Experts™
Here's the code as it exists currently:


$lastsyncdatetime=new DateTime();
$subtract_thirty=strtotime('-30 day', strtotime($the_date));
$subtract_thirty_calc=date("Y-m-d", $subtract_thirty);

$syncyear = date('Y',$subtract_thirty);
$syncmonth =date('m',$subtract_thirty);		
$syncday = date('d',$subtract_thirty);	

while ($todaydatetime > $subtract_thirty_calc) {

//do some database stuff

$lastsyncdate = date("m/d/y",mktime(0,0,0,$syncmonth,$syncday,$syncyear));
$comptime = mktime(0,0,0,$syncmonth,$syncday,$syncyear);
$syncyear = date('Y',$comptime);
$syncmonth =date('m',$comptime);
$syncday = date('d',$comptime);	
//$lastsyncdatetime is now $subtract_thirty_calc and you've got to figure out how to increment that
$subtract_thirty_calc = new DateTime($syncyear.'-'.$syncmonth.'-'.$syncday);		


Open in new window

This isn't my code. My job is to clean it up and I've had a hard time up to this point just because there appeared to be several instances where they were using the DateTime object improperly. In other words, they were making comparisons and doing calculations on an object so when I went to test it, the system generated a warning saying that it needed a string.

That being the case, I went through and made some changes but I'm stuck. Right now it appears as though the above loop will advance the day, but, again, the very last line you've got $subtract_thirty_calc and it looks as though they're trying to increase the original date value by one day, but it's not working and I'm stuck as to how you would advance the day and not wind up with something like February 31st.

Bottom line: What do I need to do after $syncday++ to increment the $subtract_thirty_calc date and have it properly formatted so it can continue being used in the comparison that's happening at the top of the "while" loop?

Watch Question

Do more with

Expert Office
EXPERT OFFICE® is a registered trademark of EXPERTS EXCHANGE®
Most Valuable Expert 2017
Distinguished Expert 2018
You probably want to look at the DateTime->add() function
Or the strtotime() function
Most Valuable Expert 2011
Top Expert 2016
making comparisons and doing calculations on an object
That may be quite possible.  Can you please show us one of the instances that illustrates what you're concerned about?
when I went to test it, the system generated a warning
Please show us how you tested it, thanks.

If you haven't already spent a little time with this article, it might be helpful.

This might do what you need, but please consider the difference between a month and 30 days.  If you need a month, you almost certainly want a different calculation because most months do not have 30 days.  The article covers this issue in one of the code examples.

Please see:
<?php // demo/temp_brucegust.php

$current  = new DateTime();
$future   = new DateTime('Today + 30 days');
$interval = new DateInterval('P1D');
while ($current < $future)
    echo PHP_EOL . $current->format('Y-m-d');

Open in new window

Most Valuable Expert 2011
Top Expert 2016

stale question

Do more with

Expert Office
Submit tech questions to Ask the Experts™ at any time to receive solutions, advice, and new ideas from leading industry professionals.

Start 7-Day Free Trial