Undefined variable problem
Just starting to learn oo php. Probably a simple problem.
Here is some of the code from header.php
Here is some of the code from dbIntranet.php
I keep getting an error:
Notice: Undefined variable: serverName in C:\inetpub\wwwroot\portal2
What's up?
Here is some of the code from header.php
$serverName = "server\\exactsqlexpress";
$connectionInfoIntranet = array( "Database"=>"intranet", "UID"=>"???", "PWD"=>"???");
$connectionInfoPpp = array( "Database"=>"ppp", "UID"=>???", "PWD"=>"???");
Here is some of the code from dbIntranet.php
include("header.php");
class dbIntranet {
private $connIntranet;
function __construct(){
$this->open_connection();
}
public function open_connection() {
$this->connIntranet = sqlsrv_connect($serverName, $connectionInfoIntranet); <-----LINE 13
}
I keep getting an error:
Notice: Undefined variable: serverName in C:\inetpub\wwwroot\portal2
What's up?
Do more with
EXPERT OFFICE® is a registered trademark of EXPERTS EXCHANGE®
header.php is defining $serverName in the global scope. Code inside of a function or a class method can't see the global scope automatically - they only see the variables that are passed in or otherwise made explicitly available to them.
So you -could- do this to your class definition:
class dbIntranet {
private $connIntranet;
private $serverName; // New class property called serverName
function __construct($serverName){ // Change the constructor to accept a new parameter
$this->serverName = $serverName; // Copy the value of the parameter to the class property
$this->open_connection();
}
public function open_connection() {
$this->connIntranet = sqlsrv_connect($this->serverName, $connectionInfoIntranet); <-----LINE 13
}
...and then when you created a new instance of dbIntranet, you pass in your global variable:
$x = new dbIntranet($serverName);
So you -could- do this to your class definition:
class dbIntranet {
private $connIntranet;
private $serverName; // New class property called serverName
function __construct($serverName){ // Change the constructor to accept a new parameter
$this->serverName = $serverName; // Copy the value of the parameter to the class property
$this->open_connection();
}
public function open_connection() {
$this->connIntranet = sqlsrv_connect($this->serverName, $connectionInfoIntranet); <-----LINE 13
}
...and then when you created a new instance of dbIntranet, you pass in your global variable:
$x = new dbIntranet($serverName);
The same goes for $connectionInfoIntranet, by the way - it's defined as a global variable in your header, but it isn't passed in to your class anywhere, so it would ALSO throw that same undefined variable error unless you corrected it in the same way.
Also, some people might suggest using the "global" keyword to import the variable from the global scope into the local method/function scope like this:
public function open_connection() {
{
global $serverName;
global $connectionInfoIntranet;
$this->connIntranet = sqlsrv_connect($serverName
}
...but that is a BAD practice/design. It -will- work from a technical perspective, but it breaks the object-oriented nature of your class by adding dependencies to code and variable names that exist outside your class.
Also, some people might suggest using the "global" keyword to import the variable from the global scope into the local method/function scope like this:
public function open_connection() {
{
global $serverName;
global $connectionInfoIntranet;
$this->connIntranet = sqlsrv_connect($serverName
}
...but that is a BAD practice/design. It -will- work from a technical perspective, but it breaks the object-oriented nature of your class by adding dependencies to code and variable names that exist outside your class.
Premium Content
You need an Expert Office subscription to comment.Start Free Trial