Avatar of Crazy Horse
Crazy Horse
Flag for South Africa asked on

script logging me in even though database user activation value isn't equal to "yes"

This code should only let a user log in if they have activated their account. So, when someone registers the default for the database column is "no". Once they activate it will update to "yes".

$stmt = $link->prepare("SELECT `user_name`, `user_email`, `safe_id`, `access_level`, `user_pass`, `active` FROM `users` WHERE `user_email` = ?");
		$stmt->bind_param("s", $_POST['email']);
		$stmt->execute();
		$result = $stmt->get_result();
		$numRows = $result->num_rows;
		if($numRows > 0) {
			$_SESSION['user_details'] = $result->fetch_object();
			$db_pass = $_SESSION['user_details']->user_pass;
			if(password_verify(trim($_POST['password']), $db_pass) && ($_SESSION['user_details']->active == "yes")) {
// do some other stuff here
} else {
			echo error_message("Your account has not yet been activated");
		}

Open in new window


With this code, when they user tries to login, it shows the error message. If I try again it takes me to the dashboard or if I just press enter in the address bar again it takes me to the dashboard which I can't seem to figure out why.
PHP

Avatar of undefined
Last Comment
Ray Paseur

8/22/2022 - Mon
Ray Paseur

Any chance you have a cookie in play?  The PHP session uses a cookie.  Maybe you have multiple windows or multiple tabs open at the same time?  You might want to add a page footer containing var_dump($_SESSION, $_COOKIE);
Peos John

Can you print and check session and post values?
print_r($_SESSION);

Open in new window

and
print_r($_POST); 

Open in new window

Ray Paseur

See also:

https://www.experts-exchange.com/articles/11271/Understanding-Client-Server-Protocols-and-Web-Applications.html

https://www.experts-exchange.com/articles/11909/PHP-Sessions-Simpler-Than-You-May-Think.html  * The Fine Print

If you read those articles and understand them, and that's still not an adequate explanation, please post back and show us the var_dump() data requested above.
This is the best money I have ever spent. I cannot not tell you how many times these folks have saved my bacon. I learn so much from the contributors.
rwheeler23
Crazy Horse

ASKER
I solved the mystery. I had some code that I put on the login page which was meant to check if the user was already logged in. If they were logged in then instead of seeing the login page it should have taken them to their dashboard. I removed that code and now it works as expected. I will just have to relook at this code and figure out how to fix it.

function already_loggedin() {
	
	if(isset($_SESSION['user_details']->safe_id) || isset($_COOKIE['r_token'])) {
		
		header("location: dashboard.php");
		exit();
	}
} // end check if user already logged in.

Open in new window


I don't really get this though because even with an incorrect password it was taking me to the dashboard page. This session would only be set if the password was correct

if(isset($_SESSION['user_details']->safe_id) 

Open in new window

ASKER CERTIFIED SOLUTION
Ray Paseur

THIS SOLUTION ONLY AVAILABLE TO MEMBERS.
View this solution by signing up for a free trial.
Members can start a 7-Day free trial and enjoy unlimited access to the platform.
See Pricing Options
Start Free Trial
GET A PERSONALIZED SOLUTION
Ask your own question & get feedback from real experts
Find out why thousands trust the EE community with their toughest problems.