script logging me in even though database user activation value isn't equal to "yes"

Black Sulfur
Black Sulfur used Ask the Experts™
on
This code should only let a user log in if they have activated their account. So, when someone registers the default for the database column is "no". Once they activate it will update to "yes".

$stmt = $link->prepare("SELECT `user_name`, `user_email`, `safe_id`, `access_level`, `user_pass`, `active` FROM `users` WHERE `user_email` = ?");
		$stmt->bind_param("s", $_POST['email']);
		$stmt->execute();
		$result = $stmt->get_result();
		$numRows = $result->num_rows;
		if($numRows > 0) {
			$_SESSION['user_details'] = $result->fetch_object();
			$db_pass = $_SESSION['user_details']->user_pass;
			if(password_verify(trim($_POST['password']), $db_pass) && ($_SESSION['user_details']->active == "yes")) {
// do some other stuff here
} else {
			echo error_message("Your account has not yet been activated");
		}

Open in new window


With this code, when they user tries to login, it shows the error message. If I try again it takes me to the dashboard or if I just press enter in the address bar again it takes me to the dashboard which I can't seem to figure out why.
Comment
Watch Question

Do more with

Expert Office
EXPERT OFFICE® is a registered trademark of EXPERTS EXCHANGE®
Most Valuable Expert 2011
Top Expert 2016

Commented:
Any chance you have a cookie in play?  The PHP session uses a cookie.  Maybe you have multiple windows or multiple tabs open at the same time?  You might want to add a page footer containing var_dump($_SESSION, $_COOKIE);
Can you print and check session and post values?
print_r($_SESSION);

Open in new window

and
print_r($_POST); 

Open in new window

Most Valuable Expert 2011
Top Expert 2016

Commented:
See also:

https://www.experts-exchange.com/articles/11271/Understanding-Client-Server-Protocols-and-Web-Applications.html

https://www.experts-exchange.com/articles/11909/PHP-Sessions-Simpler-Than-You-May-Think.html  * The Fine Print

If you read those articles and understand them, and that's still not an adequate explanation, please post back and show us the var_dump() data requested above.

Author

Commented:
I solved the mystery. I had some code that I put on the login page which was meant to check if the user was already logged in. If they were logged in then instead of seeing the login page it should have taken them to their dashboard. I removed that code and now it works as expected. I will just have to relook at this code and figure out how to fix it.

function already_loggedin() {
	
	if(isset($_SESSION['user_details']->safe_id) || isset($_COOKIE['r_token'])) {
		
		header("location: dashboard.php");
		exit();
	}
} // end check if user already logged in.

Open in new window


I don't really get this though because even with an incorrect password it was taking me to the dashboard page. This session would only be set if the password was correct

if(isset($_SESSION['user_details']->safe_id) 

Open in new window

Most Valuable Expert 2011
Top Expert 2016
Commented:
even with an incorrect password it was taking me to the dashboard
Right, that's why I asked about cookies!

This may happen because of one of two factors, and either one will cause it.

Factor one:
isset($_SESSION['user_details']->safe_id)

Factor two:
isset($_COOKIE['r_token'])

Since the test is with || you're looking for either of these factors, not both.  It's usually a good design to have only one place to look for a fact like login status.

There's a solution set that works correctly in this article.  It might be a good idea to lay a foundation, then build up your application on top.
https://www.experts-exchange.com/articles/2391/PHP-Client-Registration-Login-Logout-and-Easy-Access-Control.html

Do more with

Expert Office
Submit tech questions to Ask the Experts™ at any time to receive solutions, advice, and new ideas from leading industry professionals.

Start 7-Day Free Trial