Link to home
Get AccessLog in
Avatar of Frank Batusic
Frank Batusic

asked on

Set WorkSheet not Working

After spending a lot of time reviewing answers on Experts Exchange (and select other Excel VBA Forums) I am attempting to rewrite existing code to eliminate the use of Select and Activate and incorporate "Cells" rather than always needing to convert a numeric value for a column to an alpha character.

My code module is developed for the explicit purpose of rolling out a new version of code.  The program builds a list of a user's existing files and then copies all pertinent data into the new program file.  While the code technically worked as it existed, the numerous times I used either "Select" or "Activate" I now know is not efficient code and also caused significant screen refreshes.

Without getting too detailed, the data table in each user's file can have a different number of columns with different data types by column.  So, as part of the code to migrate old data to the new program file I need to determine the last column and last row (of contiguous input, not last row on the sheet).  With the following code, I am attempting to change the WorkSheet for the file I am importing.  I have used the Set command to change the value of my WorkSheet variable "wsI".  However, when the code runs to establish the last column and last row values it is giving me the values from the previous WorkSheet.  

The variable "ImportWbk" is set to the name of the file from which I am copying data.  Using Debug.Print I have verified that ImportWbk is set to the correct filename.  After setting "wsI" (defined as WorkSheet variable) to "Analysis" I have confirmed via the Debug.Print command that it is indeed now set to "Analysis".

Can someone help me to get this corrected?

    Set wsI = ImportWbk.Worksheets("Analysis")
    Debug.Print wsI.Name
    With ImportWbk
        ImportLC = Sheets(wsI).Cells(21, Columns.Count).End(xlToLeft).Column
        ImportLR = Sheets(wsI).Range("A22").End(xlDown) - 1
    End With

Open in new window

ASKER CERTIFIED SOLUTION
Avatar of Rgonzo1971
Rgonzo1971

Link to home
membership
This content is only available to members.
To access this content, you must be a member of Experts Exchange.
Get Access
Avatar of Frank Batusic
Frank Batusic

ASKER

Rgonzo,

Thank you for the very quick response.  I made the changes you suggested and had partial success.  The variable ImporLC is now correctly set to 10.  However, ImportLR is still set to 216 which is still from the previous WorkSheet that wsI was set to.  

Here is my updated code:
    Set wsI = ImportWbk.Worksheets("Analysis")
    Debug.Print wsI.Name
    With ImportWbk
        ImportLC = wsI.Cells(21, Columns.Count).End(xlToLeft).Column
        ImportLR = wsI.Range("A22").End(xlDown) - 1
    End With

Open in new window

without a file it's difficult to have an opinion
SOLUTION
Link to home
membership
This content is only available to members.
To access this content, you must be a member of Experts Exchange.
Get Access
is the -1 one row less then try
ImportLR = wsI.Range("A22").End(xlDown).Offset( -1)

Open in new window

As per the variable ImportLR, it is supposed to hold the row number so the syntax should be like this...

ImportLR = wsI.Range("A22").End(xlDown).Row - 1
Neeraj,

Adding the ".Row" fixed the issue.  Thank you for your assistance.

Frank
You're welcome Frank! Glad I could help.
The modifications suggested by Rgonzo and Neeraj resolved by issue.  Thank you to both for lending your expertise!