Link to home
Start Free TrialLog in
Avatar of SteveL13
SteveL13Flag for United States of America

asked on

How search for records based on a specified date range

I have several unbound field on a "Search Form".  I also have a command button in the footer of the form.  The onclick event of the command button currently has this code:

Dim s As String

    If Nz(Me.txtRecordID, "") <> "" Then
        s = s & " [RecordID] Like '*" & Me.txtRecordID & "*'"
    End If

    If Nz(Me.txtPRn, "") <> "" Then
        If Len(s) > 0 Then
            s = s & " AND "
        End If
        s = s & " [PRn] Like '*" & Me.txtPRn & "*'"
    End If

    If Nz(Me.txtSKUn, "") <> "" Then
        If Len(s) > 0 Then
            s = s & " AND "
        End If
        s = s & " [SKUn] Like '*" & Me.txtSKUn & "*'"
    End If

    If Nz(Me.txtRevisionDate, "") <> "" Then
        If Len(s) > 0 Then
            s = s & " AND "
        End If
        s = s & " [RevisionDate] Like '*" & Me.txtRevisionDate & "*'"
    End If

    If Len(s) > 0 Then
        s = "SELECT * FROM [tblRecords] WHERE " & s & " Order by [RecordID]"
    Else
        s = "SELECT * FROM [tblRecords] " & " Order by [RecordID]"
    End If

    DoCmd.OpenForm "frmRecordsHeader", acNormal, , , acFormReadOnly, acWindowNormal
    
    Forms!frmRecordsHeader.Form!subfrmRecordsDS.Form.RecordSource = s

Open in new window


But on the form I will have two date fields.  txtStartDate and txtEndDate.  So instead of this part of the code:

    If Nz(Me.txtRevisionDate, "") <> "" Then
        If Len(s) > 0 Then
            s = s & " AND "
        End If
        s = s & " [RevisionDate] Like '*" & Me.txtRevisionDate & "*'"
    End If

Open in new window


I want to search where RevisionDate is between txtStartDate and txtEndDate.  How would I handle this?  What would the code:

    If Nz(Me.txtRevisionDate, "") <> "" Then
        If Len(s) > 0 Then
            s = s & " AND "
        End If
        s = s & " [RevisionDate] Like '*" & Me.txtRevisionDate & "*'"
    End If

Open in new window


Be changed to?
Avatar of SteveL13
SteveL13
Flag of United States of America image

ASKER

I've tried this but it doesn't work:

    If Nz(Me.txtStartDate, "") <> "" And Nz(Me.txtEndDate, "") <> "" Then
        If Len(s) > 0 Then
            s = s & " AND "
        End If
        s = s & " [RevisionDate] BETWEEN # & [txtStartDate] & # AND # & [txtEndDate] & #"
        
    End If

Open in new window

Avatar of Dale Fye
    If Nz(Me.txtStartDate, "") <> "" Then
        If Len(s) > 0 Then s = s & " AND "
        s = s & "([RevisionDate] >=  #" & Me.txtStartDate & "#)"
    End If

'I use the following syntax to make certain that if the RevisionDate field contains a time
'component, then all of the records pertaining to that date are included in the results.
    If Nz(Me.txtEndDate, "") <> "" Then
        If Len(s) > 0 Then s = s & " AND "
        s = s & "([RevisionDate] <  #" & DateAdd("d", 1, Me.txtEndDate) & "#)"
    End If

Open in new window

Dale,  Your suggested code doesn't seem to be working.  I'm getting no records when I click the command button
You just miss some quotes and - to play safe - to apply a forced format of the date expressions:

s = s & " [RevisionDate] BETWEEN #" & Format([txtStartDate], "yyyy\/mm\/dd") & "# AND #" & Format([txtEndDate], "yyyy\/mm\/dd") & "#"

Open in new window

/gustav
Still getting no re3cords with:

    If Nz(Me.txtStartDate, "") <> "" Then
        If Len(s) > 0 Then s = s & " AND "
        s = s & "([RevisionDate] >=  #" & Me.txtStartDate & "#)"
    End If

    If Nz(Me.txtEndDate, "") <> "" Then
        If Len(s) > 0 Then s = s & " AND "
        s = s & " [RevisionDate] BETWEEN #" & Format([txtStartDate], "yyyy\/mm\/dd") & "# AND #" & Format([txtEndDate], "yyyy\/mm\/dd") & "#"
    End If

Open in new window

Just for kicks I put this after the last line:

MsgBox s

And got:

User generated image
When I entered 9/6/2005 and 4/11/2007
you need to remove the first set of code

    If Nz(Me.txtRevisionDate, "") <> "" Then
        If Len(s) > 0 Then
            s = s & " AND "
        End If
        s = s & " [RevisionDate] Like '*" & Me.txtRevisionDate & "*'"
    End If

get rid of that and just use the code for txtStartDate and txtEndDate
Still no records with:  (Note I changed the formatting because I thought that might be the issue.  It didn't work either way)

    If Nz(Me.txtEndDate, "") <> "" Then
        If Len(s) > 0 Then s = s & " AND "
'        s = s & " [RevisionDate] BETWEEN #" & Format([txtStartDate], "yyyy\/mm\/dd") & "# AND #" & Format([txtEndDate], "yyyy\/mm\/dd") & "#"
        
        
        s = s & " [RevisionDate] BETWEEN #" & Format([txtStartDate], "mm\/dd\/yyyy") & "# AND #" & Format([txtEndDate], "mm\/dd\/yyyy") & "#"
        
    End If

Open in new window

Your message clearly shows your error.
I assumed your second code, thus:

If Nz(Me.txtStartDate, "") <> "" And Nz(Me.txtEndDate, "") <> "" Then
    If Len(s) > 0 Then
        s = s & " AND "
    End If
    s = s & " [RevisionDate] BETWEEN #" & Format([txtStartDate], "yyyy\/mm\/dd") & "# AND #" & Format([txtEndDate], "yyyy\/mm\/dd") & "#"
End If

Open in new window

/gustav
I don't know what I'm doing wrong.  Please see attached test file.  Enter 9/6/2005 and 4/11/2007 in the bottom two fields.  Then click [Search].  Nothing shows up in the results form.  Two records should show up.
Date-Range-Test.accdb
ASKER CERTIFIED SOLUTION
Avatar of Gustav Brock
Gustav Brock
Flag of Denmark image

Link to home
membership
This solution is only available to members.
To access this solution, you must be a member of Experts Exchange.
Start Free Trial
Redesigned the forms and used your latest code.  All is well.  Thank you.
You are welcome!

/gustav