JavaScript code not working

Please explain whey the following does not execute.

var counterModule = (function() {
	var counter = 0;
		
	return {
		incrementCounter: function () {
			 counter++;
       alert(counter++);
		},
		resetCounter: function () {
			counter = 0;
			alert("counter value prior to reset: " + counter);
		}
	};
}

counterModule.incrementCounter();
counterModule.incrementCounter();
counterModule.incrementCounter();
counterModule.resetCounter();

Open in new window

https://jsfiddle.net/isogunro/f2qjoqbs/

Thanks!

Actually I would expect the intended pattern to be an IIFE because the whole idea would be to create a self-contained class or 'module' to handle the counter functionality. By executing it more than once you lose that functionality. By changing it to use a global variable you're taking a step back instead of forward (in terms of code design).

The corrected code would be:

var counterModule = (function() {
	var counter = 0;
		
	return {
		incrementCounter: function () {
			 counter++;
       alert(counter++);
		},
		resetCounter: function () {
			counter = 0;
			alert("counter value prior to reset: " + counter);
		}
	};
})(); // note the result of the function execution being assigned to the variable instead of a reference to the function itself

counterModule.incrementCounter();
counterModule.incrementCounter();
counterModule.incrementCounter();
counterModule.resetCounter();

Open in new window

Some more errors are left in there (mainly related to the alerts) but I feel they can be resolved more easily once you have the module pattern implemented and working.

EDIT: updated fiddle here

I wear a lot of hats...

"The solutions and answers provided on Experts Exchange have been extremely helpful to me over the last few years. I wear a lot of hats - Developer, Database Administrator, Help Desk, etc., so I know a lot of things but not a lot about one thing. Experts Exchange gives me answers from people who do know a lot about one thing, in a easy to use platform." -Todd S.

LVL 44

zephyr_hex (Megan)DeveloperCommented: 2017-03-29

You are missing a )
If you use F12 console, you can see the error.

You also need paranthesis when you call counterModule

counterModule().incrementCounter();

Here's an updated Fiddle: https://jsfiddle.net/zephyr_hex/q8eowfja/

Next... you may want to use a globally scoped counter variable (move it outside the counterModule function). Otherwise, the increment isn't additive.

LVL 35

Robert SchuttSoftware EngineerCommented: 2017-03-29

Experts Exchange Solution brought to you by

Your issues matter to us.

Facing a tech roadblock? Get the help and guidance you need from experienced professionals who care. Ask your question anytime, anywhere, with no hassle.

Start your 7-day free trial

LVL 5

IsaacSharePoint Client Side DeveloperAuthor Commented: 2017-03-29

Thank you!

JavaScript code not working

Who is Participating?