Avatar of legolasthehansy
legolasthehansy
 asked on

Python Script to return all instances in all regions

I'm trying to get all running instances in all regions to shut them down off hours and this is the script I use. However, I get a Syntax error: return outside function. It maybe a indentation problem which I'm not able find out. Can you help?

import boto3
import logging

client = boto3.client('ec2')

instances = []
for region in client.describe_regions()['Regions']:
    ec2 = boto3.resource('ec2', region_name=region['RegionName'])
    result = ec2.instances.filter(Filters=[{'Name': 'instance-state-name', 'Values': ['running']}])
for instance in result:
    instances.append(instance.id)
return instances

print instances

Open in new window

PythonAWS

Avatar of undefined
Last Comment
legolasthehansy

8/22/2022 - Mon
ZhaawZ

Remove line 12 ("return instances")
legolasthehansy

ASKER
Thanks for your response. But how do I see the output or see the results of running instances?
ASKER CERTIFIED SOLUTION
ZhaawZ

Log in or sign up to see answer
Become an EE member today7-DAY FREE TRIAL
Members can start a 7-Day Free trial then enjoy unlimited access to the platform
Sign up - Free for 7 days
or
Learn why we charge membership fees
We get it - no one likes a content blocker. Take one extra minute and find out why we block content.
Not exactly the question you had in mind?
Sign up for an EE membership and get your own personalized solution. With an EE membership, you can ask unlimited troubleshooting, research, or opinion questions.
ask a question
legolasthehansy

ASKER
That was it. The second for loop did not have a indentation as expected and didn't give me an output I was expecting. Cheers!
This is the best money I have ever spent. I cannot not tell you how many times these folks have saved my bacon. I learn so much from the contributors.
rwheeler23