Python Script to return all instances in all regions
I'm trying to get all running instances in all regions to shut them down off hours and this is the script I use. However, I get a Syntax error: return outside function. It maybe a indentation problem which I'm not able find out. Can you help?
import boto3
import logging
client = boto3.client('ec2')
instances = []
for region in client.describe_regions()['Regions']:
ec2 = boto3.resource('ec2', region_name=region['RegionName'])
result = ec2.instances.filter(Filters=[{'Name': 'instance-state-name', 'Values': ['running']}])
for instance in result:
instances.append(instance.id)
return instances
print instances
Do more with
EXPERT OFFICE® is a registered trademark of EXPERTS EXCHANGE®
I haven't used AWS, Amazon EC2 or boto3, so I can only guess what "instance" means in this case.
1) You should remove "return instances", because keyword "return" may be used only in functions to return function's result. In your case, you don't have any function there, therefore you got syntax error. After removing that line, you should get some output (assuming that there are no other errors).
2) I believe you should indent lines 10 and 11, otherwise the second loop (for instance in result) is executed only for last value of "result" variable. If the first loop is not run at all, you will probably get "name 'result' is not defined" exception.
3) line 14 ("print instances") should print to stdout(?) contents of "instances" list. I have no idea how you run the script. If run it from the console, you should see the output in the console.
1) You should remove "return instances", because keyword "return" may be used only in functions to return function's result. In your case, you don't have any function there, therefore you got syntax error. After removing that line, you should get some output (assuming that there are no other errors).
2) I believe you should indent lines 10 and 11, otherwise the second loop (for instance in result) is executed only for last value of "result" variable. If the first loop is not run at all, you will probably get "name 'result' is not defined" exception.
3) line 14 ("print instances") should print to stdout(?) contents of "instances" list. I have no idea how you run the script. If run it from the console, you should see the output in the console.
Premium Content
You need an Expert Office subscription to comment.Start Free Trial