MS Access My Loop Code Returns Record 1 Several Times Instead Of 4 Individual Records Why?

you need to reinitialise the xmlstring for each line in the loop.
First you need to write the beginning of the xml file:

XmlString = "<PrivateListing>1</PrivateListing>" & vbNewLine
    XmlString = XmlString & "<ProductListingDetails> ProductListingDetailsType" & vbNewLine
Print #FileNumber, XmlString

Select allOpen in new window

Then, in the loop you need to initialise the inner body of the XML:

Do While Not rst.EOF
     
Manufacture = rst("Manufacture")
MPN = rst("MPN")


      XmlString = "<BrandMPN>" & vbNewLine
        XmlString = XmlString & "<Brand>" & Manufacture & "</Brand>" & vbNewLine ' Manufacture
        XmlString = XmlString & "<MPN>" & MPN & "</MPN>" & vbNewLine ' MPN
      XmlString = XmlString & "</BrandMPN>" & vbNewLine     
    Print #FileNumber, XmlString ' Append our string
     
    rst.MoveNext
Loop
rst.Close
Set rst = Nothing

Select allOpen in new window

And then you need to add the remaining part and close the file:

    XmlString = "</ProductListingDetails> " & vbNewLine
    Print #FileNumber, XmlString ' Append our string
Close #FileNumber                       ' Close the file

Select allOpen in new window

Right now it is giving me this: (All record 1)

<PrivateListing>1</PrivateListing>
    <ProductListingDetails> ProductListingDetailsType
      <BrandMPN>
        <Brand>TOSHIBA</Brand> 
        <MPN>LAPTOP123</MPN>
      </BrandMPN>
      <UPC>786958125896</UPC>

<PrivateListing>1</PrivateListing>
    <ProductListingDetails> ProductListingDetailsType
      <BrandMPN>
        <Brand>TOSHIBA</Brand> 
        <MPN>LAPTOP123</MPN>
      </BrandMPN>
      <UPC>786958125896</UPC>


<PrivateListing>1</PrivateListing>
    <ProductListingDetails> ProductListingDetailsType
      <BrandMPN>
        <Brand>TOSHIBA</Brand> 
        <MPN>LAPTOP123</MPN>
      </BrandMPN>
      <UPC>786958125896</UPC>


<PrivateListing>1</PrivateListing>
    <ProductListingDetails> ProductListingDetailsType
      <BrandMPN>
        <Brand>TOSHIBA</Brand> 
        <MPN>LAPTOP123</MPN>
      </BrandMPN>
      <UPC>786958125896</UPC>

Select allOpen in new window

But I need this: (Record 1-4)

<PrivateListing>1</PrivateListing>
    <ProductListingDetails> ProductListingDetailsType
      <BrandMPN>
        <Brand>TOSHIBA</Brand> 
        <MPN>LAPTOP123</MPN>
      </BrandMPN>
      <UPC>786958125896</UPC>

<PrivateListing>1</PrivateListing>
    <ProductListingDetails> ProductListingDetailsType
      <BrandMPN>
        <Brand>GE</Brand> 
        <MPN>Fridge457</MPN>
      </BrandMPN>
      <UPC>786933325896</UPC>


<PrivateListing>1</PrivateListing>
    <ProductListingDetails> ProductListingDetailsType
      <BrandMPN>
        <Brand>Johnson</Brand> 
        <MPN>LP90HJ</MPN>
      </BrandMPN>
      <UPC>787628125896</UPC>


<PrivateListing>1</PrivateListing>
    <ProductListingDetails> ProductListingDetailsType
      <BrandMPN>
        <Brand>Jerry's</Brand> 
        <MPN>H77Red</MPN>
      </BrandMPN>
      <UPC>786958128965</UPC>

Select allOpen in new window

Here is the whole code if it is easier for you:

Dim Manufacture As String
Dim MPN As String
Dim UPC As String
'******************************************************************************************************
'Loop Code
'*****************************************************************************************************
Dim sFile As String
Dim sText As String
Dim FileNumber As Integer
Dim rst As DAO.Recordset

sFile = "C:\Users\Station\Documents\Access XML Save Files\ChilKat\Append.xml"
sText = XmlString
FileNumber = FreeFile                   ' Get unused file number

Open sFile For Append As #FileNumber    ' Connect to the file
    
Set rst = CurrentDb.OpenRecordset("Qry_EbayAddFixedPriceItem1", dbOpenSnapshot)
Do While Not rst.EOF
     
Manufacture = rst("Manufacture")
MPN = rst("MPN")
UPC = rst("UPC")
     
XmlString = "<PrivateListing>1</PrivateListing>" & vbNewLine
    XmlString = XmlString & "<ProductListingDetails> ProductListingDetailsType" & vbNewLine
      XmlString = XmlString & "<BrandMPN>" & vbNewLine
        XmlString = XmlString & "<Brand>" & Manufacture & "</Brand>" & vbNewLine ' Manufacture
        XmlString = XmlString & "<MPN>" & MPN & "</MPN>" & vbNewLine ' MPN
      XmlString = XmlString & "</BrandMPN>" & vbNewLine
      XmlString = XmlString & "<UPC>" & UPC & "</UPC>" & vbNewLine ' UPC

    Print #FileNumber, sText                ' Append our string
     
    rst.MoveNext
Loop
rst.Close
Set rst = Nothing

Close #FileNumber                       ' Close the file

Select allOpen in new window

That is not working. It is the same effect....Thanks though.

Thank you that works Great. I am sorry but what is it that wasn't right????

Was it that my XmlString wasn't inside the loop???

And I assume you did not copy my code verbatim,

I did but then i replaced sText with XmlString and it gave the same effects.

The darn Dlookups....I know they are not the best choice but I didn't know that. I knew there was other ways but was unsure.

So just to confirm the real problem here was the Dlookups and once they were replaced with
Manufacture = rst("Manufacture")
MPN = rst("MPN")
UPC = rst("UPC")

then all is good? Nothing else.

Awesome! Thanks a ton. I see now what you are sayng!