asked on

HTML file with PHP File

Hello,

I have a HTML "Contact" page.
When you click Submit it uses a contact.php file to write to a database.
Currently I am getting this error. It relates to adding the next ID automatically but I can't seem to get it working.
Is anyone able to assist please?

Here is the error:

My PHP file is below.

<!DOCTYPE HTML>
<html>
<head>
<title>Contact</title>
<meta charset="utf-8">

</head>
<body>

<?php 
error_reporting(E_ALL);
ini_set('display_errors', 1);
?>


<?php 

  /* Set oracle user login and password info */
  $dbuser = ;  
  $dbpass = ;  
  $db = ; 
  $connect = oci_connect($dbuser, $dbpass, $db); 

   /* Display connection error if fails */
  if (!$connect)  {
    echo "An error occurred connecting to the database"; 
    exit; 
  }
  
  

  //Extract CGI variables
  $firstname=$_POST['firstname'];
  $lastname=$_POST['lastname'];
  $address=$_POST['address'];
  $phone=$_POST['phone'];
  $email=$_POST['email'];
  $subject=$_POST['subject'];
  $comment3=$_POST['comment3'];
 
  

   /* check the sql statement for errors and if errors report them */
  $stmt = oci_parse($connect, $query_count); 

  if(!$stmt)  {
    echo "An error occurred in parsing the sql string.\n"; 
    exit; 
  }

  oci_execute($stmt);
  if (oci_fetch_array($stmt))  {
	
	$count = oci_result($stmt,1);//returns the data for column 1 
	echo "<strong><font color=red>* * The below SQL INSERT INTO Statement is displayed for the purpose of Assignment 2-2 to verify Form data collected has been written to the SQL Tables * *</font></strong><br><br>";
	

  } else {
	echo "An error occurred in retrieving order id.\n"; 
	exit; 
  }

  $count++;
	/* echo $count."</br>"; */

  // Create the SQL statement to add the data
  $query = "INSERT INTO Contact (ID, firstname, lastname, address, phone, email, subject, comment3) VALUES ($count, '$firstname', '$lastname', '$address', '$phone', '$email', '$subject', '$comment3')"; 

  echo $query."</br></br>";
  
  /* check the sql statement for errors and if errors report them */
  $stmt = oci_parse($connect, $query); 
	
 //echo "SQL: $query<br>";

  if(!$stmt)  {
    echo "An error occurred in parsing the sql string.\n"; 
    exit; 
  }

  oci_execute($stmt);

  
  /* check the sql statement for errors and if errors report them */
  $stmt = oci_parse($connect, $query_count); 

  if(!$stmt)  {
    echo "An error occurred in parsing the sql string.\n"; 
    exit; 
  }

  oci_execute($stmt);
  if (oci_fetch_array($stmt))  {
	
	$product = oci_result($stmt,1);//returns the data for column 1 
	// echo $product."</br>";

  } else {
	echo "An error occurred in retrieving order id.\n"; 
	exit; 
  }

  //$product++;

 

 
  //display a receipt with all the order details
  echo ("<p>====================== <strong>EMAIL RECEIPT</strong> =============================</p>");
  echo $date = date('d-m-y H:i:s');
  echo ("<p><h2><font color=blue>Thank you for contacting us.</font></h2></p>");
 	  

echo ("<p><strong>First Name: </strong>".$firstname. "</p>");
echo ("<p><strong>Last Name: </strong>".$lastname. "</p>");
echo ("<p><strong>Address: </strong>".$address. "</p>");
echo ("<p><strong>Phone: </strong>".$phone. "</p>");
echo ("<p><strong>Email: </strong>".$email. "</p>");
echo ("<p><strong>Subject: </strong>".$subject. "</p>");
echo ("<p><strong>Comments: </strong>".$comment3. "</p>");
	  

  echo ("<p>====================== END OF RECEIPT =============================</p>");


  

// Close the connection
oci_close($connect); 
?>


</body>
</html>

Open in new window

My HTML file is below

<!DOCTYPE html>
<html lang="en">
<head>

<style>
h4 {
	background-color: #e1e1d0;
	padding: 5px;
	}

#Footer
	{border: 1px solid black;
	padding: 5px;
	text-align: center;
	}

input, textarea {margin-top: 10px;
		margin-bottom: 10px;
		padding: 5px;
		width: 40%;
		}
	
#submit	{margin-left: 5px; 
		padding-right: 12px;
		}
		
#Menu {background-color: #b8bac6;
		padding: 20px;}
	
</style>

<title>BooksRUS</title>
<link rel="stylesheet" href="styles2.css" type="text/css">
<meta charset=utf-8>
</head>
<body>

<div id="Container">
	<div id="Header"><h1>BooksRUS</h1>
<h3>Best Secondhand Book Shop in Geelong</h3></div>
	<div id="Menu"><b><a href="index.html">Home</a> | <a href="books.html">Books</a> | <a href="orderbooks.html">Order Books</a> | <a href="faq.html">FAQ</a> | <a href="contact.html">Contact</a></b>
	</div>
	<div id="MainBody"></div>
	<p><h4 style="Color:#3498DB">Contact Information</h4>
	123 Moorabool Street 
	<br>
	Geelong VIC 3220
	<br>
	Tel: 03 5244 1234
	<br>
	Email: <a href="mailto:contact@booksrus.com.au">contact@booksrus.com.au</a>

	
	<p><h4 style="Color:#3498DB">Trading Hours</h4>
	<p>Our business trading hours are: 9:00am to 6:00pm Monday to Sunday</p>
		
<form action="contact.php" method="post" name="contact" id="contactus">	    

<fieldset>
 <legend>Contact Us:</legend>
		First Name: <br><input type="text" name="firstname"><br>
		Last Name:  <br><input type="text" name="lastname"><br>
		Address:    <br><input type="text" name="address"><br>
		Phone:      <br><input type="text" name="phone"><br>
		Email::     <br><input type="email" name="email"><br>
		Subject:    <br><input type="subject" name="subject"><br>
		Comments:   <br><textarea name="comment3"></textarea>
</fieldset>
		
		<div id="submit">
		<input type="submit" value="Submit">
		<input type="reset" value="Clear the Form">
		</div><br>
</form>
		

</body>
</html>

Open in new window

Chris Stanyon

The error tells you that $query_count is not defined on line 44. Line 44 is this:

$stmt = oci_parse($connect, $query_count);

You have no variable in your file called $query_count.

The oci_parse method is ued to prepare a query, so at some point before line 44, you'd need your query:

$query_count = "SELECT something FROM somwehere";

jspc

ASKER

I'm wanting the next Primary ID to be automatically populated - that's what the query_count is but not sure I have the correct idea in place.

Chris Stanyon

OK. If your DB has an auto-increment primary key, then you don't need to request the ID from the database. You simply insert a record without an ID and it will automatically be given it by the DB

If that's the case, then you can remove lines 44-65 and 84-105. You would also need to remove the ID column and $count value from the query on line 66:

$query = "INSERT INTO Contact (firstname, lastname, address, phone, email, subject, comment3) VALUES ('$firstname', '$lastname', '$address', '$phone', '$email', '$subject', '$comment3')";

If you don't have an auto-incrementing ID, then you'll need to send a query to your database to get one. Depends on your scheme, but something like this before line 44:

$query_count = "SELECT Max(id) from yourTable";