MS Access SQL Syntax

thandel
thandel used Ask the Experts™
on
Hi I am trying to use SQL to update a table  (tEmailRx) with information from a form.  The table is laid out as:

CreateDate  - Date
MR - Number (long Int)
RxType - Text
Office - Text
Ws - Text

I am trying to use the following code:
    sSQL = "UPDATE tEmailRx tEmailRx.CreateDate = #" & Date & "#, tEmailRx.MR = " & Me.ID & ", tEmailRx.RxType='CL', tEmailRx.Office='" & sOffice & ",tEmailRx.Ws = Environ$(""computername"")"
    DoCmd.RunSQL sSQL

Open in new window

Which results in:

UPDATE tEmailRx tEmailRx.Date = #11-15-2017#, tEmailRx.MR = 126011, tEmailRx.RxType='CL', tEmailRx.Office='WB,tEmailRx.Ws = Environ$("computername")

But I am getting an error.  What am I doing wrong with my syntax?  SQL is a very weak link for me - Thanks!
Comment
Watch Question

Do more with

Expert Office
EXPERT OFFICE® is a registered trademark of EXPERTS EXCHANGE®
NorieAnalyst Assistant

Commented:
You need to use SET.
sSQL = " UPDATE tEmailRx SET tEmailRx.CreateDate = #" & Date & "#, tEmailRx.MR = " & Me.ID & ", tEmailRx.RxType='CL', tEmailRx.Office='" & sOffice & ",tEmailRx.Ws = '" & Environ$("computername") & "'"
    
DoCmd.RunSQL sSQL

Open in new window

Author

Commented:
Thank you, so silly but there must be a small error as now the error is syntax error missing operator in query expression "WB,tEmail.Rx.Ws = 'Jupiter"
NorieAnalyst Assistant

Commented:
Strange, in the code you have tEmailRx.Ws but the error message says you have tEmail.Rx.Ws.

What happens if you use the field names without the table name in the SET part.
sSQL = " UPDATE tEmailRx SET CreateDate = #" & Date & "#, MR = " & Me.ID & ", RxType='CL', Office='" & sOffice & ",Ws = '" & Environ$("computername") & "'"
    
DoCmd.RunSQL sSQL

Open in new window

Ensure you’re charging the right price for your IT

Do you wonder if your IT business is truly profitable or if you should raise your prices? Learn how to calculate your overhead burden using our free interactive tool and use it to determine the right price for your IT services. Start calculating Now!

Author

Commented:
I modified to this

sSQL = " UPDATE tEmailRx SET tEmailRx.CreateDate = #" & Date & "#, tEmailRx.MR = " & Me.ID & ", tEmailRx.RxType='CL', tEmailRx.Office='" & sOffice & "',tEmailRx.Ws = '" & Environ$("computername") & "'"code]

Open in new window

Not getting any error but nothing is happening to the table.

Author

Commented:
I tried your code similar error

Author

Commented:
oh wait slightly different.... "Wb,Ws = 'Jupiter".
NorieAnalyst Assistant

Commented:
I think there's a missing ' in what I posted.

Try this, I think I fixed it.
sSQL = " UPDATE tEmailRx SET CreateDate = #" & Date & "#, MR = " & "Me.ID" & ", RxType='CL', Office='" & "sOffice" & "',Ws = '" & Environ$("computername") & "'"

    
DoCmd.RunSQL sSQL

Open in new window

Author

Commented:
Well now its prompting me for a value of Me.Id
Analyst Assistant
Commented:
Sorry, my mistake - it's late here.

Try this.

sSQL = " UPDATE tEmailRx SET CreateDate = #" & Date & "#, MR = " & Me.ID & ", RxType='CL', Office='" & sOffice & "',Ws = '" & Environ$("computername") & "'"

Open in new window

Author

Commented:
Is Update correct I want to keep adding a row to the table with this... I can't remember if update is what I need to do that.

Author

Commented:
Ah bingo that worked thanks... but it does seem to only  update the first row... I would like to add to the table with each execution
NorieAnalyst Assistant

Commented:
UPDATE is for updating a table not adding to it, If you want to add to it then you need INSERT.

In fact if your UPDATE query had run successfully it might update every record in the table.

Author

Commented:
Oh I see, to make a insert would I just change Update to Insert?
NorieAnalyst Assistant

Commented:
Not quite, the syntax is a bit different and there are different types of INSERT.

If you wanted to add a record with the values in your UPDATE query it might look something like this.
sSQL = " INSERT INTO tEmailRx (CreateDate, MR, RxType, Office, Ws)
sSQL = sSQL & " VALUES (#" & Date & "#, " & Me.ID & ",'CL', '" & sOffice & "','" & Environ$("computername") & "')"

Open in new window

Author

Commented:
OK thanks but trying the code no errors but no updates to the table either
NorieAnalyst Assistant

Commented:
Can you post the rest of your code?

Author

Commented:
yes but not sure what part you need?  Its really press the button and the SQL runs.

Author

Commented:
Private Sub RxOpEmail_Click()
    sSQL = "INSERT INTO tEmailRx (CreateDate, MR, RxType, Office, Ws)"
    sSQL = sSQL & " VALUES (#" & Date & "#, " & Me.ID & ",'CL', '" & sOffice & "','" & Environ$("computername") & "')"
    DoCmd.RunSQL sSQL
End Sub

Open in new window

Author

Commented:
I'm sorry it is working!  I had the table open and assume it would refresh... even if I clicked on another row but it didn't.  When I closed and reopened the table it was visible.  I apologize for the over sight.

Do more with

Expert Office
Submit tech questions to Ask the Experts™ at any time to receive solutions, advice, and new ideas from leading industry professionals.

Start 7-Day Free Trial