VB.NET Sql Parameters: I need help!

I decided to clean up my code moving some Sub from my Forms in a new class, but when i did it Sql parameters start doing weird things! someone can tell me what happened? thanks!

Public Sub Delete(ByVal Table As String)
        //Opening connection
        Conn()
        myConn.Open()
        //Clearing transactions chronology
        Dim Sql As String = "Delete from @Table"
        myCmd = New SqlCommand(Sql, myConn)
        myCmd.Parameters.Add("@Table", SqlDbType.VarChar).Value = Table
        myCmd.ExecuteNonQuery()
        MsgBox("Cronologia ordini canellata.")
        myConn.Close()
End Sub
 
Private Sub Del_Click(ByVal sender As System.Object, ByVal e As System.EventArgs) Handles Del.Click
        Dim Tool As New SQLTools()
        Tool.Delete("Movimento")
    End Sub

Open in new window


Visual Studio throw an SqlException "Declare variable @Table" on line
Dim Sql As String = "Delete from @Table"

Open in new window


Sub Delete

Open in new window

and
Sub Del_Click

Open in new window

are sub of two different classes. https://pastebin.com/L1gxvS4X
Simone GarofaloAsked:
Who is Participating?

[Product update] Infrastructure Analysis Tool is now available with Business Accounts.Learn More

x
I wear a lot of hats...

"The solutions and answers provided on Experts Exchange have been extremely helpful to me over the last few years. I wear a lot of hats - Developer, Database Administrator, Help Desk, etc., so I know a lot of things but not a lot about one thing. Experts Exchange gives me answers from people who do know a lot about one thing, in a easy to use platform." -Todd S.

Kyle AbrahamsSenior .Net DeveloperCommented:
I don't believe you can delete from a table that way.

I would do a replace instead.

Dim Sql As String = Replace("Delete from @Table", "@Table", Table)

Open in new window

0
Simone GarofaloAuthor Commented:
I will try it! but if a try this query "DELETE FROM [table_name]" on my db, ti works fine
0
Kyle AbrahamsSenior .Net DeveloperCommented:
but that's not what your code is doing.

your code is essentially doing:

declare @table varchar(100)
set @table = 'nameoftable'
delete from @table

you either have to convert that to dynamic sql or just pass in the correct query.

Normally parameters are used for a where clause.

EG:

delete from table where id = @id

then you would pass in @id.  The query doesn't change, just the parameter value.
0

Experts Exchange Solution brought to you by

Your issues matter to us.

Facing a tech roadblock? Get the help and guidance you need from experienced professionals who care. Ask your question anytime, anywhere, with no hassle.

Start your 7-day free trial
Kyle AbrahamsSenior .Net DeveloperCommented:
Auto Close.
0
It's more than this solution.Get answers and train to solve all your tech problems - anytime, anywhere.Try it for free Edge Out The Competitionfor your dream job with proven skills and certifications.Get started today Stand Outas the employee with proven skills.Start learning today for free Move Your Career Forwardwith certification training in the latest technologies.Start your trial today
Visual Basic.NET

From novice to tech pro — start learning today.