We help IT Professionals succeed at work.

Why doesn't my Powershell script work?

Steve Williams
on
109 Views
1 Endorsement
Last Modified: 2018-04-19
I have a Powershell script that seems to run ok, no errors and taxes the CPU, but does not do anything. The server will run this Monday Thru Friday at 7 pm.  The purpose of this is to find all pdf files that was created yesterday and move them to a new directory named by the LastWriteTime.Date.  When our ERP system does its end of the day, it generates all the assembly releases, in pdf format,  for the next day to be built. These are created in the directory named 'release_only'. We like to keep this directory clean so it doesn't get cluttered and eventually slow down another script that we run from the same location.

$src = '\\svr1\assembly_dept\schedule\release_only'

$dst = '\\svr1\assembly_dept\shedule\release_archive'

$file = Get-ChildItem -Path $src -Include '*.pdf' | Where{$_.LastWriteTime -eq (Get-Date).AddDays(-1)}

if ($file = (Get-ChildItem -Path $src -Include '*.pdf' | Where{$_.LastWriteTime -eq (Get-Date).AddDays(-1)}))
{
   $dstdir = $dst + '\' + $file.LastWriteTime.Date.ToString('yyyy') + '\' + $file.LastWriteTime.Date.ToString('MM - MMM') + '\' + $file.LastWriteTime.Date.ToString('MMM. dd')
 
   if(!(test-path $dstdir))
     {
      New-Item -ItemType Directory -Force -Path $dstdir
     }
   Move-Item -Path $src -Destination  $dstdir

Open in new window


I could use a second set of eyes to help me figure this one out. Would really appreciate some help.
Comment
Watch Question

NorieAnalyst Assistant
CERTIFIED EXPERT
Commented:
This one is on us!
(Get your first solution completely free - no credit card required)
UNLOCK SOLUTION
Steve WilliamsProduct Design Engineer

Author

Commented:
I did as you suggested and that didn't help. I then changed these to lines of code to include the date format. And that didn't help any either.

$file = Get-ChildItem -Path $src -Include '*.pdf' | Where{$_.LastWriteTime.Date.ToString('yyyyMMdd') -eq (Get-Date).AddDays(-1).ToString('yyyyMMdd') }

if ($file = (Get-ChildItem -Path $src -Include '*.pdf' | Where{$_.LastWriteTime.Date.ToString('yyyyMMdd') -eq (Get-Date).AddDays(-1).ToString('yyyyMMdd') }))

Open in new window

NorieAnalyst Assistant
CERTIFIED EXPERT
Commented:
This one is on us!
(Get your first solution completely free - no credit card required)
UNLOCK SOLUTION
Steve WilliamsProduct Design Engineer

Author

Commented:
Norie, No I do not.
NorieAnalyst Assistant
CERTIFIED EXPERT
Commented:
This one is on us!
(Get your first solution completely free - no credit card required)
UNLOCK SOLUTION
CERTIFIED EXPERT
Most Valuable Expert 2019
Most Valuable Expert 2018
Commented:
This one is on us!
(Get your first solution completely free - no credit card required)
UNLOCK SOLUTION
Steve WilliamsProduct Design Engineer

Author

Commented:
oBda, That did the trick worked like a charm. Then I removed the  -WhatIf, run it again and it moved all the files.

Norie, Thanks for your help. Appreciate your time.
Steve WilliamsProduct Design Engineer

Author

Commented:
Thanks all!

Gain unlimited access to on-demand training courses with an Experts Exchange subscription.

Get Access
Why Experts Exchange?

Experts Exchange always has the answer, or at the least points me in the correct direction! It is like having another employee that is extremely experienced.

Jim Murphy
Programmer at Smart IT Solutions

When asked, what has been your best career decision?

Deciding to stick with EE.

Mohamed Asif
Technical Department Head

Being involved with EE helped me to grow personally and professionally.

Carl Webster
CTP, Sr Infrastructure Consultant
Empower Your Career
Did You Know?

We've partnered with two important charities to provide clean water and computer science education to those who need it most. READ MORE

Ask ANY Question

Connect with Certified Experts to gain insight and support on specific technology challenges including:

  • Troubleshooting
  • Research
  • Professional Opinions
Unlock the solution to this question.
Join our community and discover your potential

Experts Exchange is the only place where you can interact directly with leading experts in the technology field. Become a member today and access the collective knowledge of thousands of technology experts.

*This site is protected by reCAPTCHA and the Google Privacy Policy and Terms of Service apply.

OR

Please enter a first name

Please enter a last name

8+ characters (letters, numbers, and a symbol)

By clicking, you agree to the Terms of Use and Privacy Policy.